Change in ...coreboot[master]: drivers/intel/fsp1_1/raminit.c: Always check FSP HOBs
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29371 ) Change subject: drivers/intel/fsp1_1/raminit.c: Always check FSP HOBs ...................................................................... Patch Set 9: (3 comments) https://review.coreboot.org/#/c/29371/9/src/drivers/intel/fsp1_1/raminit.c File src/drivers/intel/fsp1_1/raminit.c: https://review.coreboot.org/#/c/29371/9/src/drivers/intel/fsp1_1/raminit.c@a... PS9, Line 209:
Is it be worth preserving these prints in a static display_hob_info() function like in ramstage. […] Comment on patch set #4 to not touch the cbmem related a hob info.
https://review.coreboot.org/#/c/29371/9/src/drivers/intel/fsp1_1/raminit.c@a... PS9, Line 224:
Same comment as above - Perhaps it's worth preserving these in a display_hob_info() function that ge […] display_hob_info() is not only displaying hob only, but checking if graphics hob is available.
https://review.coreboot.org/#/c/29371/9/src/drivers/intel/fsp1_1/ramstage.c File src/drivers/intel/fsp1_1/ramstage.c: https://review.coreboot.org/#/c/29371/9/src/drivers/intel/fsp1_1/ramstage.c@... PS9, Line 63: if (CONFIG(DISPLAY_HOBS))
It feels awkward to call display_hob_info() and check CONFIG(DISPLAY_HOBS) multiple times. […] The hob info in display in both romstage and ramstage. The list is expanded in ramstage.
-- To view, visit https://review.coreboot.org/c/coreboot/+/29371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3776fa37866c7ef3aea090842387660c22bbdd4d Gerrit-Change-Number: 29371 Gerrit-PatchSet: 9 Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com> Gerrit-Reviewer: Huang Jin <huang.jin@intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy@intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com> Gerrit-Reviewer: York Yang <yyang024@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: David Hendricks <david.hendricks@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 05 Jun 2019 11:04:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com> Gerrit-MessageType: comment
participants (1)
-
Frans Hendriks (Code Review)