View Change

3 comments:

• File src/drivers/intel/fsp1_1/raminit.c:

  • Patch Set #9, Line 209:

    Is it be worth preserving these prints in a static display_hob_info() function like in ramstage. […]

    Comment on patch set #4 to not touch the cbmem related a hob info.

  • Patch Set #9, Line 224:

    Same comment as above - Perhaps it's worth preserving these in a display_hob_info() function that ge […]

    display_hob_info() is not only displaying hob only, but checking if graphics hob is available.

• File src/drivers/intel/fsp1_1/ramstage.c:

  • Patch Set #9, Line 63: if (CONFIG(DISPLAY_HOBS))

    It feels awkward to call display_hob_info() and check CONFIG(DISPLAY_HOBS) multiple times. […]

    The hob info in display in both romstage and ramstage.
    The list is expanded in ramstage.

To view, visit change 29371. To unsubscribe, or for help writing mail filters, visit settings.