Change in em100[master]: Drop em100pro_chips.h

List overview All Threads
Download

newer

older

Change in em100[master]: DO NOT...

Change in em100[master]: WIP: Use...

Stefan Reinauer (Code Review)

22 Nov 2019 22 Nov '19

12:34 a.m.

Hello Stefan Reinauer,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/em100/+/37134

to review the following change.

Change subject: Drop em100pro_chips.h ......................................................................

Drop em100pro_chips.h

Signed-off-by: Stefan Reinauer stefan.reinauer@gmail.com Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 --- M Makefile D em100pro_chips.h 2 files changed, 6 insertions(+), 57,328 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/34/37134/1

-- To view, visit https://review.coreboot.org/c/em100/+/37134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 Gerrit-Change-Number: 37134 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@gmail.com Gerrit-MessageType: newchange

Attachments:

attachment.htm (text/html — 2.0 KB)

Show replies by date

Stefan Reinauer (Code Review)

22 Nov 22 Nov

12:38 a.m.

New subject: Change in em100[master]: WIP: Drop em100pro_chips.h

Hello Stefan Reinauer, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/em100/+/37134

to look at the new patch set (#2).

Change subject: WIP: Drop em100pro_chips.h ......................................................................

WIP: Drop em100pro_chips.h

Signed-off-by: Stefan Reinauer stefan.reinauer@gmail.com Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 --- M Makefile D em100pro_chips.h 2 files changed, 6 insertions(+), 57,328 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/34/37134/2

-- To view, visit https://review.coreboot.org/c/em100/+/37134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 Gerrit-Change-Number: 37134 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Stefan Reinauer (Code Review)

23 Nov 23 Nov

12:31 a.m.

New subject: Change in em100[master]: Clean up chip database handling

Hello Stefan Reinauer, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/em100/+/37134

to look at the new patch set (#5).

Change subject: Clean up chip database handling ......................................................................

Clean up chip database handling

- Drop makechips.c utility, it is no longer needed (functionality has been included in chips.c in the em100 utility). - Drop em100pro_chips.h. - Create new build target tarballs which creates the archives now needed by the em100 utility. - Don't produce em100pro_chips.h in makechips.sh anymore.

Signed-off-by: Stefan Reinauer stefan.reinauer@gmail.com Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 --- M Makefile D em100pro_chips.h D makechips.c M makechips.sh 4 files changed, 10 insertions(+), 57,686 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/34/37134/5

-- To view, visit https://review.coreboot.org/c/em100/+/37134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 Gerrit-Change-Number: 37134 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Stefan Reinauer (Code Review)

24 Nov 24 Nov

1:26 p.m.

New subject: Change in em100[master]: Clean up chip database handling

Hello Stefan Reinauer, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/em100/+/37134

to look at the new patch set (#6).

Change subject: Clean up chip database handling ......................................................................

Clean up chip database handling

git pull ssh://review.coreboot.org:29418/em100 refs/changes/34/37134/6

-- To view, visit https://review.coreboot.org/c/em100/+/37134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 Gerrit-Change-Number: 37134 Gerrit-PatchSet: 6 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Stefan Reinauer (Code Review)

5:45 p.m.

New subject: Change in em100[master]: Clean up chip database handling

Hello Stefan Reinauer, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/em100/+/37134

to look at the new patch set (#7).

Change subject: Clean up chip database handling ......................................................................

Clean up chip database handling

git pull ssh://review.coreboot.org:29418/em100 refs/changes/34/37134/7

-- To view, visit https://review.coreboot.org/c/em100/+/37134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 Gerrit-Change-Number: 37134 Gerrit-PatchSet: 7 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Stefan Reinauer (Code Review)

25 Nov 25 Nov

4:05 p.m.

New subject: Change in em100[master]: Clean up chip database handling

Hello Stefan Reinauer, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/em100/+/37134

to look at the new patch set (#8).

Change subject: Clean up chip database handling ......................................................................

Clean up chip database handling

git pull ssh://review.coreboot.org:29418/em100 refs/changes/34/37134/8

-- To view, visit https://review.coreboot.org/c/em100/+/37134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 Gerrit-Change-Number: 37134 Gerrit-PatchSet: 8 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

26 Nov 26 Nov

2:38 a.m.

New subject: Change in em100[master]: Clean up chip database handling

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37134 )

Change subject: Clean up chip database handling ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/em100/+/37134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 Gerrit-Change-Number: 37134 Gerrit-PatchSet: 8 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 26 Nov 2019 10:38:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

27 Nov 27 Nov

3:58 p.m.

New subject: Change in em100[master]: Clean up chip database handling

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37134 )

Change subject: Clean up chip database handling ......................................................................

Clean up chip database handling

Signed-off-by: Stefan Reinauer stefan.reinauer@gmail.com Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 Reviewed-on: https://review.coreboot.org/c/em100/+/37134 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile D em100pro_chips.h D makechips.c M makechips.sh 4 files changed, 22 insertions(+), 57,693 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/em100/+/37134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If116243bf3434bf1c05ff7bc93b6423341d84969 Gerrit-Change-Number: 37134 Gerrit-PatchSet: 10 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1816

days inactive

1821

days old

coreboot-gerrit@coreboot.org

7 comments

2 participants

tags (0)

participants (2)

Angel Pons (Code Review)
Stefan Reinauer (Code Review)