Attention is currently required from: Shelley Chen, Furquan Shaikh, Angel Pons, Kyösti Mälkki.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58331 )
Change subject: [RFC] pci_mmio_cfg: Move guard around pci_s_* functions to x86
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Should we error out if `pci_mmio_cfg. […]
The rough plan is to make the file independent from MMCONF, and adapt it to
allow non-MMCONF but MMIO ops, cf. CB:57861
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaeed6ab43ad61b7c0e14572b12bf4ec06b6a26af
Gerrit-Change-Number: 58331
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 17 Oct 2021 11:47:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment