[S] Change in coreboot[master]: util/cbmem: Update formatting for cbmem -l command - coreboot-gerrit

2 Nov 2022


      Attention is currently required from: Martin L Roth, Jon Murphy, Julius Werner.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68644 )
Change subject: util/cbmem: Update formatting for cbmem -l command
......................................................................
Patch Set 3:
(1 comment)
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/68644/comment/cf79eb30_46a7037f 
PS1, Line 1188: 		name = "UNKNOWN";
...
nit: since the other names are all in all-caps, I'd maybe make this `(unknown)` to make it stand out […]
Sounds good.  Thanks.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68644
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d91d21c6ad418d9fee9880550fb6cb9e41e93f0
Gerrit-Change-Number: 68644
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Wed, 02 Nov 2022 20:59:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment