Attention is currently required from: Benjamin Doron, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50724 )
Change subject: [DNM] soc/intel: Fix SPI write protect and EISS support
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50724/comment/a7ff0bb1_e35bc281
PS3, Line 9: Systems are hanging when chipset enforces SPI write protect.
But that's not the issue here? coreboot can complete booting after enabling WP and setting the EISS […]
I think the hardware locks up even before SMM has a chance to run. I didn't manage to get any logging from coreboot after setting that bit and CONFIG_DEBUG_SMI=y.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice2fb1a049fe24a8e4149a52016a62dadd7a3404
Gerrit-Change-Number: 50724
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 14 Feb 2021 23:00:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment