Change in coreboot[master]: soc/mediatek: move i2c function to common folder - coreboot-gerrit

15 Nov 2021


      Attention is currently required from: Hung-Te Lin, Xi Chen.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59295 )
Change subject: soc/mediatek: move i2c function to common folder
......................................................................
Patch Set 4:
(1 comment)
File src/soc/mediatek/common/i2c.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133240):
https://review.coreboot.org/c/coreboot/+/59295/comment/3d9cd822_26767a7c 
PS4, Line 36: __weak void mtk_i2c_config_timing(struct mt_i2c_regs *regs,
open brace '{' following function definitions go on the next line
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59295
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a702741c763bf9261cea90d0d71c08b6e28c261
Gerrit-Change-Number: 59295
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Xi Chen xixi.chen@mediatek.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 11:25:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment