Change in coreboot[master]: soc/samsung/exynos5250/include/soc/cpu.h: Add missing include
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44737 )
Change subject: soc/samsung/exynos5250/include/soc/cpu.h: Add missing include ......................................................................
soc/samsung/exynos5250/include/soc/cpu.h: Add missing include
Use of 'KiB' needs <commonlib/bsd/helpers.h>
Change-Id: Ia6ba36fd4b0364cc9984523f0add859869068727 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/samsung/exynos5250/include/soc/cpu.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/44737/1
diff --git a/src/soc/samsung/exynos5250/include/soc/cpu.h b/src/soc/samsung/exynos5250/include/soc/cpu.h index aa5a2e8..6d5c18a 100644 --- a/src/soc/samsung/exynos5250/include/soc/cpu.h +++ b/src/soc/samsung/exynos5250/include/soc/cpu.h @@ -3,6 +3,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_CPU_H #define CPU_SAMSUNG_EXYNOS5250_CPU_H
+#include <commonlib/bsd/helpers.h> #include <symbols.h>
/* Base address registers */
HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/44737 )
Change subject: soc/samsung/exynos5250/include/soc/cpu.h: Add missing include ......................................................................
soc/samsung/exynos5250/include/soc/cpu.h: Add missing include
Use of 'KiB' needs <commonlib/bsd/helpers.h>
Change-Id: Ia6ba36fd4b0364cc9984523f0add859869068727 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/samsung/exynos5250/include/soc/cpu.h M src/soc/samsung/exynos5420/include/soc/cpu.h 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/44737/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44737
to look at the new patch set (#3).
Change subject: soc/samsung/exynos{5250,5420}/include/soc/cpu.h: Add missing include ......................................................................
soc/samsung/exynos{5250,5420}/include/soc/cpu.h: Add missing include
Use of 'KiB' needs <commonlib/bsd/helpers.h>
Change-Id: Ia6ba36fd4b0364cc9984523f0add859869068727 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/samsung/exynos5250/include/soc/cpu.h M src/soc/samsung/exynos5420/include/soc/cpu.h 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/44737/3
Attention is currently required from: HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44737 )
Change subject: soc/samsung/exynos{5250,5420}/include/soc/cpu.h: Add missing include ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44737 )
Change subject: soc/samsung/exynos{5250,5420}/include/soc/cpu.h: Add missing include ......................................................................
soc/samsung/exynos{5250,5420}/include/soc/cpu.h: Add missing include
Use of 'KiB' needs <commonlib/bsd/helpers.h>
Change-Id: Ia6ba36fd4b0364cc9984523f0add859869068727 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44737 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/samsung/exynos5250/include/soc/cpu.h M src/soc/samsung/exynos5420/include/soc/cpu.h 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/samsung/exynos5250/include/soc/cpu.h b/src/soc/samsung/exynos5250/include/soc/cpu.h index aa5a2e8..6d5c18a 100644 --- a/src/soc/samsung/exynos5250/include/soc/cpu.h +++ b/src/soc/samsung/exynos5250/include/soc/cpu.h @@ -3,6 +3,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_CPU_H #define CPU_SAMSUNG_EXYNOS5250_CPU_H
+#include <commonlib/bsd/helpers.h> #include <symbols.h>
/* Base address registers */ diff --git a/src/soc/samsung/exynos5420/include/soc/cpu.h b/src/soc/samsung/exynos5420/include/soc/cpu.h index 6a22770..22d42eb 100644 --- a/src/soc/samsung/exynos5420/include/soc/cpu.h +++ b/src/soc/samsung/exynos5420/include/soc/cpu.h @@ -3,6 +3,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_CPU_H #define CPU_SAMSUNG_EXYNOS5420_CPU_H
+#include <commonlib/bsd/helpers.h> #include <symbols.h>
#define EXYNOS5_SRAM_BASE 0x02020000
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)