Attention is currently required from: Jason Glenesk, Marshall Dawson, Angel Pons, Fred Reitberger, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63589 )
Change subject: soc/amd/common/block/cpu/*: Make ucode update more generic ......................................................................
Patch Set 2:
(4 comments)
File src/soc/amd/common/block/cpu/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/63589/comment/ab1a0b94_04f9b763 PS2, Line 79: for So you are dropping the for loop.... We need that for the zork/picasso/dali platforms.
https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
https://review.coreboot.org/c/coreboot/+/63589/comment/e1e92287_76ec8bad PS2, Line 66: static const struct microcode *find_microcode(const struct microcode *ucode, uint16_t equivalent_processor_rev_id) clang-format
https://review.coreboot.org/c/coreboot/+/63589/comment/a9eba397_a1276f67 PS2, Line 83: 23 Do you need the size?
https://review.coreboot.org/c/coreboot/+/63589/comment/bca64f0b_a7d18a0a PS2, Line 86: snprintf I would check the return code.
-
Raul Rangel (Code Review)