Change in coreboot[master]: intel/common/block: Fix issues found by klockwork - coreboot-gerrit

13 Aug 2018


      AndreX Andraos has posted comments on this change. ( https://review.coreboot.org/28060 )
Change subject: intel/common/block: Fix issues found by klockwork
......................................................................
Patch Set 2:
...
Only somewhat related, we've just added scan-build checking for
coreboot as well.
There are a number of issues reported in soc/intel in the yorp
build.
https://www.coreboot.org/scan-build/GOOGLE_YORP-scanbuild.chromeos/
Martin, What tool are you using for this code scan - we're not getting these "soc issues" flagged, using Klocwork Static Code Analysis tool? 
We are getting different "warnings" in chip.c and gspi.c files.
-- 
To view, visit https://review.coreboot.org/28060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51
Gerrit-Change-Number: 28060
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao john.zhao@intel.com
Gerrit-Reviewer: John Zhao john.zhao@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: AndreX Andraos andrex.andraos@intel.com
Gerrit-CC: Martin Roth martinroth@google.com
Gerrit-Comment-Date: Mon, 13 Aug 2018 19:23:18 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No