Nico Huber has posted comments on this change. ( https://review.coreboot.org/29451 )
Change subject: util/abuild: Use absolute paths for (failed|passed)_boards ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/29451/4/util/abuild/abuild File util/abuild/abuild:
https://review.coreboot.org/#/c/29451/4/util/abuild/abuild@22 PS4, Line 22: TOP
any reason why you couldn't just derive the full paths from $TOP?
Don't know what $TOP is used for at all. The original problem, {failed,passed}_boards, is relative to $TARGET so that can't work.
(now that I looked, half of the script seems to use $TOP as root of the coreboot tree, the other half $ROOT and assumes abuild might be called from somewhere else)
Maybe it could be used for some paths that I normalized to use abspath(). Idk, for somebody who didn't wrote this script, it's hard to grasp in which directory it is at which point. Some of the calls to `pwd` on the LHS might be unnecessary, who knows?
-
Nico Huber (Code Review)