Change in coreboot[master]: mb/google/hatch/variants/helios: Update GPIO table for proto stage
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33826 )
Change subject: mb/google/hatch/variants/helios: Update GPIO table for proto stage ......................................................................
Patch Set 6:
(1 comment)
Patch Set 3:
(4 comments)
Line 101: Shouldn't this be done as part of ACPI to ensure timing requirements are met?
This pin is reserved for Touchscreen I2C SDA on/off control. It will not join power on/off sequence by current design . We can set it to low for saving power .
https://review.coreboot.org/c/coreboot/+/33826/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/gpio.c:
https://review.coreboot.org/c/coreboot/+/33826/3/src/mainboard/google/hatch/... PS3, Line 101: 1
Shouldn't this be done as part of ACPI to ensure timing requirements are met?
This pin is reserved for Touchscreen I2C SDA on/off control. It will not join power on/off sequence by current design . We can set it to low for saving power .
-
Ken Lu (Code Review)