Patch Set 3:

(4 comments)

Line 101:
Shouldn't this be done as part of ACPI to ensure timing requirements are met?

This pin is reserved for Touchscreen I2C SDA on/off control. It will not join
power on/off sequence by current design . We can set it to low for saving power .

View Change

1 comment:

To view, visit change 33826. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I257a90a97e11651cdf5f85ca743e530ef5e61e56
Gerrit-Change-Number: 33826
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Chu <frank_chu@pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu@pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen@google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kane Chen <kane_chen@pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu@pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 09 Jul 2019 11:10:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Gerrit-MessageType: comment