Attention is currently required from: Martin L Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75109 )
Change subject: payloads depthcharge: Add additional depthcharge files ......................................................................
Patch Set 1:
(3 comments)
File payloads/external/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/75109/comment/e31c3ea4_9ff0d795 PS1, Line 24: $(call add-cbfs-file-simple, $(notdir $(dpfile)), $(dpfile), raw, lzma ) \ Note that (I think?) this adds the files to both RO and RW CBFS, which may not fit with standard ChromeOS FMAPs. In ChromeOS we usually add these assets only to RO CBFS.
File payloads/external/depthcharge/Kconfig:
https://review.coreboot.org/c/coreboot/+/75109/comment/623ee79e_2e2308fa PS1, Line 58: missing word?
https://review.coreboot.org/c/coreboot/+/75109/comment/5d57905e_a21eadb2 PS1, Line 60: S typo?