Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42778 )
Change subject: Makefile.inc: Simplify fsp submodule check ......................................................................
Makefile.inc: Simplify fsp submodule check
TEST=Building Asrock H110M using FSP from repo updates the submodule.
Change-Id: I25023af88d878353a04db456009249da67e41521 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/42778/1
diff --git a/Makefile.inc b/Makefile.inc index 7f61a5e..bbb6685 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -196,7 +196,7 @@ # until expressly requested and enabled with --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs)) forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/intel-microcode)) -ifeq ($(CONFIG_PLATFORM_USES_FSP1_0)$(CONFIG_PLATFORM_USES_FSP1_1)$(CONFIG_PLATFORM_USES_FSP2_0),y) +ifeq ($(CONFIG_FSP_USE_REPO),y) forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/fsp)) endif ifeq ($(CONFIG_USE_AMD_BLOBS),y)
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42778 )
Change subject: Makefile.inc: Simplify fsp submodule check ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42778 )
Change subject: Makefile.inc: Simplify fsp submodule check ......................................................................
Makefile.inc: Simplify fsp submodule check
TEST=Building Asrock H110M using FSP from repo updates the submodule.
Change-Id: I25023af88d878353a04db456009249da67e41521 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42778 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc index 7f61a5e..bbb6685 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -196,7 +196,7 @@ # until expressly requested and enabled with --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs)) forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/intel-microcode)) -ifeq ($(CONFIG_PLATFORM_USES_FSP1_0)$(CONFIG_PLATFORM_USES_FSP1_1)$(CONFIG_PLATFORM_USES_FSP2_0),y) +ifeq ($(CONFIG_FSP_USE_REPO),y) forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/fsp)) endif ifeq ($(CONFIG_USE_AMD_BLOBS),y)