Attention is currently required from: Carlos López, Joel Bueno, Philipp Hug, ron minnich.
Hello Carlos López, Maximilian Brune, Philipp Hug, build bot (Jenkins), ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85800?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed: Code-Review+1 by Carlos López, Verified+1 by build bot (Jenkins)
Change subject: commonlib/device_tree: fix 64-bit misaligned member access ......................................................................
commonlib/device_tree: fix 64-bit misaligned member access
On RISC-V (or any other platform), pointers to 64-bit values in the device tree (spanning 2 cells) are not guaranteed to be aligned to a 64-bit boundary, which can cause a load access fault on some platforms (see [0]). This is observed with the default Spike device tree. Thus, perform two 32-bit loads instead.
[0] https://lore.kernel.org/qemu-devel/41c1c574-da5c-654a-f993-4b87e089380e@redh...
Change-Id: I567103bcd956b10fab64c5e63018315924ec0d2b Signed-off-by: joel.bueno joel.bueno@openchip.com --- M src/commonlib/device_tree.c 1 file changed, 12 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/85800/4