Attention is currently required from: Paul Menzel, Kane Chen. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63169 )
Change subject: soc/intel/common: Update CSE sub partition update ......................................................................
Patch Set 2:
(3 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/63169/comment/123aa102_6ad9a8d3 PS2, Line 3: #include <arch/cpu.h>
Unrelated.
Ack
https://review.coreboot.org/c/coreboot/+/63169/comment/76e6c2da_038b7096 PS2, Line 786: uint32_t size; : uint32_t start_offset; : uint32_t end_offset;
Why not `unsigned int`, `size_t` or `off_t`?
Why not uint32_t? Any reason?
https://review.coreboot.org/c/coreboot/+/63169/comment/b4b67e14_06152aca PS2, Line 804: region_name, (uint32_t)start_offset, (uint32_t)size);
Why are these casts needed?
casts are not needed here.
-
Sridhar Siricilla (Code Review)