Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46842 )
Change subject: soc/intel/jasperlake: Correct sequence for gpio pad group ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46842/2/src/soc/intel/jasperlake/gp... File src/soc/intel/jasperlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/46842/2/src/soc/intel/jasperlake/gp... PS2, Line 50: INTEL_GPP(GPP_H0, GPIO_RSVD_12, GPIO_RSVD_13), I am still not sure how moving the reserved GPIOs help here. The GPIO Pad number defined in gpio_soc_defs.h has not changed. Hence the pad offset within the community or group is not going to change.
Going through gpio_group_index function, it is just going to return the index to the gpio group within the community. This change will just return a different index to the same group. The pad offset within the group or the ACPI pad base will remain the same.
-
Karthik Ramasubramanian (Code Review)