Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Andrey Petrov, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55292 )
Change subject: soc/intel/alderlake: Make use of is_devfn_enabled() function ......................................................................
Patch Set 4: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55292/comment/a4bbc7c6_ebe5b978 PS4, Line 15: built nit: build
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55292/comment/124a4ddd_03f0a9ae PS4, Line 186: dev->enabled = 0; This also disabled the device in the devicetree
https://review.coreboot.org/c/coreboot/+/55292/comment/23643c33_0cb8454a PS4, Line 247: nit: Drop blank line?
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55292/comment/da9455df_3c9e1a15 PS4, Line 72: if (!CONFIG(SOC_INTEL_DISABLE_IGD) && is_devfn_enabled(SA_DEVFN_IGD)) : m_cfg->InternalGfx = 1; : else : m_cfg->InternalGfx = 0; Should fit in one line:
m_cfg->InternalGfx = !CONFIG(SOC_INTEL_DISABLE_IGD) && is_devfn_enabled(SA_DEVFN_IGD);
https://review.coreboot.org/c/coreboot/+/55292/comment/ea8d4f41_cfad4421 PS4, Line 183: nit: Drop blank line?
https://review.coreboot.org/c/coreboot/+/55292/comment/4eba75ed_cbc4a9a5 PS4, Line 186: : m_cfg->TcssItbtPcie0En = is_devfn_enabled(SA_DEVFN_TBT0); : : m_cfg->TcssItbtPcie1En = is_devfn_enabled(SA_DEVFN_TBT1); : : m_cfg->TcssItbtPcie2En = is_devfn_enabled(SA_DEVFN_TBT2); : : m_cfg->TcssItbtPcie3En = is_devfn_enabled(SA_DEVFN_TBT3); nit: Drop blank lines in between?