Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39997 )
Change subject: mb/google/rambi: Disable console output by defualt ......................................................................
mb/google/rambi: Disable console output by defualt
Disable SoC serial output by default, since no production devices have this exposed, but leave it as a user option so it can be selected as needed (eg, for use with a Google debug servo).
Same change as made for google/cyan in CB:39872
Change-Id: Id6b2c28658aca03d8c5042d719a0f6f504c29288 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/rambi/Kconfig 1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/39997/1
diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index d820875..62b0229 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -4,7 +4,6 @@ select SOC_INTEL_BAYTRAIL select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC - select ENABLE_BUILTIN_COM1 select BOARD_ROMSIZE_KB_8192 select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE @@ -76,4 +75,10 @@ string default "GOOGLE"
+config CONSOLE_SERIAL + default n + +config ENABLE_BUILTIN_COM1 + default y if CONSOLE_SERIAL + endif # BOARD_GOOGLE_BASEBOARD_RAMBI
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39997 )
Change subject: mb/google/rambi: Disable console output by defualt ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39997/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39997/1//COMMIT_MSG@7 PS1, Line 7: defualt default
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39997 )
Change subject: mb/google/rambi: Disable console output by defualt ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39997/1/src/mainboard/google/rambi/... File src/mainboard/google/rambi/Kconfig:
https://review.coreboot.org/c/coreboot/+/39997/1/src/mainboard/google/rambi/... PS1, Line 81: config ENABLE_BUILTIN_COM1 Or rather:
select ENABLE_BUILTIN_COM1 if CONSOLE_SERIAL
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39997
to look at the new patch set (#2).
Change subject: mb/google/rambi: Disable console output by default ......................................................................
mb/google/rambi: Disable console output by default
Disable SoC serial output by default, since no production devices have this exposed, but leave it as a user option so it can be selected as needed (eg, for use with a Google debug servo).
Same change as made for google/cyan in CB:39872
Change-Id: Id6b2c28658aca03d8c5042d719a0f6f504c29288 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/rambi/Kconfig 1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/39997/2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39997 )
Change subject: mb/google/rambi: Disable console output by default ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39997/1/src/mainboard/google/rambi/... File src/mainboard/google/rambi/Kconfig:
https://review.coreboot.org/c/coreboot/+/39997/1/src/mainboard/google/rambi/... PS1, Line 81: config ENABLE_BUILTIN_COM1
Or rather: […]
the built-in COM1 is actually for the SoC, and console serial would likely be via the EC/servo, so there's not a perfectly causal relationship
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39997
to look at the new patch set (#3).
Change subject: mb/google/rambi: Disable console output by default ......................................................................
mb/google/rambi: Disable console output by default
Disable SoC serial output by default, since no production devices have this exposed, but leave it as a user option so it can be selected as needed (eg, for use with a Google debug servo).
Same change as made for google/cyan in CB:39872
Change-Id: Id6b2c28658aca03d8c5042d719a0f6f504c29288 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/rambi/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/39997/3
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39997 )
Change subject: mb/google/rambi: Disable console output by default ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39997/1/src/mainboard/google/rambi/... File src/mainboard/google/rambi/Kconfig:
https://review.coreboot.org/c/coreboot/+/39997/1/src/mainboard/google/rambi/... PS1, Line 81: config ENABLE_BUILTIN_COM1
the built-in COM1 is actually for the SoC, and console serial would likely be via the EC/servo, so t […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39997 )
Change subject: mb/google/rambi: Disable console output by default ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39997/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39997/1//COMMIT_MSG@7 PS1, Line 7: defualt
default
Done
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39997 )
Change subject: mb/google/rambi: Disable console output by default ......................................................................
mb/google/rambi: Disable console output by default
Disable SoC serial output by default, since no production devices have this exposed, but leave it as a user option so it can be selected as needed (eg, for use with a Google debug servo).
Same change as made for google/cyan in CB:39872
Change-Id: Id6b2c28658aca03d8c5042d719a0f6f504c29288 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39997 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/rambi/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index d820875..bc4aa6e 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -4,7 +4,7 @@ select SOC_INTEL_BAYTRAIL select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC - select ENABLE_BUILTIN_COM1 + select ENABLE_BUILTIN_COM1 if CONSOLE_SERIAL select BOARD_ROMSIZE_KB_8192 select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE @@ -76,4 +76,7 @@ string default "GOOGLE"
+config CONSOLE_SERIAL + default n + endif # BOARD_GOOGLE_BASEBOARD_RAMBI
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)