Change in coreboot[master]: mb/google/hatch/var/kindred: Add ELAN touchscreen support

List overview All Threads
Download

newer

older

Change in coreboot[4.11_branch]:...

Change in coreboot[master]: cr50...

David Wu (Code Review)

26 Nov 2019 26 Nov '19

12:24 p.m.

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37236 )

Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support ......................................................................

mb/google/hatch/var/kindred: Add ELAN touchscreen support

Add ELAN EKTH6918 USI touchsreen support.

BUG=b:131205495 TEST=FW_NAME=kindred emerge-hatch coreboot chromeos-bootimage and check touchscreen work.

Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 16 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37236/1

diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index 9d33fa9..f9c7f68 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -145,6 +145,22 @@ register "has_power_resource" = "1" device i2c 39 on end end + chip drivers/i2c/hid + register "generic.hid" = ""ELAN2513"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "20" + register "generic.reset_off_delay_ms" = "2" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" + register "generic.enable_delay_ms" = "10" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C4)" + register "generic.stop_delay_ms" = "130" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 10 on end + end chip drivers/generic/gpio_keys register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)"

Attachments:

attachment.htm (text/html — 4.4 KB)

Show replies by date

David Wu (Code Review)

26 Nov 26 Nov

1:44 p.m.

Hello Paul Fagerburg, Tim Wawrzynczak, Philip Chen, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37236

to look at the new patch set (#2).

Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support ......................................................................

mb/google/hatch/var/kindred: Add ELAN touchscreen support

Add ELAN EKTH6918 USI touchsreen support.

BUG=b:131205495 b:127996093 TEST=FW_NAME=kindred emerge-hatch coreboot chromeos-bootimage and check touchscreen work.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37236/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

5:25 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37236 )

Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37236/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/37236/2/src/mainboard/google/hatch/... PS2, Line 159: 130 Where did this number come from? I believe this is connected to the Report_En signal, and requires 300 ms after RESETB goes high?

David Wu (Code Review)

27 Nov 27 Nov

3:33 a.m.

Hello Paul Fagerburg, Tim Wawrzynczak, Philip Chen, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37236

to look at the new patch set (#3).

Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support ......................................................................

mb/google/hatch/var/kindred: Add ELAN touchscreen support

Add ELAN EKTH6918 USI touchsreen support.

BUG=b:131205495 b:127996093 TEST=FW_NAME=kindred emerge-hatch coreboot chromeos-bootimage and check touchscreen work.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37236/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

David Wu (Code Review)

3:34 a.m.

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37236 )

Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/37236/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/37236/2/src/mainboard/google/hatch/... PS2, Line 159: 130

...

Where did this number come from? I believe this is connected to the Report_En signal, and requires […]

Thanks for reminder, it come from dratini. https://review.coreboot.org/c/coreboot/+/36125/3/src/mainboard/google/hatch/... I have updated stop delay to 300ms.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 27 Nov 2019 02:34:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

David Wu (Code Review)

3:35 a.m.

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37236 )

Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37236/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/37236/2/src/mainboard/google/hatch/... PS2, Line 159: 130

...

Thanks for reminder, it come from dratini. https://review.coreboot. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 27 Nov 2019 02:35:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: David Wu david_wu@quanta.corp-partner.google.com Gerrit-MessageType: comment

Shelley Chen (Code Review)

6:17 a.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37236 )

Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 27 Nov 2019 05:17:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

David Wu (Code Review)

10:47 a.m.

Hello Paul Fagerburg, Tim Wawrzynczak, Philip Chen, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37236

to look at the new patch set (#4).

Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support ......................................................................

mb/google/hatch/var/kindred: Add ELAN touchscreen support

Add ELAN EKTH6918 USI touchsreen support.

BUG=b:131205495 b:127996093 TEST=FW_NAME=kindred emerge-hatch coreboot chromeos-bootimage and check touchscreen work.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37236/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/37236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

David Wu (Code Review)

10:48 a.m.

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37236 )

Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support ......................................................................

Patch Set 4: Code-Review+1

Update HID to ELAN9004, please refer to https://partnerissuetracker.corp.google.com/issues/131205495#comment4 page 3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 27 Nov 2019 09:48:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

6:48 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37236 )

Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 Nov 2019 17:48:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

7:55 p.m.

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37236 )

Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support ......................................................................

mb/google/hatch/var/kindred: Add ELAN touchscreen support

Add ELAN EKTH6918 USI touchsreen support.

BUG=b:131205495 b:127996093 TEST=FW_NAME=kindred emerge-hatch coreboot chromeos-bootimage and check touchscreen work.

Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37236 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 16 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified David Wu: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index 9d33fa9..1122609 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -145,6 +145,22 @@ register "has_power_resource" = "1" device i2c 39 on end end + chip drivers/i2c/hid + register "generic.hid" = ""ELAN9004"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "20" + register "generic.reset_off_delay_ms" = "2" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" + register "generic.enable_delay_ms" = "10" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C4)" + register "generic.stop_delay_ms" = "300" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 10 on end + end chip drivers/generic/gpio_keys register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)"

-- To view, visit https://review.coreboot.org/c/coreboot/+/37236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 5 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1816

days inactive

1817

days old

coreboot-gerrit@coreboot.org

10 comments

4 participants

tags (0)

participants (4)

David Wu (Code Review)
Furquan Shaikh (Code Review)
Shelley Chen (Code Review)
Tim Wawrzynczak (Code Review)