Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46588 )
Change subject: cpu/intel/common: rework code previously moved to common cpu code
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46588/4/src/include/cpu/x86/msr.h
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/46588/4/src/include/cpu/x86/msr.h@4...
PS4, Line 48: #define CPUID_6_ECX_EPB (1 << 3)
It's not a bit in IA32_ENERGY_PERF_BIOS, is it? `msr.h` is the wrong file
for cpuid bits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7615fc26625c44931577216ea42f0a733b99e131
Gerrit-Change-Number: 46588
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Oct 2020 10:22:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment