Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29204 )
Change subject: ec/lenovo/h8: Add function to query sense state ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/29204/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29204/2//COMMIT_MSG@9 PS2, Line 9: Wait for the EC to fully boot before jumping to payload. : The probed registers reads as zero until the EC is ready. : Add a new timestamp for debugging purposes.
Please use bullet points when you want a list, a paragraph […]
Done
https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/h8.c File src/ec/lenovo/h8/h8.c:
https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/h8.c@321 PS2, Line 321: h8_final
Even an inb() sends something (a read request). Which triggers an […]
Added mdelay(1)
https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/h8.c@323 PS2, Line 323: int timeout = 3 * 1000;
use a `stopwatch` instead?
Done
https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/h8.c@335 PS2, Line 335: printk(BIOS_ERR, "H8: Failed waiting for sense ready\n");
Somehow ambiguous. maybe "Timed out ..." or "Not ready after ... […]
Removed
-
Patrick Rudolph (Code Review)