Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix acpi path for gpio. ......................................................................
soc/intel/tigerlake: Fix acpi path for gpio.
In Tigerlake kernel driver list each gpio community as separate gpio devices. Coreboot have the similar changes in ASL file to keep in sync with kernel. Acpigen reads the gpio communities and the drivers populates the SSDT with proper values. Here we fix the acpi path names in coreboot gpio with to be in sync with the separte GPIO communities.
BRANCH=none TEST=From the devicetree for any device when we use driver/usb/acpi verify that in the generates SSDT the path for gpio is populated properly.
Change-Id: Ib03f6b26bafc304e531f2eaeeb0455b8333f1e44 Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/soc/intel/tigerlake/gpio_tgl.c 1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/39344/1
diff --git a/src/soc/intel/tigerlake/gpio_tgl.c b/src/soc/intel/tigerlake/gpio_tgl.c index 54ed5d3..c31f3e3 100644 --- a/src/soc/intel/tigerlake/gpio_tgl.c +++ b/src/soc/intel/tigerlake/gpio_tgl.c @@ -87,7 +87,7 @@ .gpi_smi_en_reg_0 = GPI_SMI_EN_0, .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPP_BTA", - .acpi_path = "\_SB.PCI0.GPIO", + .acpi_path = "\_SB.PCI0.GCM0", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), .groups = tgl_community0_groups, @@ -106,7 +106,7 @@ .gpi_smi_en_reg_0 = GPI_SMI_EN_0, .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPP_SDHU", - .acpi_path = "\_SB.PCI0.GPIO", + .acpi_path = "\_SB.PCI0.GCM1", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), .groups = tgl_community1_groups, @@ -125,6 +125,7 @@ .gpi_smi_en_reg_0 = GPI_SMI_EN_0, .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPD", + /* No GCM2 device and group2 is not visible to kernel */ .acpi_path = "\_SB.PCI0.GPIO", .reset_map = rst_map_com2, .num_reset_vals = ARRAY_SIZE(rst_map_com2), @@ -144,7 +145,7 @@ .gpi_smi_en_reg_0 = GPI_SMI_EN_0, .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPP_FCE", - .acpi_path = "\_SB.PCI0.GPIO", + .acpi_path = "\_SB.PCI0.GCM4", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), .groups = tgl_community4_groups, @@ -163,7 +164,7 @@ .gpi_smi_en_reg_0 = GPI_SMI_EN_0, .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPP_CPU_VBPIO", - .acpi_path = "\_SB.PCI0.GPIO", + .acpi_path = "\_SB.PCI0.GCM5", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), .groups = tgl_community5_groups,
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39344
to look at the new patch set (#2).
Change subject: soc/intel/tigerlake: Fix acpi path for gpio. ......................................................................
soc/intel/tigerlake: Fix acpi path for gpio.
In Tigerlake kernel driver list each gpio community as separate gpio devices. coreboot have the similar changes in ASL file to keep in sync with kernel. Acpigen reads the gpio communities and the drivers populates the SSDT with proper values. Here we fix the acpi path names in coreboot gpio with to be in sync with the separte GPIO communities.
BRANCH=none TEST=From the devicetree for any device when we use driver/usb/acpi verify that in the generates SSDT the path for gpio is populated properly.
Change-Id: Ib03f6b26bafc304e531f2eaeeb0455b8333f1e44 Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/soc/intel/tigerlake/gpio_tgl.c 1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/39344/2
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39344
to look at the new patch set (#3).
Change subject: soc/intel/tigerlake: Fix acpi path for gpio. ......................................................................
soc/intel/tigerlake: Fix acpi path for gpio.
In Tigerlake kernel driver list each gpio community as separate gpio devices and coreboot have the similar changes in ASL file to keep in sync with kernel. Acpigen reads the gpio communities and the drivers populates the SSDT with proper values. Here we fix the acpi path names in coreboot gpio with to be in sync with the separte GPIO communities.
BRANCH=none TEST=From the devicetree for any device when we use driver/usb/acpi verify that in the generates SSDT the path for gpio is populated properly.
Change-Id: Ib03f6b26bafc304e531f2eaeeb0455b8333f1e44 Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/soc/intel/tigerlake/gpio_tgl.c 1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/39344/3
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix acpi path for gpio. ......................................................................
Patch Set 3:
(9 comments)
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@7 PS3, Line 7: soc/intel/tigerlake: Fix acpi path for gpio. Please remove the dot at the end.
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: Tigerlake Tiger Lake
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: kernel What version?
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: list lists
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@10 PS3, Line 10: have has
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@14 PS3, Line 14: separte separate
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@14 PS3, Line 14: with Remove?
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@18 PS3, Line 18: generates generated
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@19 PS3, Line 19: for gpio is populated properly. Please re-flow for 75 characters.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix acpi path for gpio. ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: In s/In/The
(substitute `In` with `The`)
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@10 PS3, Line 10: the drop `the`
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, caveh jalali, Nick Vaccaro, Srinidhi N Kaushik, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39344
to look at the new patch set (#4).
Change subject: isoc/intel/tigerlake: Fix acpi path for gpio ......................................................................
isoc/intel/tigerlake: Fix acpi path for gpio
The Tiger lake 5.4 kernel pinctrl driver lists each gpio community as separate gpio devices and coreboot has similar changes in ASL file to keep in sync with kernel. Acpigen reads the gpio communities and the drivers populates the SSDT with proper values. Here we fix the acpi path names in coreboot gpio to be in sync with the gpio driver names.
BRANCH=none TEST=Verify when we use driver/usb/acpi in devicetree for any device the generated SSDT have the path for gpio populated properly.
Change-Id: Ib03f6b26bafc304e531f2eaeeb0455b8333f1e44 Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/soc/intel/tigerlake/gpio_tgl.c 1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/39344/4
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: isoc/intel/tigerlake: Fix acpi path for gpio ......................................................................
Patch Set 4:
(10 comments)
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@7 PS3, Line 7: soc/intel/tigerlake: Fix acpi path for gpio.
Please remove the dot at the end.
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: In
s/In/The […]
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: kernel
What version?
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: list
lists
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@9 PS3, Line 9: Tigerlake
Tiger Lake
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@10 PS3, Line 10: the
drop `the`
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@10 PS3, Line 10: have
has
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@14 PS3, Line 14: with
Remove?
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@14 PS3, Line 14: separte
separate
Ack
https://review.coreboot.org/c/coreboot/+/39344/3//COMMIT_MSG@18 PS3, Line 18: generates
generated
Ack
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: isoc/intel/tigerlake: Fix acpi path for gpio ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@7 PS4, Line 7: isoc Oops, looks like a spurious `i` got added.
Was it because of vim? 😄
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: isoc/intel/tigerlake: Fix acpi path for gpio ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@9 PS4, Line 9: gpio Uppercase: GPIO (all of them)
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@9 PS4, Line 9: lake Capitalize: `Lake`
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@13 PS4, Line 13: acpi Uppercase: ACPI
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, caveh jalali, Angel Pons, Nick Vaccaro, Srinidhi N Kaushik, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39344
to look at the new patch set (#5).
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
soc/intel/tigerlake: Fix ACPI path for GPIO
The Tiger Lake 5.4 kernel pinctrl driver lists each GPIO community as separate GPIO devices and coreboot has similar changes in ASL file to keep in sync with kernel. Acpigen reads the GPIO communities and the drivers populates the SSDT with proper values. Here we fix the ACPI path names in coreboot GPIO to be in sync with the GPIO driver names.
BRANCH=none TEST=Verify when we use driver/usb/acpi in devicetree for any device the generated SSDT have the path for GPIO populated properly.
Change-Id: Ib03f6b26bafc304e531f2eaeeb0455b8333f1e44 Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/soc/intel/tigerlake/gpio_tgl.c 1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/39344/5
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(4 comments)
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@7 PS4, Line 7: isoc
Oops, looks like a spurious `i` got added. […]
ya. Side effect of getting too used to vim.will remove.
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@9 PS4, Line 9: lake
Capitalize: `Lake`
Ack
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@9 PS4, Line 9: gpio
Uppercase: GPIO (all of them)
Ack
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@13 PS4, Line 13: acpi
Uppercase: ACPI
Ack
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39344/4//COMMIT_MSG@7 PS4, Line 7: isoc
ya. Side effect of getting too used to vim.will remove.
Done 😄
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel Then, why have an incorrect ACPI path? Shouldn't it be left as NULL or ""? I actually think adding NULL and ensuring there is a check in soc/intel/common/block/gpio which catches if acpi path returned is NULL would be helpful.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5: Code-Review+1
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
Then, why have an incorrect ACPI path? Shouldn't it be left as NULL or ""? I actually think adding N […]
Got it. Will implement that.So when we return NULL from here how would you like to handle in gpio_acpi_path as in acpigen_emit_string it will call acpigen_emit_string which adds NULL at the end.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
Got it. Will implement that. […]
What is issue if CB returns correct ACPI path as "\_SB.PCI0.GCM2" and also make same change in gpio.asl for group2. Will it cause Kernel issue? And group2 is not visable means kernel will not control group2 gpio either kernel driver or ACPI.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
What is issue if CB returns correct ACPI path as "\_SB.PCI0.GCM2" and also make same change in […]
You will have to check kernel driver to see what its behavior is. I believe there will be a mismatch of communities. But it would be good to check the kernel driver implementation to understand the behavior.
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
You will have to check kernel driver to see what its behavior is. […]
Ack
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
Ack
I will check the kernel driver.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5: Code-Review+1
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
I will check the kernel driver.
Few things i observed. As suggested by Will i tried with adding GCM2 device in asl file and returning the GCM2 from the acpi path. Asl gets populated properly as expected but as kernel does not know about that device it simply does not do anything when the match is not found.I am adding some more logs in kernel to get the exact failure. But one thing : 1. If we do not have GCM2 then in pinctrl node in sysfs the devices are INT34C5:00, INT34C5:01, INT34C5:02, INT34C5:03 but if we have GCM2 then its INT34C5:00, INT34C5:01, INT34C5:03 INT34C5:04 even though the UID in asl file matches those in kernel driver. So seems like in order to have kernel list nodes properly we need to have dummy GCM2, GCM3 in coreboot. But i m not sure if we would have any problem without those. Even if kernel list those devices as 0,1,2,3 it would still work.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
Asl gets populated properly as expected but as kernel does not know about that device it simply does not do anything when the match is not found.
That sounds okay. So, basically skips it based on UID matching.
I am adding some more logs in kernel to get the exact failure.
Why do you think there is a failure?
So seems like in order to have kernel list nodes properly we need to have dummy GCM2, GCM3 in coreboot.
GCM2 exists. So, you can add real information about community 2. But I am not sure about GCM3. I don't see any information about it being available.
Even if kernel list those devices as 0,1,2,3 it would still work.
As long as the UID matches correctly and you ensure that the GPIO names used in coreboot match the kernel enumeration, things should be okay.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
Asl gets populated properly as expected but as kernel does not know about that device it simply do […]
Can we quickly verify with GCM2, GCM3 in Coreboot and check if SSDT provide GPIO in GCM4, GCM5 to see kernel can find the GPIO? if Kernel can find GPIO, I think we're ok. And the gpio.c and gpio.asl should be matched. I mean if we add GCM2 and GCM3 in gpio.c gpio.asl should have both.
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
Can we quickly verify with GCM2, GCM3 in Coreboot and check if SSDT provide GPIO in GCM4, GCM5 to se […]
I verified with trying to access gpio's which is in community 4 and so in GCM4 device. But kernel fails to access that.if the gpio is in device 0,1 then its fine. I just chnaged the audio sdmode gpio to be one in community 4 and kernel fails. Even adding dummy methods GCM2,GCM3 fails. Debugging kernel now where its failing.
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
I verified with trying to access gpio's which is in community 4 and so in GCM4 device. […]
Right now my guess about the fialure is the numbering og he gpio's. In kernel for every community the numbering starts from 0 and for us in coreboot its continous. SO the gpio's in group 4 actually is out of range for kernel. I will verify if this is the case and can be fixed from coreboot side.
Shaunak Saha has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Abandoned
kernel driver is going to back to old scehema.so we dont need this patch anymore.
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Nick Vaccaro (Code Review)
-
Paul Menzel (Code Review)
-
Shaunak Saha (Code Review)
-
Wonkyu Kim (Code Review)