HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39410 )
Change subject: commonlib/cbfs.c: Remove unused macro ......................................................................
commonlib/cbfs.c: Remove unused macro
Change-Id: I330de4357fa48ee3d76a97a682b389ef42e7a135 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/commonlib/cbfs.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/39410/1
diff --git a/src/commonlib/cbfs.c b/src/commonlib/cbfs.c index be0de9f..b03a3dc 100644 --- a/src/commonlib/cbfs.c +++ b/src/commonlib/cbfs.c @@ -18,9 +18,6 @@ #include <string.h> #include <vb2_sha.h>
-#if !defined(ERROR) -#define ERROR(x...) printk(BIOS_ERR, "CBFS: " x) -#endif #if !defined(LOG) #define LOG(x...) printk(BIOS_INFO, "CBFS: " x) #endif
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39410 )
Change subject: commonlib/cbfs.c: Remove unused macro ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39410 )
Change subject: commonlib/cbfs.c: Remove unused macro ......................................................................
commonlib/cbfs.c: Remove unused macro
Change-Id: I330de4357fa48ee3d76a97a682b389ef42e7a135 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/39410 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/commonlib/cbfs.c 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/commonlib/cbfs.c b/src/commonlib/cbfs.c index be0de9f..b03a3dc 100644 --- a/src/commonlib/cbfs.c +++ b/src/commonlib/cbfs.c @@ -18,9 +18,6 @@ #include <string.h> #include <vb2_sha.h>
-#if !defined(ERROR) -#define ERROR(x...) printk(BIOS_ERR, "CBFS: " x) -#endif #if !defined(LOG) #define LOG(x...) printk(BIOS_INFO, "CBFS: " x) #endif
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)