HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46009 )
Change subject: mb/kontron/986lcd-m: Convert *.asl to ASL 2.0 syntax ......................................................................
mb/kontron/986lcd-m: Convert *.asl to ASL 2.0 syntax
Change-Id: I2ef51c0348e76cb34e118ed207de88cc753f8fe0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/kontron/986lcd-m/acpi/platform.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/46009/1
diff --git a/src/mainboard/kontron/986lcd-m/acpi/platform.asl b/src/mainboard/kontron/986lcd-m/acpi/platform.asl index 30e4d2c..cf73fc1 100644 --- a/src/mainboard/kontron/986lcd-m/acpi/platform.asl +++ b/src/mainboard/kontron/986lcd-m/acpi/platform.asl @@ -20,12 +20,12 @@ // was inserted while a sleep state was active.
// Are we going to S3? - If (LEqual(Arg0, 3)) { + If (Arg0 == 3) { // .. }
// Are we going to S4? - If (LEqual(Arg0, 4)) { + If (Arg0 == 4) { // .. }
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46009 )
Change subject: mb/kontron/986lcd-m: Convert *.asl to ASL 2.0 syntax ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46009 )
Change subject: mb/kontron/986lcd-m: Convert *.asl to ASL 2.0 syntax ......................................................................
mb/kontron/986lcd-m: Convert *.asl to ASL 2.0 syntax
Change-Id: I2ef51c0348e76cb34e118ed207de88cc753f8fe0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46009 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/kontron/986lcd-m/acpi/platform.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/kontron/986lcd-m/acpi/platform.asl b/src/mainboard/kontron/986lcd-m/acpi/platform.asl index 30e4d2c..cf73fc1 100644 --- a/src/mainboard/kontron/986lcd-m/acpi/platform.asl +++ b/src/mainboard/kontron/986lcd-m/acpi/platform.asl @@ -20,12 +20,12 @@ // was inserted while a sleep state was active.
// Are we going to S3? - If (LEqual(Arg0, 3)) { + If (Arg0 == 3) { // .. }
// Are we going to S4? - If (LEqual(Arg0, 4)) { + If (Arg0 == 4) { // .. }
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)