Attention is currently required from: Martin Roth, Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Meera Ravindranath, Usha P, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50955 )
Change subject: soc/intel/common/basecode: Add bootblock common code
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/basecode/include/intelbasecode/bootblock.h:
https://review.coreboot.org/c/coreboot/+/50955/comment/b47d6859_fbc3937c
PS2, Line 18: extern const struct cpuid_entry cpu_table[];
: extern const struct pciid_entry mch_table[];
: extern const struct pciid_entry pch_table[];
: extern const struct pciid_entry igd_table[];
:
: extern const size_t cpu_length;
: extern const size_t mch_length;
: extern const size_t pch_length;
: extern const size_t igd_length;
my personal preference is to use something like […]
hmm, I'm not a fan of externs, but these get-functions introduce much boilerplate code, which isn't nice also
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50955
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d547347ba595edcc3b6253448c8f5060b4fdfff
Gerrit-Change-Number: 50955
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 21 Feb 2021 22:50:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment