mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27360 )
Change subject: sdm845: Add interface between CB & QCLib ......................................................................
Patch Set 35:
Patch Set 35:
After looking at how the whole codebase uses CONFIG_CBFS_PREFIX, this request would make sdm845 code different. In fact to fit in with the codebase, the #define for the name, e.g. pmic or aop should be removed...
Yes, having the string inline is certainly acceptable as long as it's only used once in the code (which should be the case for all here). Feel free to do that if you want, but defining a named constant for it isn't "wrong" either. (But if we do have a constant, I think the CBFS prefix should be part of it.)
PMIC_NAME replaced with "/pmiccfg" DCB_NAME replaced with "/dcb"
Macro replaced with single instance string which agrees with rest of codebase.
-
mturney mturney (Code Review)