Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee, Patrick Rudolph.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62294 )
Change subject: mb, soc: Add the SPD_CACHE_ENABLE
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/romstage.c:
https://review.coreboot.org/c/coreboot/+/62294/comment/33c6c948_7e9c1c94
PS4, Line 25: if (dimms_changed) {
This code: https://review.coreboot. […]
In this code it is guard by CONFIG(SPD_CACHE_ENABLE), but I think it'd better guard by the specific SODIMM config, WDYT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7625a00c865dc268e2a22efd71b34b40c40877b
Gerrit-Change-Number: 62294
Gerrit-PatchSet: 4
Gerrit-Owner: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Tue, 01 Mar 2022 07:35:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment