Attention is currently required from: Angel Pons, Brandon Weeks, Julian Intronati, Paul Menzel.
Felix Held has posted comments on this change by Julian Intronati. ( https://review.coreboot.org/c/coreboot/+/87027?usp=email )
Change subject: mb/cwwk: Add CWWK CW-ADLNTB-1C2L-V3.0 board as an adl variants ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
It is my first coreboot commit ! I'm open to suggestions. […]
Hi Julian, welcome to coreboot development :)
Patchset:
PS2: i'm a bit surprised that the devicetree is identical, but i'd guess that the devices are just very similar. cw-adl-4l-v2.0, which i have started to port, but didn't have to time to finish that one yet, has some devicetree differences compared to cw-adl-4l-v1.0
File src/mainboard/cwwk/adl/Kconfig:
https://review.coreboot.org/c/coreboot/+/87027/comment/98c48853_0968e150?usp... : PS2, Line 15: i think this is missing the following lines here to make the board selection work properly:
``` config BOARD_CWWK_CW_ADL_4L_V1 select BOARD_CWWK_ADL_N_COMMON
config BOARD_CWWK_CW_ADLNTB_1C2L_V3 select BOARD_CWWK_ADL_N_COMMON ```