Attention is currently required from: Justin Frodsham, Raul Rangel, Marshall Dawson, Matt Papageorge.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 )
Change subject: vc/amd/fsp/cezanne: add platform_descriptors.h
......................................................................
Patch Set 11:
(3 comments)
File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/51197/comment/a48e4df3_7a00d17c
PS10, Line 37: SPDC_DISBLED
_DISABLED
Done
https://review.coreboot.org/c/coreboot/+/51197/comment/c5d8c6b1_cdec037b
PS10, Line 155: DDI_UNUSED_PTYPE
DDI_UNUSED_TYPE
Done
File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/51197/comment/fefa4b07_32605075
PS2, Line 108: EDP_TO_LVDS, // eDP-to-LVDS translator chip without AMD SW init
i'm not 100% sure about this and the next 3
this at least matches what is in agesa/fsp
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51197
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474
Gerrit-Change-Number: 51197
Gerrit-PatchSet: 11
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Comment-Date: Thu, 01 Apr 2021 16:55:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment