[L] Change in coreboot[main]: arch/x86/mmu: Port armv8 MMU to x86_64

[Benjamin Doron (Code Review)]

Attention is currently required from: Jérémy Compostella.

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79161?usp=email )

Change subject: arch/x86/mmu: Port armv8 MMU to x86_64
......................................................................

Patch Set 3:

(4 comments)

File src/arch/x86/mmu-ramstage.c:

https://review.coreboot.org/c/coreboot/+/79161/comment/08fd2d32_2bec0d4f :
PS1, Line 13: #include <commonlib/region.h>
> alphabetical order ?

Done

File src/arch/x86/mmu.c:

https://review.coreboot.org/c/coreboot/+/79161/comment/239c047a_7bf0b064 :
PS1, Line 13: #include <commonlib/region.h>
> alphabetical order ?

Done

https://review.coreboot.org/c/coreboot/+/79161/comment/9aedf028_b2cd6f9d :
PS1, Line 350: 		pages += PDPTs; /* PDPT pointing to 1 GiB PLEs */
> the beginning of both branches is identical, can't we take them out of the condition ?

Done

https://review.coreboot.org/c/coreboot/+/79161/comment/310d351f_cb43be13 :
PS1, Line 364: 4 * KiB
> There are a lot of `4 * KiB` in this file, could we create a constant ?

Changed to GRANULE_SIZE, but yes, that actually might be Arm terminology. Either way, we are using a constant, so I'll mark this as done and look into it on your other comment.