Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Tim Crawford.
Subrata Banik has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82731?usp=email )
Change subject: soc/intel/mtl: Set HDA subsystem ID during FSP-M
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82731/comment/99bc2676_3ae56fea?usp... :
PS2, Line 7: Set HDA subsystem ID during FSP-M
Please check fill_fsps_pci_ssid_params(), I believe it solves the same purpose and it is still getting called before FSP-S.
```
/*
* Programming SSID before FSP-S is important because SSID registers of a few PCIE
* devices (e.g. IPU, Crashlog, XHCI, TCSS_XHCI etc.) are locked after FSP-S hence
* provide a custom SSID (same as DID by default) value via UPD.
*/
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82731?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e668747d99b955b0a3946524c5918d328b8e1d3
Gerrit-Change-Number: 82731
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Sat, 01 Jun 2024 07:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No