Change in coreboot[master]: sb/intel/lynxpoint: Comment conflicting use of _ADR and _HID

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

11 Jan 2020 11 Jan '20

2:48 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38351 )

Change subject: sb/intel/lynxpoint: Comment conflicting use of _ADR and _HID ......................................................................

sb/intel/lynxpoint: Comment conflicting use of _ADR and _HID

Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/lynxpoint/acpi/serialio.asl 1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/38351/1

diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl index 9323b91..14af1e0 100644 --- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl +++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl @@ -123,6 +123,7 @@ Device (SDMA) { // Serial IO DMA Controller + // FIXME: Device object requires either a _HID or _ADR, but not both Name (_HID, "INTL9C60") Name (_UID, 1) Name (_ADR, 0x00150000) @@ -160,6 +161,7 @@ Device (I2C0) { // Serial IO I2C0 Controller + // FIXME: Device object requires either a _HID or _ADR, but not both Name (_HID, "INT33C2") Name (_CID, "INT33C2") Name (_UID, 1) @@ -242,6 +244,7 @@ Device (I2C1) { // Serial IO I2C1 Controller + // FIXME: Device object requires either a _HID or _ADR, but not both Name (_HID, "INT33C3") Name (_CID, "INT33C3") Name (_UID, 1) @@ -324,6 +327,7 @@ Device (SPI0) { // Serial IO SPI0 Controller + // FIXME: Device object requires either a _HID or _ADR, but not both Name (_HID, "INT33C0") Name (_CID, "INT33C0") Name (_UID, 1) @@ -362,6 +366,7 @@ Device (SPI1) { // Serial IO SPI1 Controller + // FIXME: Device object requires either a _HID or _ADR, but not both Name (_HID, "INT33C1") Name (_CID, "INT33C1") Name (_UID, 1) @@ -413,6 +418,7 @@ Device (UAR0) { // Serial IO UART0 Controller + // FIXME: Device object requires either a _HID or _ADR, but not both Name (_HID, "INT33C4") Name (_CID, "INT33C4") Name (_UID, 1) @@ -464,6 +470,7 @@ Device (UAR1) { // Serial IO UART1 Controller + // FIXME: Device object requires either a _HID or _ADR, but not both Name (_HID, "INT33C5") Name (_CID, "INT33C5") Name (_UID, 1) @@ -502,6 +509,7 @@ Device (SDIO) { // Serial IO SDIO Controller + // FIXME: Device object requires either a _HID or _ADR, but not both Name (_HID, "INT33C6") Name (_CID, "PNP0D40") Name (_UID, 1)

Attachments:

attachment.htm (text/html — 5.2 KB)

Show replies by date

HAOUAS Elyes (Code Review)

11 Jan 11 Jan

6:55 a.m.

Hello Patrick Rudolph, Matt DeVillier, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38351

to look at the new patch set (#2).

Change subject: sb/intel/lynxpoint: Comment conflicting use of _ADR and _HID ......................................................................

sb/intel/lynxpoint: Comment conflicting use of _ADR and _HID

To be compliant with ACPI specification, we need to solve conflicting use of _ADR and _HID.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/38351/2

HAOUAS Elyes (Code Review)

17 Jan 17 Jan

6:21 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38351 )

Change subject: sb/intel/lynxpoint: Comment conflicting use of _ADR and _HID ......................................................................

Patch Set 3:

ping

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 17 Jan 2020 18:21:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4 Feb 4 Feb

6:28 a.m.

New subject: Change in coreboot[master]: sb/intel/lynxpoint: Don't use_ADR and _HID

Hello Patrick Rudolph, Matt DeVillier, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38351

to look at the new patch set (#5).

Change subject: sb/intel/lynxpoint: Don't use_ADR and _HID ......................................................................

sb/intel/lynxpoint: Don't use_ADR and _HID

To be compliant with ACPI specification, sevice object requires either a _HID or _ADR, but not both.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/38351/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

6:40 a.m.

New subject: Change in coreboot[master]: sb/intel/lynxpoint: Don't use_ADR and _HID

Hello Patrick Rudolph, Matt DeVillier, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38351

to look at the new patch set (#6).

Change subject: sb/intel/lynxpoint: Don't use_ADR and _HID ......................................................................

sb/intel/lynxpoint: Don't use_ADR and _HID

To be compliant with ACPI specification, device object requires either a _HID or _ADR, but not both.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/38351/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

8:06 p.m.

New subject: Change in coreboot[master]: sb/intel/lynxpoint: Don't use_ADR and _HID

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38351 )

Change subject: sb/intel/lynxpoint: Don't use_ADR and _HID ......................................................................

Patch Set 6: Code-Review-1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 04 Feb 2020 20:06:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:35 p.m.

New subject: Change in coreboot[master]: sb/intel/lynxpoint: Don't use_ADR and _HID

HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/38351 )

Change subject: sb/intel/lynxpoint: Don't use_ADR and _HID ......................................................................

Removed Code-Review-1 by HAOUAS Elyes ehaouas@noos.fr

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: deleteVote

HAOUAS Elyes (Code Review)

8 Feb 8 Feb

6 a.m.

New subject: Change in coreboot[master]: sb/intel/lynxpoint: Don't use_ADR and _HID

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38351 )

Change subject: sb/intel/lynxpoint: Don't use_ADR and _HID ......................................................................

Patch Set 7: Code-Review-1

untested

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 08 Feb 2020 06:00:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9 Feb 9 Feb

2:53 p.m.

New subject: Change in coreboot[master]: sb/intel/lynxpoint: Don't use_ADR and _HID

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38351 )

Change subject: sb/intel/lynxpoint: Don't use_ADR and _HID ......................................................................

Abandoned

see 38802

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

HAOUAS Elyes (Code Review)

9:14 p.m.

New subject: Change in coreboot[master]: sb/intel/lynxpoint: Don't use_ADR and _HID

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/38351 )

Change subject: sb/intel/lynxpoint: Don't use_ADR and _HID ......................................................................

Restored

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: restore

HAOUAS Elyes (Code Review)

9:16 p.m.

New subject: Change in coreboot[master]: sb/intel/lynxpoint: Don't use_ADR and _HID

HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/38351 )

Change subject: sb/intel/lynxpoint: Don't use_ADR and _HID ......................................................................

Removed Code-Review-1 by HAOUAS Elyes ehaouas@noos.fr

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: deleteVote

Martin Roth (Code Review)

9:35 p.m.

New subject: Change in coreboot[master]: sb/intel/lynxpoint: Don't use_ADR and _HID

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38351 )

Change subject: sb/intel/lynxpoint: Don't use_ADR and _HID ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 09 Feb 2020 21:35:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

11 Feb 11 Feb

7:46 a.m.

New subject: Change in coreboot[master]: sb/intel/lynxpoint: Don't use_ADR and _HID

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38351 )

Change subject: sb/intel/lynxpoint: Don't use_ADR and _HID ......................................................................

sb/intel/lynxpoint: Don't use_ADR and _HID

To be compliant with ACPI specification, device object requires either a _HID or _ADR, but not both.

Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38351 Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/lynxpoint/acpi/serialio.asl 1 file changed, 0 insertions(+), 8 deletions(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved

diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl index 9323b91..88138a1 100644 --- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl +++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl @@ -125,7 +125,6 @@ // Serial IO DMA Controller Name (_HID, "INTL9C60") Name (_UID, 1) - Name (_ADR, 0x00150000)

// BAR0 is assigned during PCI enumeration and saved into NVS Name (RBUF, ResourceTemplate () @@ -163,7 +162,6 @@ Name (_HID, "INT33C2") Name (_CID, "INT33C2") Name (_UID, 1) - Name (_ADR, 0x00150001)

Name (SSCN, Package () { 432, 507, 30 }) Name (FMCN, Package () { 72, 160, 30 }) @@ -245,7 +243,6 @@ Name (_HID, "INT33C3") Name (_CID, "INT33C3") Name (_UID, 1) - Name (_ADR, 0x00150002)

Name (SSCN, Package () { 432, 507, 30 }) Name (FMCN, Package () { 72, 160, 30 }) @@ -327,7 +324,6 @@ Name (_HID, "INT33C0") Name (_CID, "INT33C0") Name (_UID, 1) - Name (_ADR, 0x00150003)

// BAR0 is assigned during PCI enumeration and saved into NVS Name (RBUF, ResourceTemplate () @@ -365,7 +361,6 @@ Name (_HID, "INT33C1") Name (_CID, "INT33C1") Name (_UID, 1) - Name (_ADR, 0x00150004)

// BAR0 is assigned during PCI enumeration and saved into NVS Name (RBUF, ResourceTemplate () @@ -416,7 +411,6 @@ Name (_HID, "INT33C4") Name (_CID, "INT33C4") Name (_UID, 1) - Name (_ADR, 0x00150005)

// BAR0 is assigned during PCI enumeration and saved into NVS Name (RBUF, ResourceTemplate () @@ -467,7 +461,6 @@ Name (_HID, "INT33C5") Name (_CID, "INT33C5") Name (_UID, 1) - Name (_ADR, 0x00150006)

// BAR0 is assigned during PCI enumeration and saved into NVS Name (RBUF, ResourceTemplate () @@ -505,7 +498,6 @@ Name (_HID, "INT33C6") Name (_CID, "PNP0D40") Name (_UID, 1) - Name (_ADR, 0x00170000)

// BAR0 is assigned during PCI enumeration and saved into NVS Name (RBUF, ResourceTemplate ()

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

8:22 a.m.

New subject: Change in coreboot[master]: sb/intel/lynxpoint: Don't use_ADR and _HID

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38351 )

Change subject: sb/intel/lynxpoint: Don't use_ADR and _HID ......................................................................

Patch Set 9:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/538 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/537 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/536

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/38351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a Gerrit-Change-Number: 38351 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 11 Feb 2020 08:22:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1557

days inactive

1588

days old

coreboot-gerrit@coreboot.org

13 comments

4 participants

tags (0)

participants (4)

9elements QA (Code Review)
HAOUAS Elyes (Code Review)
Martin Roth (Code Review)
Patrick Georgi (Code Review)