HAOUAS Elyes has uploaded this change for review.

View Change

sb/intel/lynxpoint: Comment conflicting use of _ADR and _HID

Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
---
M src/southbridge/intel/lynxpoint/acpi/serialio.asl
1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/38351/1
diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
index 9323b91..14af1e0 100644
--- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl
+++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
@@ -123,6 +123,7 @@
Device (SDMA)
{
// Serial IO DMA Controller
+ // FIXME: Device object requires either a _HID or _ADR, but not both
Name (_HID, "INTL9C60")
Name (_UID, 1)
Name (_ADR, 0x00150000)
@@ -160,6 +161,7 @@
Device (I2C0)
{
// Serial IO I2C0 Controller
+ // FIXME: Device object requires either a _HID or _ADR, but not both
Name (_HID, "INT33C2")
Name (_CID, "INT33C2")
Name (_UID, 1)
@@ -242,6 +244,7 @@
Device (I2C1)
{
// Serial IO I2C1 Controller
+ // FIXME: Device object requires either a _HID or _ADR, but not both
Name (_HID, "INT33C3")
Name (_CID, "INT33C3")
Name (_UID, 1)
@@ -324,6 +327,7 @@
Device (SPI0)
{
// Serial IO SPI0 Controller
+ // FIXME: Device object requires either a _HID or _ADR, but not both
Name (_HID, "INT33C0")
Name (_CID, "INT33C0")
Name (_UID, 1)
@@ -362,6 +366,7 @@
Device (SPI1)
{
// Serial IO SPI1 Controller
+ // FIXME: Device object requires either a _HID or _ADR, but not both
Name (_HID, "INT33C1")
Name (_CID, "INT33C1")
Name (_UID, 1)
@@ -413,6 +418,7 @@
Device (UAR0)
{
// Serial IO UART0 Controller
+ // FIXME: Device object requires either a _HID or _ADR, but not both
Name (_HID, "INT33C4")
Name (_CID, "INT33C4")
Name (_UID, 1)
@@ -464,6 +470,7 @@
Device (UAR1)
{
// Serial IO UART1 Controller
+ // FIXME: Device object requires either a _HID or _ADR, but not both
Name (_HID, "INT33C5")
Name (_CID, "INT33C5")
Name (_UID, 1)
@@ -502,6 +509,7 @@
Device (SDIO)
{
// Serial IO SDIO Controller
+ // FIXME: Device object requires either a _HID or _ADR, but not both
Name (_HID, "INT33C6")
Name (_CID, "PNP0D40")
Name (_UID, 1)

To view, visit change 38351. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45cf2b8d455aa4d288de1ac53cf9ae801f758a9a
Gerrit-Change-Number: 38351
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-MessageType: newchange