[L] Change in coreboot[main]: soc/mediatek/mt8196: Add srclken_rc drivers

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85842?usp=email )

Change subject: soc/mediatek/mt8196: Add srclken_rc drivers
......................................................................

Patch Set 5:

(2 comments)

File src/soc/mediatek/mt8196/include/soc/srclken_rc.h:

https://review.coreboot.org/c/coreboot/+/85842/comment/b58d37d5_d9be00e4?usp... :
PS5, Line 190: #define REQ_TO_SPMI_P_MASK_SHFT		0
Remove

File src/soc/mediatek/mt8196/srclken_rc.c:

https://review.coreboot.org/c/coreboot/+/85842/comment/382d0004_c0f592a6?usp... :
PS1, Line 265: code flow ASSERT already
> The id will be used to set the rc_mxx_srclken_cfg, and the rc_mxx_req_sta_0 will related to the rc_m […]

Okay, so you're saying the rc_mxx_req_sta_0 value will be determined by rc_mxx_srclken_cfg writes. However, I still don't understand the meaning of this comment.

Do you mean that, we don't need to dump the rc_mxx_req_sta_0 values here, because we're confident that the values will be correct? Or, do you mean that, with the assertion, there won't be out-of-bound access to the `rc_mxx_srclken_cfg` array (an invalid access will likely write to `rc_mxx_req_sta_0`)?