Name of user not set #1002358 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33215
Change subject: Initial commit for STM Support for Coreboot ......................................................................
Initial commit for STM Support for Coreboot
Change-Id: I1ff72261e67dc64d1a40f6685b8e92ca25d9eb76 --- M src/cpu/x86/mp_init.c M src/cpu/x86/smm/smm_module_handler.c M src/cpu/x86/smm/smm_module_loader.c M src/cpu/x86/smm/smm_stub.S A src/include/cpu/x86/SmmStm.h A src/include/cpu/x86/StmApi.h A src/include/cpu/x86/StmPlatformResource.h M src/include/cpu/x86/smm.h M src/security/Kconfig M src/security/Makefile.inc A src/security/stm/Kconfig A src/security/stm/Makefile.inc A src/security/stm/SmmStm.c A src/security/stm/StmPlatformResource.c A src/security/stm/StmPlatformSmm.c M src/soc/intel/fsp_baytrail/Kconfig 16 files changed, 2,367 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/33215/1
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index 3889c7d..e253451 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -37,8 +37,12 @@ #include <symbols.h> #include <thread.h>
+#include <cpu/x86/StmApi.h> + #define MAX_APIC_IDS 256
+extern int LoadStmImage(uint32_t); + struct mp_callback { void (*func)(void *); void *arg; @@ -823,6 +827,10 @@ { size_t smm_save_state_size = mp_state.smm_save_state_size;
+#ifdef CONFIG_STM + uint32_t mseg; +#endif + /* Do nothing if SMM is disabled.*/ if (!is_smm_enabled()) return; @@ -839,6 +847,14 @@ printk(BIOS_ERR, "Unable to install SMM permanent handler.\n"); smm_disable(); } +#ifdef CONFIG_STM + + /* Calculate mseg location*/ + mseg = mp_state.perm_smbase + (mp_state.perm_smsize - CONFIG_MSEG_SIZE); + + /* Load the STM into the MSEG */ + LoadStmImage(mseg); +#endif
/* Ensure the SMM handlers hit DRAM before performing first SMI. */ wbinvd(); @@ -1023,6 +1039,14 @@ if (ops->get_smm_info != NULL) ops->get_smm_info(&state->perm_smbase, &state->perm_smsize, &state->smm_save_state_size); +#ifdef CONFIG_STM + + /* Currently, the CPU SMM save state size is based on a simplistic algorithm. + * (set it to 1K) + * note: In the future, this will need to handle newer x86 that require 32k boundries.*/ + state->smm_save_state_size += (sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR) + 0x1000) & 0xfffff000; + +#endif /* CONFIG_STM */
/* * Default to smm_initiate_relocation() if trigger callback isn't diff --git a/src/cpu/x86/smm/smm_module_handler.c b/src/cpu/x86/smm/smm_module_handler.c index f9af965..d2b8e54 100644 --- a/src/cpu/x86/smm/smm_module_handler.c +++ b/src/cpu/x86/smm/smm_module_handler.c @@ -18,6 +18,18 @@ #include <cpu/x86/smm.h> #include <rmodule.h>
+#include <cpu/x86/msr.h> +#include <cpu/x86/cache.h> + +#include <cpu/x86/StmApi.h> +#include <cpu/x86/StmPlatformResource.h> +#include <arch/acpi.h> +#include <lib.h> +#include <cpu/x86/SmmStm.h> + +#define IA32_SMM_MONITOR_CTL_MSR_INDEX 0x9B +#define IA32_SMM_MONITOR_VALID 1<<0 + #if IS_ENABLED(CONFIG_SPI_FLASH_SMM) #include <spi-generic.h> #endif @@ -116,6 +128,10 @@ return base; }
+#ifdef CONFIG_STM + static uint32_t MsegInit = 0; // used for STM/mseg initialization +#endif + asmlinkage void smm_handler_start(void *arg) { const struct smm_module_params *p; @@ -123,7 +139,15 @@ int cpu; uintptr_t actual_canary; uintptr_t expected_canary; +#ifdef CONFIG_STM + int MsegInit2 = 1; // assume that the STM has been set
+ /* this initialzation strategy works on the assumption that all processors will + * enter SMM at generally the same time. If a single processor lags then a + * locking counting scheme will need to be implemented. */ + if(MsegInit == 0) + MsegInit2 = 0; +#endif p = arg; runtime = p->runtime; cpu = p->cpu; @@ -140,9 +164,34 @@ "Invalid CPU number assigned in SMM stub: %d\n", cpu); return; } +#ifdef CONFIG_STM + + if(MsegInit == 0) + { + /* Initialize the MSEG base address for each logical processor + * and indicate that there is an STM present */ + msr_t InitMseg; + msr_t MsegChk; + + InitMseg.lo = smm_runtime->mseg | IA32_SMM_MONITOR_VALID; + InitMseg.hi = 0; + + wrmsr(IA32_SMM_MONITOR_CTL_MSR_INDEX, InitMseg); + + MsegChk = rdmsr(IA32_SMM_MONITOR_CTL_MSR_INDEX); + console_init(); + + printk(BIOS_DEBUG, "MSEG Initialized (%d) 0x%08x 0x%08x\n", cpu, MsegChk.hi, MsegChk.lo ); + + } + +#endif
/* Are we ok to execute the handler? */ if (!smi_obtain_lock()) { +#ifdef CONFIG_STM + void * smbase = (void *) smm_runtime->smbase; +#endif /* For security reasons we don't release the other CPUs * until the CPU with the lock is actually done */ while (smi_handler_status == SMI_LOCKED) { @@ -150,9 +199,33 @@ ".byte 0xf3, 0x90\n" /* PAUSE */ ); } +#ifdef CONFIG_STM + if(MsegInit2 == 0) + { + /* Setup an SMM Descriptor for this logical processor */ + SetupSmmDescriptor(smbase, smm_runtime->save_state_size, cpu, smm_runtime->start32_offset); + MsegInit2 = 1; + } +#endif + wbinvd(); return; + }
+#ifdef CONFIG_STM + + if(MsegInit == 0){ + void * smbase = (void *) smm_runtime->smbase; + + AddResourcesCmd(); + + /* Setup an SMM Descriptor for this logical processor */ + + SetupSmmDescriptor(smbase, smm_runtime->save_state_size, cpu, smm_runtime->start32_offset); + MsegInit = 1; // flag that we are done + wbinvd(); // force the tables to memory + } +#endif smi_backup_pci_address();
console_init(); diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index 6c16645..b73facb 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -19,6 +19,8 @@ #include <cpu/x86/cache.h> #include <console/console.h>
+#include <cpu/x86/SmmStm.h> + #define FXSAVE_SIZE 512
/* FXSAVE area during relocation. While it may not be strictly needed the @@ -93,6 +95,8 @@ uint32_t disp = (uintptr_t)jmp_target;
disp -= sizeof(entry) + (uintptr_t)cur; + + printk(BIOS_DEBUG, "SMM Module: placing jmp sequence at %p rel16 0x%04x\n", cur, disp); @@ -268,6 +272,7 @@ stub_params->fxsave_area_size = FXSAVE_SIZE; stub_params->runtime.smbase = (uintptr_t)smbase; stub_params->runtime.save_state_size = params->per_cpu_save_state_size; + stub_params->runtime.mseg = (uint32_t) params->stack_top; // mseg is after the smi handler
/* Initialize the APIC id to CPU number table to be 1:1 */ for (i = 0; i < params->num_concurrent_stacks; i++) @@ -276,8 +281,8 @@ /* Allow the initiator to manipulate SMM stub parameters. */ params->runtime = &stub_params->runtime;
- printk(BIOS_DEBUG, "SMM Module: stub loaded at %p. Will call %p(%p)\n", - smm_stub_loc, params->handler, params->handler_arg); + printk(BIOS_DEBUG, "SMM Module: stub loaded at %p. Will call %p(%p) mseg %p\n", + smm_stub_loc, params->handler, params->handler_arg, (void *) stub_params->runtime.mseg);
return 0; } @@ -354,8 +359,14 @@
/* Stacks start at the top of the region. */ base = smram; + +#ifdef CONFIG_STM + base += size - CONFIG_MSEG_SIZE; // take out the mseg +#else base += size; - params->stack_top = base; +#endif + + params->stack_top = base;
/* SMM module starts at offset SMM_DEFAULT_SIZE with the load alignment * taken into account. */ diff --git a/src/cpu/x86/smm/smm_stub.S b/src/cpu/x86/smm/smm_stub.S index 59eb27c..eb42f7e 100644 --- a/src/cpu/x86/smm/smm_stub.S +++ b/src/cpu/x86/smm/smm_stub.S @@ -46,6 +46,11 @@ .long 0 save_state_size: .long 0 +mseg: +.long 0 +/* allows the STM to bring up SMM in 32-bit mode*/ +start32_offset: +.long smm_trampoline32 - _start /* apic_to_cpu_num is a table mapping the default APIC id to CPU num. If the * APIC id is found at the given index, the contiguous CPU number is index * into the table. */ @@ -92,6 +97,10 @@ /* gdt selector 0x10, flat data segment */ .word 0xffff, 0x0000 .byte 0x00, 0x93, 0xcf, 0x00 + + /* gdt selector 0x18 tr segment */ + .word 0xffff, 0x0000 + .byte 0x00, 0x8b, 0x80, 0x00 smm_relocate_gdt_end:
.align 4 diff --git a/src/include/cpu/x86/SmmStm.h b/src/include/cpu/x86/SmmStm.h new file mode 100644 index 0000000..5f5b625 --- /dev/null +++ b/src/include/cpu/x86/SmmStm.h @@ -0,0 +1,120 @@ +/** @file + SMM STM support + + Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR> + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BSD License + which accompanies this distribution. The full text of the license may be found at + http://opensource.org/licenses/bsd-license.php. + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. + +**/ + +#ifndef _SMM_STM_H_ +#define _SMM_STM_H_ + +#include "StmApi.h" + +#define IA32_VMX_BASIC_MSR_INDEX 0x480 +#define IA32_VMX_MISC_MSR_INDEX 0x485 +#define IA32_SMM_MONITOR_CTL_MSR_INDEX 0x9B +#define IA32_SMM_MONITOR_VALID 1<<0 + +/** + + Load STM image to MSEG. + + @param StmImage STM image + @param StmImageSize STM image size + + @retval EFI_SUCCESS Load STM to MSEG successfully + @retval EFI_BUFFER_TOO_SMALL MSEG is smaller than minimal requirement of STM image + +**/ +int LoadMonitor ( + void * StmImage, + uint32_t StmImageSize + ); + +/** + + Add resources in list to database. Allocate new memory areas as needed. + + @param ResourceList A pointer to resource list to be added + @param NumEntries Optional number of entries. + If 0, list must be terminated by END_OF_RESOURCES. + + @retval EFI_SUCCESS If resources are added + @retval EFI_INVALID_PARAMETER If nested procedure detected resource failer + @retval EFI_OUT_OF_RESOURCES If nested procedure returned it and we cannot allocate more areas. + +**/ +int AddPiResource ( + STM_RSC *ResourceList, + uint32_t NumEntries + ); + +/** + + Delete resources in list to database. + + @param ResourceList A pointer to resource list to be deleted + NULL means delete all resources. + @param NumEntries Optional number of entries. + If 0, list must be terminated by END_OF_RESOURCES. + + @retval EFI_SUCCESS If resources are deleted + @retval EFI_INVALID_PARAMETER If nested procedure detected resource failer + +**/ +int DeletePiResource ( + STM_RSC *ResourceList, + uint32_t NumEntries + ); + +/** + + Get BIOS resources. + + @param ResourceList A pointer to resource list to be filled + @param ResourceSize On input it means size of resource list input. + On output it means size of resource list filled, + or the size of resource list to be filled if size of too small. + + @retval EFI_SUCCESS If resources are returned. + @retval EFI_BUFFER_TOO_SMALL If resource list buffer is too small to hold the whole resources. + +**/ +int GetPiResource ( + STM_RSC *ResourceList, + uint32_t *ResourceSize + ); + +/** + This function notify STM resource change. + + @param StmResource BIOS STM resource + +**/ +void +NotifyStmResourceChange ( + void *StmResource + ); + +/** + This function return BIOS STM resource. + + @return BIOS STM resource + +**/ +void * +GetStmResource ( + void + ); + +void SetupSmmDescriptor(void * smbase, int32_t state_size, int32_t apic_id, int32_t entry32_off); + + +#endif diff --git a/src/include/cpu/x86/StmApi.h b/src/include/cpu/x86/StmApi.h new file mode 100644 index 0000000..97ed8ea --- /dev/null +++ b/src/include/cpu/x86/StmApi.h @@ -0,0 +1,738 @@ +/** @file + STM API definition + + Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BSD License + which accompanies this distribution. The full text of the license may be found at + http://opensource.org/licenses/bsd-license.php. + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. + +**/ + +#ifndef _STM_API_H_ +#define _STM_API_H_ + +#include <stdint.h> + +// definition in STM spec + +#define STM_SPEC_VERSION_MAJOR 1 +#define STM_SPEC_VERSION_MINOR 0 + +typedef uint64_t UINTN; + +#pragma pack (push, 1) + +#define STM_HARDWARE_FIELD_FILL_TO_2K (2048 - sizeof(uint32_t) * 8) +typedef struct { + uint32_t StmHeaderRevision; + uint32_t MonitorFeatures; + uint32_t GdtrLimit; + uint32_t GdtrBaseOffset; + uint32_t CsSelector; + uint32_t EipOffset; + uint32_t EspOffset; + uint32_t Cr3Offset; + uint8_t Reserved[STM_HARDWARE_FIELD_FILL_TO_2K]; +} HARDWARE_STM_HEADER; + +#define STM_FEATURES_IA32E 0x1 + +typedef struct { + uint32_t Intel64ModeSupported :1; // bitfield + uint32_t EptSupported :1; // bitfield + uint32_t Reserved :30; // must be 0 +} STM_FEAT; + +typedef struct { + uint8_t StmSpecVerMajor; + uint8_t StmSpecVerMinor; + uint16_t Reserved; // must be zero + uint32_t StaticImageSize; + uint32_t PerProcDynamicMemorySize; + uint32_t AdditionalDynamicMemorySize; + STM_FEAT StmFeatures; + uint32_t NumberOfRevIDs; + uint32_t StmSmmRevID[1]; + // + // The total STM_HEADER should be 4K. + // +} SOFTWARE_STM_HEADER; + +typedef struct { + HARDWARE_STM_HEADER HwStmHdr; + SOFTWARE_STM_HEADER SwStmHdr; +} STM_HEADER; + +#define SHA1 1 +#define SHA256 2 +typedef struct { + uint64_t BiosComponentBase; + uint32_t ImageSize; + uint32_t HashAlgorithm; // SHA1 or SHA256 + uint8_t Hash[32]; +} TXT_BIOS_COMPONENT_STATUS; + +#define PAGE_SIZE 4096 +typedef struct { + uint32_t ImageSize; + uint32_t Reserved; + uint64_t ImagePageBase[1]; //[NumberOfPages]; +} TXT_BIOS_COMPONENT_UPDATE; + +// If (ImageSizeInBytes % PAGE_SIZE == 0) { +// NumberOfPages = ImageSizeInBytes / PAGE_SIZE +// } else { +// NumberOfPages = ImageSizeInBytes / PAGE_SIZE + 1 +// } + + +typedef struct { + uint64_t SpeRip; + uint64_t SpeRsp; + uint16_t SpeSs; + uint16_t PageViolationException:1; + uint16_t MsrViolationException:1; + uint16_t RegisterViolationException:1; + uint16_t IoViolationException:1; + uint16_t PciViolationException:1; + uint16_t Reserved1:11; + uint32_t Reserved2; +} STM_PROTECTION_EXCEPTION_HANDLER; + +typedef struct { + uint8_t ExecutionDisableOutsideSmrr:1; + uint8_t Intel64Mode:1; + uint8_t Cr4Pae : 1; + uint8_t Cr4Pse : 1; + uint8_t Reserved1 : 4; +} STM_SMM_ENTRY_STATE; + +typedef struct { + uint8_t SmramToVmcsRestoreRequired : 1; // BIOS restore hint + uint8_t ReinitializeVmcsRequired : 1; // BIOS request + uint8_t Reserved2 : 6; +} STM_SMM_RESUME_STATE; + +typedef struct { + uint8_t DomainType : 4; // STM input to BIOS on each SMI + uint8_t XStatePolicy : 2; // STM input to BIOS on each SMI + uint8_t EptEnabled : 1; + uint8_t Reserved3 : 1; +} STM_SMM_STATE; + +typedef struct { + uint64_t Signature; + uint16_t Size; + uint8_t SmmDescriptorVerMajor; + uint8_t SmmDescriptorVerMinor; + uint32_t LocalApicId; + STM_SMM_ENTRY_STATE SmmEntryState; + STM_SMM_RESUME_STATE SmmResumeState; + STM_SMM_STATE StmSmmState; + uint8_t Reserved4; + uint16_t SmmCs; + uint16_t SmmDs; + uint16_t SmmSs; + uint16_t SmmOtherSegment; + uint16_t SmmTr; + uint16_t Reserved5; + uint64_t SmmCr3; + uint64_t SmmStmSetupRip; + uint64_t SmmStmTeardownRip; + uint64_t SmmSmiHandlerRip; + uint64_t SmmSmiHandlerRsp; + uint64_t SmmGdtPtr; + uint32_t SmmGdtSize; + uint32_t RequiredStmSmmRevId; + STM_PROTECTION_EXCEPTION_HANDLER StmProtectionExceptionHandler; + uint64_t Reserved6; + uint64_t BiosHwResourceRequirementsPtr; + // extend area + uint64_t AcpiRsdp; + uint8_t PhysicalAddressBits; +} TXT_PROCESSOR_SMM_DESCRIPTOR; + +#define TXT_PROCESSOR_SMM_DESCRIPTOR_SIGNATURE "TXTPSSIG" +#define TXT_PROCESSOR_SMM_DESCRIPTOR_VERSION_MAJOR 1 +#define TXT_PROCESSOR_SMM_DESCRIPTOR_VERSION_MINOR 0 + +#define SMM_PSD_OFFSET 0xfb00 + +typedef enum { + TxtSmmPageViolation = 1, + TxtSmmMsrViolation, + TxtSmmRegisterViolation, + TxtSmmIoViolation, + TxtSmmPciViolation +} TXT_SMM_PROTECTION_EXCEPTION_TYPE; + +typedef struct { + uint32_t Rdi; + uint32_t Rsi; + uint32_t Rbp; + uint32_t Rdx; + uint32_t Rcx; + uint32_t Rbx; + uint32_t Rax; + uint32_t Cr3; + uint32_t Cr2; + uint32_t Cr0; + uint32_t VmcsExitInstructionInfo; + uint32_t VmcsExitInstructionLength; + uint64_t VmcsExitQualification; + uint32_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE + uint32_t Rip; + uint32_t Cs; + uint32_t Rflags; + uint32_t Rsp; + uint32_t Ss; +} STM_PROTECTION_EXCEPTION_STACK_FRAME_IA32; + +typedef struct { + uint64_t R15; + uint64_t R14; + uint64_t R13; + uint64_t R12; + uint64_t R11; + uint64_t R10; + uint64_t R9; + uint64_t R8; + uint64_t Rdi; + uint64_t Rsi; + uint64_t Rbp; + uint64_t Rdx; + uint64_t Rcx; + uint64_t Rbx; + uint64_t Rax; + uint64_t Cr8; + uint64_t Cr3; + uint64_t Cr2; + uint64_t Cr0; + uint64_t VmcsExitInstructionInfo; + uint64_t VmcsExitInstructionLength; + uint64_t VmcsExitQualification; + uint64_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE + uint64_t Rip; + uint64_t Cs; + uint64_t Rflags; + uint64_t Rsp; + uint64_t Ss; +} STM_PROTECTION_EXCEPTION_STACK_FRAME_X64; + +typedef union { + STM_PROTECTION_EXCEPTION_STACK_FRAME_IA32 *Ia32StackFrame; + STM_PROTECTION_EXCEPTION_STACK_FRAME_X64 *X64StackFrame; +} STM_PROTECTION_EXCEPTION_STACK_FRAME; + +#define STM_SMM_REV_ID 0x80010100 + +typedef struct _STM_SMM_CPU_STATE { + uint8_t Reserved1[0x1d0]; // fc00h + uint32_t GdtBaseHiDword; // fdd0h : NO + uint32_t LdtBaseHiDword; // fdd4h : NO + uint32_t IdtBaseHiDword; // fdd8h : NO + uint8_t Reserved2[0x4]; // fddch + uint64_t IoRdi; // fde0h : NO - restricted + uint64_t IoEip; // fde8h : YES + uint64_t IoRcx; // fdf0h : NO - restricted + uint64_t IoRsi; // fdf8h : NO - restricted + uint8_t Reserved3[0x40]; // fe00h + uint32_t Cr4; // fe40h : NO + uint8_t Reserved4[0x48]; // fe44h + uint32_t GdtBaseLoDword; // fe8ch : NO + uint32_t GdtLimit; // fe90h : NO - RESTRICTED + uint32_t IdtBaseLoDword; // fe94h : NO + uint32_t IdtLimit; // fe98h : NO - RESTRICTED + uint32_t LdtBaseLoDword; // fe9ch : NO + uint32_t LdtLimit; // fea0h : NO - RESTRICTED + uint32_t LdtInfo; // fea4h : NO - RESTRICTED + uint8_t Reserved5[0x30]; // fea8h + uint64_t Eptp; // fed8h : NO + uint32_t EnabledEPT; // fee0h : NO + uint8_t Reserved6[0x14]; // fee4h + uint32_t Smbase; // fef8h : YES - NO for STM + uint32_t SMMRevId; // fefch : NO + uint16_t IORestart; // ff00h : YES + uint16_t AutoHALTRestart; // ff02h : YES + uint8_t Reserved7[0x18]; // ff04h + uint64_t R15; // ff1ch : YES + uint64_t R14; // ff24h : YES + uint64_t R13; // ff2ch : YES + uint64_t R12; // ff34h : YES + uint64_t R11; // ff3ch : YES + uint64_t R10; // ff44h : YES + uint64_t R9; // ff4ch : YES + uint64_t R8; // ff54h : YES + uint64_t Rax; // ff5ch : YES + uint64_t Rcx; // ff64h : YES + uint64_t Rdx; // ff6ch : YES + uint64_t Rbx; // ff74h : YES + uint64_t Rsp; // ff7ch : YES + uint64_t Rbp; // ff84h : YES + uint64_t Rsi; // ff8ch : YES + uint64_t Rdi; // ff94h : YES + uint64_t IOMemAddr; // ff9ch : NO + uint32_t IOMisc; // ffa4h : NO + uint32_t Es; // ffa8h : NO + uint32_t Cs; // ffach : NO + uint32_t Ss; // ffb0h : NO + uint32_t Ds; // ffb4h : NO + uint32_t Fs; // ffb8h : NO + uint32_t Gs; // ffbch : NO + uint32_t Ldtr; // ffc0h : NO + uint32_t Tr; // ffc4h : NO + uint64_t Dr7; // ffc8h : NO + uint64_t Dr6; // ffd0h : NO + uint64_t Rip; // ffd8h : YES + uint64_t Ia32Efer; // ffe0h : YES - NO for STM + uint64_t Rflags; // ffe8h : YES + uint64_t Cr3; // fff0h : NO + uint64_t Cr0; // fff8h : NO +} STM_SMM_CPU_STATE; + +// +// STM Mapping +// + +typedef struct { + uint64_t PhysicalAddress; + uint64_t VirtualAddress; + uint32_t PageCount; + uint32_t PatCacheType; +} STM_MAP_ADDRESS_RANGE_DESCRIPTOR; +#define ST_UC 0x00 +#define WC 0x01 +#define WT 0x04 +#define WP 0x05 +#define WB 0x06 +#define UC 0x07 +#define FOLLOW_MTRR 0xFFFFFFFF + +typedef struct { + uint64_t VirtualAddress; + uint32_t Length; +} STM_UNMAP_ADDRESS_RANGE_DESCRIPTOR; + +typedef struct { + uint64_t InterruptedGuestVirtualAddress; + uint32_t Length; + uint64_t InterruptedCr3; + uint64_t InterruptedEptp; + uint32_t MapToSmmGuest:2; + uint32_t InterruptedCr4Pae:1; + uint32_t InterruptedCr4Pse:1; + uint32_t InterruptedIa32eMode:1; + uint32_t Reserved1:27; + uint32_t Reserved2; + uint64_t PhysicalAddress; + uint64_t SmmGuestVirtualAddress; +} STM_ADDRESS_LOOKUP_DESCRIPTOR; +#define DO_NOT_MAP 0 +#define ONE_TO_ONE 1 +#define VIRTUAL_ADDRESS_SPECIFIED 3 + +// +// STM_RESOURCE_LIST +// +#define END_OF_RESOURCES 0 +#define MEM_RANGE 1 +#define IO_RANGE 2 +#define MMIO_RANGE 3 +#define MACHINE_SPECIFIC_REG 4 +#define PCI_CFG_RANGE 5 +#define TRAPPED_IO_RANGE 6 +#define ALL_RESOURCES 7 +#define REGISTER_VIOLATION 8 +#define MAX_DESC_TYPE 8 + +typedef struct { + uint32_t RscType; + uint16_t Length; + uint16_t ReturnStatus:1; + uint16_t Reserved:14; + uint16_t IgnoreResource:1; +} STM_RSC_DESC_HEADER; + +typedef struct { + STM_RSC_DESC_HEADER Hdr; + uint64_t ResourceListContinuation; +} STM_RSC_END; + +// byte granular Memory range support +#define STM_RSC_BGM 0x4 + +typedef struct { + STM_RSC_DESC_HEADER Hdr; + uint64_t Base; + uint64_t Length; + uint32_t RWXAttributes:3; + uint32_t Reserved:29; + uint32_t Reserved_2; +} STM_RSC_MEM_DESC; +#define STM_RSC_MEM_R 0x1 +#define STM_RSC_MEM_W 0x2 +#define STM_RSC_MEM_X 0x4 + +typedef struct { + STM_RSC_DESC_HEADER Hdr; + uint16_t Base; + uint16_t Length; + uint32_t Reserved; +} STM_RSC_IO_DESC; + +// byte granular MMIO range support +#define STM_RSC_BGI 0x2 + +typedef struct { + STM_RSC_DESC_HEADER Hdr; + uint64_t Base; + uint64_t Length; + uint32_t RWXAttributes:3; + uint32_t Reserved:29; + uint32_t Reserved_2; +} STM_RSC_MMIO_DESC; +#define STM_RSC_MMIO_R 0x1 +#define STM_RSC_MMIO_W 0x2 +#define STM_RSC_MMIO_X 0x4 + +typedef struct { + STM_RSC_DESC_HEADER Hdr; + uint32_t MsrIndex; + uint32_t KernelModeProcessing:1; + uint32_t Reserved:31; + uint64_t ReadMask; + uint64_t WriteMask; +} STM_RSC_MSR_DESC; + +// bit granular MSR resource support +#define STM_RSC_MSR 0x8 + +typedef struct { + uint8_t Type; // must be 1, indicating Hardware Device Path + uint8_t Subtype; // must be 1, indicating PCI + uint16_t Length; // sizeof(STM_PCI_DEVICE_PATH_NODE) which is 6 + uint8_t PciFunction; + uint8_t PciDevice; +} STM_PCI_DEVICE_PATH_NODE; +typedef struct { + STM_RSC_DESC_HEADER Hdr; + uint16_t RWAttributes:2; + uint16_t Reserved:14; + uint16_t Base; + uint16_t Length; + uint8_t OriginatingBusNumber; + uint8_t LastNodeIndex; + STM_PCI_DEVICE_PATH_NODE PciDevicePath[1]; +//STM_PCI_DEVICE_PATH_NODE PciDevicePath[LastNodeIndex + 1]; +} STM_RSC_PCI_CFG_DESC; + +#define STM_RSC_PCI_CFG_R 0x1 +#define STM_RSC_PCI_CFG_W 0x2 + +typedef struct { + STM_RSC_DESC_HEADER Hdr; + uint16_t Base; + uint16_t Length; + uint16_t In:1; + uint16_t Out:1; + uint16_t Api:1; + uint16_t Reserved1:13; + uint16_t Reserved2; +} STM_RSC_TRAPPED_IO_DESC; + +typedef struct { + STM_RSC_DESC_HEADER Hdr; +} STM_RSC_ALL_RESOURCES_DESC; + +typedef struct { + STM_RSC_DESC_HEADER Hdr; + uint32_t RegisterType; + uint32_t Reserved; + uint64_t ReadMask; + uint64_t WriteMask; +} STM_REGISTER_VIOLATION_DESC; + +typedef enum { + StmRegisterCr0, + StmRegisterCr2, + StmRegisterCr3, + StmRegisterCr4, + StmRegisterCr8, + StmRegisterMax, +} STM_REGISTER_VIOLATION_TYPE; + +typedef union { + STM_RSC_DESC_HEADER Header; + STM_RSC_END End; + STM_RSC_MEM_DESC Mem; + STM_RSC_IO_DESC Io; + STM_RSC_MMIO_DESC Mmio; + STM_RSC_MSR_DESC Msr; + STM_RSC_PCI_CFG_DESC PciCfg; + STM_RSC_TRAPPED_IO_DESC TrappedIo; + STM_RSC_ALL_RESOURCES_DESC All; + STM_REGISTER_VIOLATION_DESC RegisterViolation; +} STM_RSC; + +// +// VMCS database +// +#define STM_VMCS_DATABASE_REQUEST_ADD 1 +#define STM_VMCS_DATABASE_REQUEST_REMOVE 0 + +// Values for DomainType +// Intepreter of DomainType +#define DOMAIN_DISALLOWED_IO_OUT (1u << 0) +#define DOMAIN_DISALLOWED_IO_IN (1u << 1) +#define DOMAIN_INTEGRITY (1u << 2) +#define DOMAIN_CONFIDENTIALITY (1u << 3) + +#define DOMAIN_UNPROTECTED 0x00 +#define DOMAIN_INTEGRITY_PROT_OUT_IN (DOMAIN_INTEGRITY) +//#define DOMAIN_INTEGRITY_PROT_OUT (DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN) +#define DOMAIN_FULLY_PROT_OUT_IN (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY) +//#define DOMAIN_FULLY_PROT_IN (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_OUT) +//#define DOMAIN_FULLY_PROT_OUT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN) +#define DOMAIN_FULLY_PROT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN | DOMAIN_DISALLOWED_IO_OUT) + +// Values for XStatePolicy +#define XSTATE_READWRITE 0x00 +#define XSTATE_READONLY 0x01 +#define XSTATE_SCRUB 0x03 + +typedef struct { + uint64_t VmcsPhysPointer; // bits 11:0 are reserved and must be 0 + uint32_t DomainType :4; + uint32_t XStatePolicy :2; + uint32_t DegradationPolicy :4; + uint32_t Reserved1 :22; // Must be 0 + uint32_t AddOrRemove; +} STM_VMCS_DATABASE_REQUEST; + +// +// Event log +// +#define NEW_LOG 1 +#define CONFIGURE_LOG 2 +#define START_LOG 3 +#define STOP_LOG 4 +#define CLEAR_LOG 5 +#define DELETE_LOG 6 +typedef enum { + EvtLogStarted, + EvtLogStopped, + EvtLogInvalidParameterDetected, + EvtHandledProtectionException, + // unhandled protection exceptions result in reset & cannot be logged + EvtBiosAccessToUnclaimedResource, + EvtMleResourceProtectionGranted, + EvtMleResourceProtectionDenied, + EvtMleResourceUnprotect, + EvtMleResourceUnprotectError, + EvtMleDomainTypeDegraded, + // add more here + EvtMleMax, + // Not used + EvtInvalid = 0xFFFFFFFF, +} EVENT_TYPE; + +//#define STM_EVENT_LOG_PAGE_COUNT_MAX 62 + +typedef struct { + uint32_t PageCount; + uint64_t Pages[1]; // number of elements is PageCount +} STM_EVENT_LOG_MANAGEMENT_REQUEST_DATA_LOG_BUFFER; + +typedef union { + STM_EVENT_LOG_MANAGEMENT_REQUEST_DATA_LOG_BUFFER LogBuffer; + uint32_t EventEnableBitmap; // bitmap of EVENT_TYPE +} STM_EVENT_LOG_MANAGEMENT_REQUEST_DATA; + +typedef struct { + uint32_t SubFunctionIndex; + STM_EVENT_LOG_MANAGEMENT_REQUEST_DATA Data; +} STM_EVENT_LOG_MANAGEMENT_REQUEST; + +// +// VMCALL API Numbers +// + +// API number convention: BIOS facing VMCALL interfaces have bit 16 clear +#define STM_API_MAP_ADDRESS_RANGE 0x00000001 +#define STM_API_UNMAP_ADDRESS_RANGE 0x00000002 +#define STM_API_ADDRESS_LOOKUP 0x00000003 +#define STM_API_RETURN_FROM_PROTECTION_EXCEPTION 0x00000004 + +// API number convention: MLE facing VMCALL interfaces have bit 16 set +// +// The STM configuration lifecycle is as follows: +// 1. SENTER->SINIT->MLE: MLE begins execution with SMI disabled (masked). +// 2. MLE invokes InitializeProtectionVMCALL() to prepare STM for setup of initial protection profile. This is done on a single CPU and has global effect. +// 3. MLE invokes ProtectResourceVMCALL() to define the initial protection profile. The protection profile is global across all CPUs. +// 4. MLE invokes StartStmVMCALL() to enable the STM to begin receiving SMI events. This must be done on every logical CPU. +// 5. MLE may invoke ProtectResourceVMCALL() or UnProtectResourceVMCALL() during runtime as many times as necessary. +// 6. MLE invokes StopStmVMCALL() to disable the STM. SMI is again masked following StopStmVMCALL(). +// +#define STM_API_START 0x00010001 +#define STM_API_STOP 0x00010002 +#define STM_API_PROTECT_RESOURCE 0x00010003 +#define STM_API_UNPROTECT_RESOURCE 0x00010004 +#define STM_API_GET_BIOS_RESOURCES 0x00010005 +#define STM_API_MANAGE_VMCS_DATABASE 0x00010006 +#define STM_API_INITIALIZE_PROTECTION 0x00010007 +#define STM_API_MANAGE_EVENT_LOG 0x00010008 + +// +// Return codes +// +typedef uint32_t STM_STATUS; + +#define STM_SUCCESS 0x00000000 +#define SMM_SUCCESS 0x00000000 +// all error codes have bit 31 set +// STM errors have bit 16 set +#define ERROR_STM_SECURITY_VIOLATION 0x80010001 +#define ERROR_STM_CACHE_TYPE_NOT_SUPPORTED 0x80010002 +#define ERROR_STM_PAGE_NOT_FOUND 0x80010003 +#define ERROR_STM_BAD_CR3 0x80010004 +#define ERROR_STM_PHYSICAL_OVER_4G 0x80010005 +#define ERROR_STM_VIRTUAL_SPACE_TOO_SMALL 0x80010006 +#define ERROR_STM_UNPROTECTABLE_RESOURCE 0x80010007 +#define ERROR_STM_ALREADY_STARTED 0x80010008 +#define ERROR_STM_WITHOUT_SMX_UNSUPPORTED 0x80010009 +#define ERROR_STM_STOPPED 0x8001000A +#define ERROR_STM_BUFFER_TOO_SMALL 0x8001000B +#define ERROR_STM_INVALID_VMCS_DATABASE 0x8001000C +#define ERROR_STM_MALFORMED_RESOURCE_LIST 0x8001000D +#define ERROR_STM_INVALID_PAGECOUNT 0x8001000E +#define ERROR_STM_LOG_ALLOCATED 0x8001000F +#define ERROR_STM_LOG_NOT_ALLOCATED 0x80010010 +#define ERROR_STM_LOG_NOT_STOPPED 0x80010011 +#define ERROR_STM_LOG_NOT_STARTED 0x80010012 +#define ERROR_STM_RESERVED_BIT_SET 0x80010013 +#define ERROR_STM_NO_EVENTS_ENABLED 0x80010014 +#define ERROR_STM_OUT_OF_RESOURCES 0x80010015 +#define ERROR_STM_FUNCTION_NOT_SUPPORTED 0x80010016 +#define ERROR_STM_UNPROTECTABLE 0x80010017 +#define ERROR_STM_UNSUPPORTED_MSR_BIT 0x80010018 +#define ERROR_STM_UNSPECIFIED 0x8001FFFF + +// SMM errors have bit 17 set +#define ERROR_SMM_BAD_BUFFER 0x80020001 +#define ERROR_SMM_INVALID_RSC 0x80020004 +#define ERROR_SMM_INVALID_BUFFER_SIZE 0x80020005 +#define ERROR_SMM_BUFFER_TOO_SHORT 0x80020006 +#define ERROR_SMM_INVALID_LIST 0x80020007 +#define ERROR_SMM_OUT_OF_MEMORY 0x80020008 +#define ERROR_SMM_AFTER_INIT 0x80020009 +#define ERROR_SMM_UNSPECIFIED 0x8002FFFF + +// Errors that apply to both have bits 15, 16, and 17 set +#define ERROR_INVALID_API 0x80038001 +#define ERROR_INVALID_PARAMETER 0x80038002 + +// +// STM TXT.ERRORCODE codes +// +#define STM_CRASH_PROTECTION_EXCEPTION 0xC000F001 +#define STM_CRASH_PROTECTION_EXCEPTION_FAILURE 0xC000F002 +#define STM_CRASH_DOMAIN_DEGRADATION_FAILURE 0xC000F003 +#define STM_CRASH_BIOS_PANIC 0xC000E000 + +typedef struct { + uint32_t EventSerialNumber; + uint16_t Type; + uint16_t Lock :1; + uint16_t Valid :1; + uint16_t ReadByMle :1; + uint16_t Wrapped :1; + uint16_t Reserved :12; +} LOG_ENTRY_HEADER; + +typedef struct { + uint32_t Reserved; +} ENTRY_EVT_LOG_STARTED; + +typedef struct { + uint32_t Reserved; +} ENTRY_EVT_LOG_STOPPED; + +typedef struct { + uint32_t VmcallApiNumber; +} ENTRY_EVT_LOG_INVALID_PARAM; + +typedef struct { + STM_RSC Resource; +} ENTRY_EVT_LOG_HANDLED_PROTECTION_EXCEPTION; + +typedef struct { + STM_RSC Resource; +} ENTRY_EVT_BIOS_ACCESS_UNCLAIMED_RSC; + +typedef struct { + STM_RSC Resource; +} ENTRY_EVT_MLE_RSC_PROT_GRANTED; + +typedef struct { + STM_RSC Resource; +} ENTRY_EVT_MLE_RSC_PROT_DENIED; + +typedef struct { + STM_RSC Resource; +} ENTRY_EVT_MLE_RSC_UNPROT; + +typedef struct { + STM_RSC Resource; +} ENTRY_EVT_MLE_RSC_UNPROT_ERROR; + +typedef struct { + uint64_t VmcsPhysPointer; + uint8_t ExpectedDomainType; + uint8_t DegradedDomainType; +} ENTRY_EVT_MLE_DOMAIN_TYPE_DEGRADED; + +typedef union { + ENTRY_EVT_LOG_STARTED Started; + ENTRY_EVT_LOG_STOPPED Stopped; + ENTRY_EVT_LOG_INVALID_PARAM InvalidParam; + ENTRY_EVT_LOG_HANDLED_PROTECTION_EXCEPTION HandledProtectionException; + ENTRY_EVT_BIOS_ACCESS_UNCLAIMED_RSC BiosUnclaimedRsc; + ENTRY_EVT_MLE_RSC_PROT_GRANTED MleRscProtGranted; + ENTRY_EVT_MLE_RSC_PROT_DENIED MleRscProtDenied; + ENTRY_EVT_MLE_RSC_UNPROT MleRscUnprot; + ENTRY_EVT_MLE_RSC_UNPROT_ERROR MleRscUnprotError; + ENTRY_EVT_MLE_DOMAIN_TYPE_DEGRADED MleDomainTypeDegraded; +} LOG_ENTRY_DATA; + +typedef struct { + LOG_ENTRY_HEADER Hdr; + LOG_ENTRY_DATA Data; +} STM_LOG_ENTRY; + +#define STM_LOG_ENTRY_SIZE 256 + +// +// +// +#define STM_CONFIG_SMI_UNBLOCKING_BY_VMX_OFF 0x1 + +// +// TXT debug +// +#define SW_SMI_STM_ADD_RUNTIME_RESOURCES_SUB_FUNC 0 +#define SW_SMI_STM_READ_BIOS_RESOURCES_SUB_FUNC 1 +#define SW_SMI_STM_REPLACE_BIOS_RESOURCES_SUB_FUNC 2 + +typedef struct { + uint32_t BufferSize; + uint32_t Reserved; +//uint8_t Data[]; +} TXT_BIOS_DEBUG; + +#pragma pack (pop) + +#endif diff --git a/src/include/cpu/x86/StmPlatformResource.h b/src/include/cpu/x86/StmPlatformResource.h new file mode 100644 index 0000000..8e64436 --- /dev/null +++ b/src/include/cpu/x86/StmPlatformResource.h @@ -0,0 +1,47 @@ +/** @file + STM platform SMM resource + + Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BSD License + which accompanies this distribution. The full text of the license may be found at + http://opensource.org/licenses/bsd-license.php. + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. + +**/ + +#ifndef _STM_PLATFORM_RESOURCE_H_ +#define _STM_PLATFORM_RESOURCE_H_ + +#define MASK0 0 +#define MASK64 0xFFFFFFFFFFFFFFFFull + +// +// LPC +// +#define LPC_BUS 0 +#define LPC_DEVICE 31 +#define LPC_FUNCTION 0 +#define R_ACPI_PM_BASE 0x40 +#define ACPI_PM_BASE_MASK 0xFFF8 + +// +// MSRs +// +#define IA32_APIC_BASE_MSR_INDEX 0x1B +#define SMRR_PHYSBASE_MSR 0x1F2 +#define SMRR_PHYSMASK_MSR 0x1F3 + +/** + + Add resources to BIOS resource database. + +**/ +void +AddResourcesCmd ( + void + ); + +#endif diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h index 576449d..e0d170e 100644 --- a/src/include/cpu/x86/smm.h +++ b/src/include/cpu/x86/smm.h @@ -512,6 +512,9 @@ struct smm_runtime { u32 smbase; u32 save_state_size; + u32 mseg; + /* used so that the STM can start the SMI handler in 32bit mode */ + u32 start32_offset; /* The apic_id_to_cpu provides a mapping from APIC id to CPU number. * The CPU number is indicated by the index into the array by matching * the default APIC id and value at the index. The stub loader diff --git a/src/security/Kconfig b/src/security/Kconfig index 6a334ac..d87460a 100644 --- a/src/security/Kconfig +++ b/src/security/Kconfig @@ -14,3 +14,4 @@
source "src/security/vboot/Kconfig" source "src/security/tpm/Kconfig" +source "src/security/stm/Kconfig" diff --git a/src/security/Makefile.inc b/src/security/Makefile.inc index a940b82..85825fb 100644 --- a/src/security/Makefile.inc +++ b/src/security/Makefile.inc @@ -1,2 +1,4 @@ subdirs-y += vboot subdirs-y += tpm +subdirs-y += stm + diff --git a/src/security/stm/Kconfig b/src/security/stm/Kconfig new file mode 100644 index 0000000..56edd1a --- /dev/null +++ b/src/security/stm/Kconfig @@ -0,0 +1,16 @@ + +menu "SMI Transfer Monitor (STM)" + +config STM + bool "Enable STM" + default y + +if STM + +config MSEG_SIZE + hex "mseg size" + default 0x400000 + +endif #STM + +endmenu diff --git a/src/security/stm/Makefile.inc b/src/security/stm/Makefile.inc new file mode 100644 index 0000000..24d7bac --- /dev/null +++ b/src/security/stm/Makefile.inc @@ -0,0 +1,16 @@ + +# put the stm where is can be found + +cbfs-files-y += stm.bin +stm.bin-file = stm.bin +stm.bin-type = raw + +ramstage-y += SmmStm.c +ramstage-y += StmPlatformSmm.c +ramstage-y += StmPlatformResource.c + +smm-y += StmPlatformResource.c +smm-y += SmmStm.c +smm-y += StmPlatformSmm.c + + diff --git a/src/security/stm/SmmStm.c b/src/security/stm/SmmStm.c new file mode 100644 index 0000000..e01b72a --- /dev/null +++ b/src/security/stm/SmmStm.c @@ -0,0 +1,901 @@ +/** @file + + SMM STM support + + Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. + + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BSD License + which accompanies this distribution. The full text of the license may be found at + http://opensource.org/licenses/bsd-license.php. + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. + +**/ + +#include <cpu/x86/SmmStm.h> +#include <cpu/x86/msr.h> +#include <cpu/x86/cr.h> +#include <string.h> +#include <cpu/x86/mp.h> +#include <console/console.h> + +#define TXT_EVTYPE_BASE 0x400 +#define TXT_EVTYPE_STM_HASH (TXT_EVTYPE_BASE + 14) + +#define RDWR_ACCS 3 +#define FULL_ACCS 7 + +#define SIZE_4KB 0x00001000 +#define SIZE_4MB 0x00400000 + +#define IA32_PG_P 1<<0 +#define IA32_PG_RW 1<<1 +#define IA32_PG_PS 1<<7 + +#define STM_PAGE_SHIFT 12 +#define STM_PAGE_MASK 0xFFF +#define STM_SIZE_TO_PAGES(a) (((a) >> STM_PAGE_SHIFT) + (((a) & STM_PAGE_MASK) ? 1 : 0)) +#define STM_PAGES_TO_SIZE(a) ( (a) << STM_PAGE_SHIFT) + +#define STM_ACCESS_DENIED 15 +#define STM_UNSUPPORTED 3 + +#define STM_BUFFER_TOO_SMALL 1 + +#define STM_SM_MONITOR_STATE_ENABLED 1 + +#define RESOURCEHEAPSIZE 4096 + +uint32_t GetVmcsSize (void); +void StmGen4GPageTableIa32(uint32_t PageTableBase); +void StmGen4GPageTableX64 (uint32_t PageTableBase); +bool StmCheckStmImage (void * StmImage, uint32_t StmImageSize); +void StmLoadStmImage (void * StmImage, UINTN StmImageSize); + +bool HandleSingleResource (STM_RSC *Resource, STM_RSC *Record); +void AddSingleResource (STM_RSC *Resource); +void AddResource (STM_RSC *ResourceList, uint32_t NumEntries); +bool ValidateResource (STM_RSC *ResourceList, uint32_t NumEntries); +UINTN GetResourceSize (STM_RSC *ResourceList, uint32_t NumEntries); + +typedef struct { + + uint64_t VmcsRevisionID:31; + uint64_t AlwaysZero:1; + uint64_t VmcsSize:13; + uint64_t Reserved1:3; + uint64_t VmxonAddWidth:1; + uint64_t StmSupported:1; + uint64_t VmcsMemoryType:4; + uint64_t InOutReporting:1; + uint64_t MayClearDefaults:1; + uint64_t Reserved2:8; +} VMX_BASIC_MSR_BITS; + +typedef union { + VMX_BASIC_MSR_BITS bits; + uint64_t uint64; + msr_t msr; +} VMX_BASIC_MSR; + +typedef struct { + uint64_t valid:1; + uint64_t reserved1:1; + uint64_t VmxOffBlockSmi:1; + uint64_t reserved2:9; + uint64_t MsegAddress:20; + uint64_t reserved3:32; +} SMM_MONITOR_CTL_MSR_BITS; + +extern struct mp_state { + struct mp_ops ops; + int cpu_count; + uintptr_t perm_smbase; + size_t perm_smsize; + size_t smm_save_state_size; + int do_smm; +} mp_state; + +typedef union { + SMM_MONITOR_CTL_MSR_BITS bits; + uint64_t uint64; + msr_t msr; +} SMM_MONITOR_CTL_MSR; + +// +// Template of STM_RSC_END structure for copying. +// + +STM_RSC_END mRscEndNode = { + {END_OF_RESOURCES, sizeof (STM_RSC_END)}, +}; + +uint8_t *mStmResourcesPtr = NULL; +UINTN mStmResourceTotalSize = 0x0; +UINTN mStmResourceSizeUsed = 0x0; +UINTN mStmResourceSizeAvailable = 0x0; + +uint8_t StmResourceHeap[RESOURCEHEAPSIZE]; + +uint32_t mStmState = 0; + +/** + + Handle single Resource to see if it can be merged into Record. + + @param Resource A pointer to resource node to be added + @param Record A pointer to record node to be merged + + @retval true resource handled + @retval false resource is not handled + +**/ + +bool +HandleSingleResource ( + STM_RSC *Resource, + STM_RSC *Record + ) +{ + uint64_t ResourceLo; + uint64_t ResourceHi; + uint64_t RecordLo; + uint64_t RecordHi; + + ResourceLo = 0; + ResourceHi = 0; + RecordLo = 0; + RecordHi = 0; + + // + // Calling code is responsible for making sure that + // Resource->Header.RscType == (*Record)->Header.RscType + // thus we use just one of them as switch variable. + // + + switch (Resource->Header.RscType) { + case MEM_RANGE: + case MMIO_RANGE: + ResourceLo = Resource->Mem.Base; + ResourceHi = Resource->Mem.Base + Resource->Mem.Length; + RecordLo = Record->Mem.Base; + RecordHi = Record->Mem.Base + Record->Mem.Length; + if (Resource->Mem.RWXAttributes != Record->Mem.RWXAttributes) { + if ((ResourceLo == RecordLo) && (ResourceHi == RecordHi)) { + Record->Mem.RWXAttributes = Resource->Mem.RWXAttributes | Record->Mem.RWXAttributes; + return true; + } else { + return false; + } + } + break; + case IO_RANGE: + case TRAPPED_IO_RANGE: + ResourceLo = (uint64_t) Resource->Io.Base; + ResourceHi = (uint64_t) Resource->Io.Base + (uint64_t) Resource->Io.Length; + RecordLo = (uint64_t) Record->Io.Base; + RecordHi = (uint64_t) Record->Io.Base + (uint64_t) Record->Io.Length; + break; + case PCI_CFG_RANGE: + if ((Resource->PciCfg.OriginatingBusNumber != Record->PciCfg.OriginatingBusNumber) || + (Resource->PciCfg.LastNodeIndex != Record->PciCfg.LastNodeIndex)) { + return false; + } + if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { + return false; + } + ResourceLo = (uint64_t) Resource->PciCfg.Base; + ResourceHi = (uint64_t) Resource->PciCfg.Base + (uint64_t) Resource->PciCfg.Length; + RecordLo = (uint64_t) Record->PciCfg.Base; + RecordHi = (uint64_t) Record->PciCfg.Base + (uint64_t) Record->PciCfg.Length; + if (Resource->PciCfg.RWAttributes != Record->PciCfg.RWAttributes) { + if ((ResourceLo == RecordLo) && (ResourceHi == RecordHi)) { + Record->PciCfg.RWAttributes = Resource->PciCfg.RWAttributes | Record->PciCfg.RWAttributes; + return true; + } else { + return false; + } + } + break; + case MACHINE_SPECIFIC_REG: + // + // Special case - merge MSR masks in place. + // + if (Resource->Msr.MsrIndex != Record->Msr.MsrIndex) { + return false; + } + Record->Msr.ReadMask |= Resource->Msr.ReadMask; + Record->Msr.WriteMask |= Resource->Msr.WriteMask; + return true; + default: + return false; + } + // + // If resources are disjoint + // + if ((ResourceHi < RecordLo) || (ResourceLo > RecordHi)) { + return false; + } + + // + // If resource is consumed by record. + // + if ((ResourceLo >= RecordLo) && (ResourceHi <= RecordHi)) { + return true; + } + // + // Resources are overlapping. + // Resource and record are merged. + // + ResourceLo = (ResourceLo < RecordLo) ? ResourceLo : RecordLo; + ResourceHi = (ResourceHi > RecordHi) ? ResourceHi : RecordHi; + + switch (Resource->Header.RscType) { + case MEM_RANGE: + case MMIO_RANGE: + Record->Mem.Base = ResourceLo; + Record->Mem.Length = ResourceHi - ResourceLo; + break; + case IO_RANGE: + case TRAPPED_IO_RANGE: + Record->Io.Base = (uint64_t) ResourceLo; + Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo); + break; + case PCI_CFG_RANGE: + Record->PciCfg.Base = (uint64_t) ResourceLo; + Record->PciCfg.Length = (uint64_t) (ResourceHi - ResourceLo); + break; + default: + return false; + } + + return true; +} + +/** + + Add resource node. + + @param Resource A pointer to resource node to be added + +**/ +void +AddSingleResource ( + STM_RSC *Resource + ) +{ + STM_RSC *Record; + + Record = (STM_RSC *)mStmResourcesPtr; + + while (true) { + if (Record->Header.RscType == END_OF_RESOURCES) { + break; + } + // + // Go to next record if resource and record types don't match. + // + if (Resource->Header.RscType != Record->Header.RscType) { + Record = (STM_RSC *)((void *)Record + Record->Header.Length); + continue; + } + // + // Record is handled inside of procedure - don't adjust. + // + if (HandleSingleResource (Resource, Record)) { + return ; + } + Record = (STM_RSC *)((void *)Record + Record->Header.Length); + } + + // + // Add resource to the end of area. + // + memcpy ( + mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode), + Resource, + Resource->Header.Length + ); + memcpy ( + mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode) + Resource->Header.Length, + &mRscEndNode, + sizeof(mRscEndNode) + ); + mStmResourceSizeUsed += Resource->Header.Length; + mStmResourceSizeAvailable = mStmResourceTotalSize - mStmResourceSizeUsed; + + return ; +} + +/** + + Add resource list. + + @param ResourceList A pointer to resource list to be added + @param NumEntries Optional number of entries. + If 0, list must be terminated by END_OF_RESOURCES. + +**/ +void +AddResource ( + STM_RSC *ResourceList, + uint32_t NumEntries + ) +{ + uint32_t Count; + UINTN Index; + STM_RSC *Resource; + + if (NumEntries == 0) { + Count = 0xFFFFFFFF; + } else { + Count = NumEntries; + } + + Resource = ResourceList; + + for (Index = 0; Index < Count; Index++) { + if (Resource->Header.RscType == END_OF_RESOURCES) { + return ; + } + AddSingleResource (Resource); + Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length); + } + return ; +} + +/** + + Validate resource list. + + @param ResourceList A pointer to resource list to be added + @param NumEntries Optional number of entries. + If 0, list must be terminated by END_OF_RESOURCES. + + @retval true resource valid + @retval false resource invalid + +**/ +bool +ValidateResource ( + STM_RSC *ResourceList, + uint32_t NumEntries + ) +{ + uint32_t Count; + UINTN Index; + STM_RSC *Resource; + UINTN SubIndex; + + // + // If NumEntries == 0 make it very big. Scan will be terminated by + // END_OF_RESOURCES. + // + if (NumEntries == 0) { + Count = 0xFFFFFFFF; + } else { + Count = NumEntries; + } + + // + // Start from beginning of resource list. + // + Resource = ResourceList; + + for (Index = 0; Index < Count; Index++) { + printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType); + // + // Validate resource. + // + switch (Resource->Header.RscType) { + case END_OF_RESOURCES: + if (Resource->Header.Length != sizeof (STM_RSC_END)) { + return false; + } + // + // If we are passed actual number of resources to add, + // END_OF_RESOURCES structure between them is considered an + // error. If NumEntries == 0 END_OF_RESOURCES is a termination. + // + if (NumEntries != 0) { + return false; + } else { + // + // If NumEntries == 0 and list reached end - return success. + // + return true; + } + break; + + case MEM_RANGE: + case MMIO_RANGE: + if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) { + return false; + } + + if (Resource->Mem.RWXAttributes > FULL_ACCS) { + return false; + } + break; + + case IO_RANGE: + case TRAPPED_IO_RANGE: + if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) { + return false; + } + + if ((Resource->Io.Base + Resource->Io.Length) > 0xFFFF) { + return false; + } + break; + + case PCI_CFG_RANGE: + printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction); + if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { + return false; + } + for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) { + if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { + return false; + } + } + if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { + return false; + } + break; + + case MACHINE_SPECIFIC_REG: + if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { + return false; + } + break; + + default : + printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType); + return false; + } + Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length); + } + return true; +} + +/** + + Get resource list. + EndResource is excluded. + + @param ResourceList A pointer to resource list to be added + @param NumEntries Optional number of entries. + If 0, list must be terminated by END_OF_RESOURCES. + + @retval true resource valid + @retval false resource invalid + +**/ +UINTN +GetResourceSize ( + STM_RSC *ResourceList, + uint32_t NumEntries + ) +{ + uint32_t Count; + UINTN Index; + STM_RSC *Resource; + + Resource = ResourceList; + + // + // If NumEntries == 0 make it very big. Scan will be terminated by + // END_OF_RESOURCES. + // + if (NumEntries == 0) { + Count = 0xFFFFFFFF; + } else { + Count = NumEntries; + } + + // + // Start from beginning of resource list. + // + Resource = ResourceList; + + for (Index = 0; Index < Count; Index++) { + if (Resource->Header.RscType == END_OF_RESOURCES) { + break; + } + Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length); + } + return (UINTN)((uint32_t)Resource - (uint32_t) ResourceList); +} + +/** + + Add resources in list to database. Allocate new memory areas as needed. + + @param ResourceList A pointer to resource list to be added + @param NumEntries Optional number of entries. + If 0, list must be terminated by END_OF_RESOURCES. + + @retval EFI_SUCCESS If resources are added + @retval EFI_INVALID_PARAMETER If nested procedure detected resource failer + @retval EFI_OUT_OF_RESOURCES If nested procedure returned it and we cannot allocate more areas. + +**/ +int +AddPiResource ( + STM_RSC *ResourceList, + uint32_t NumEntries + ) +{ + //int Status; + UINTN ResourceSize; + //void * NewResource; + //UINTN NewResourceSize; + + printk (BIOS_DEBUG, "AddPiResource - Enter\n"); + + if (!ValidateResource (ResourceList, NumEntries)) { + return -1; //EFI_INVALID_PARAMETER; + } + + ResourceSize = GetResourceSize (ResourceList, NumEntries); + printk (BIOS_DEBUG, "ResourceSize - 0x%08llx\n", ResourceSize); + if (ResourceSize == 0) { + return -1;//EFI_INVALID_PARAMETER; + } + + if (mStmResourcesPtr == NULL) { + // + // Copy EndResource for intialization + // + //mStmResourcesPtr = (uint8_t *)(UINTN)NewResource; + //mStmResourceTotalSize = NewResourceSize; + + mStmResourcesPtr = StmResourceHeap; + mStmResourceTotalSize = RESOURCEHEAPSIZE; + memset(mStmResourcesPtr, 0, RESOURCEHEAPSIZE); + + memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); + mStmResourceSizeUsed = sizeof(mRscEndNode); + mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode); + + // + // Let SmmCore change resource ptr + // + //NotifyStmResourceChange (mStmResourcesPtr); + } else if (mStmResourceSizeAvailable < ResourceSize) { + // + // Need enlarge + // + printk(BIOS_DEBUG, "ERROR - not enough soace for SMM resource list\n"); + return -1; + } + + // + // Check duplication + // + AddResource (ResourceList, NumEntries); + + return 0;//EFI_SUCCESS; +} + +/** + + Delete resources in list to database. + + @param ResourceList A pointer to resource list to be deleted + NULL means delete all resources. + @param NumEntries Optional number of entries. + If 0, list must be terminated by END_OF_RESOURCES. + + @retval EFI_SUCCESS If resources are deleted + @retval EFI_INVALID_PARAMETER If nested procedure detected resource failer + +**/ +int32_t +DeletePiResource ( + STM_RSC *ResourceList, + uint32_t NumEntries + ) +{ + if (ResourceList != NULL) { + // TBD + //ASSERT (false); + return -1;//EFI_UNSUPPORTED; + } + // + // Delete all + // + memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); + mStmResourceSizeUsed = sizeof(mRscEndNode); + mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode); + return 0;//EFI_SUCCESS; +} + +/** + + Get BIOS resources. + + @param ResourceList A pointer to resource list to be filled + @param ResourceSize On input it means size of resource list input. + On output it means size of resource list filled, + or the size of resource list to be filled if size of too small. + + @retval EFI_SUCCESS If resources are returned. + @retval EFI_BUFFER_TOO_SMALL If resource list buffer is too small to hold the whole resources. + +**/ +int32_t +GetPiResource ( + STM_RSC *ResourceList, + uint32_t *ResourceSize + ) +{ + if (*ResourceSize < mStmResourceSizeUsed) { + *ResourceSize = (uint32_t)mStmResourceSizeUsed; + return -1;//EFI_BUFFER_TOO_SMALL; + } + + memcpy (ResourceList, mStmResourcesPtr, mStmResourceSizeUsed); + *ResourceSize = (uint32_t)mStmResourceSizeUsed; + return 0;//EFI_SUCCESS; +} + +/** + Get 4K page aligned VMCS size. + @return 4K page aligned VMCS size + +**/ +uint32_t +GetVmcsSize ( + void + ) +{ + uint32_t ThisVmcsSize; + VMX_BASIC_MSR MsrData64; + int StmSupport; + + MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX); + + ThisVmcsSize = MsrData64.bits.VmcsSize; + StmSupport = MsrData64.bits.StmSupported; + printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport); + + // + // VMCS require 0x1000 alignment + // + ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize)); + + return ThisVmcsSize; +} + +/** + + Create 4G page table for STM. + 4M Non-PAE page table in IA32 version. + + @param PageTableBase The page table base in MSEG + +**/ +void +StmGen4GPageTableIa32 ( + uint32_t PageTableBase + ) +{ + UINTN Index; + uint32_t *Pte; + uint32_t Address; + + Pte = (uint32_t*)(uint32_t)PageTableBase; + + Address = 0; + for (Index = 0; Index < SIZE_4KB / sizeof (*Pte); Index++) { + *Pte = Address | IA32_PG_PS | IA32_PG_RW | IA32_PG_P; + Pte++; + Address += SIZE_4MB; + } + + return ; +} + +/** + + Create 4G page table for STM. + 2M PAE page table in X64 version. + + @param PageTableBase The page table base in MSEG + +**/ +void +StmGen4GPageTableX64 ( + uint32_t PageTableBase + ) +{ + UINTN Index; + UINTN SubIndex; + uint64_t *Pde; + uint64_t *Pte; + uint64_t *Pml4; + + Pml4 = (uint64_t*)(uint32_t) PageTableBase; + PageTableBase += SIZE_4KB; + *Pml4 = PageTableBase | IA32_PG_RW | IA32_PG_P; + + Pde = (uint64_t*)(uint32_t)PageTableBase; + PageTableBase += SIZE_4KB; + Pte = (uint64_t *)(uint32_t)PageTableBase; + + for (Index = 0; Index < 4; Index++) { + *Pde = PageTableBase | IA32_PG_RW | IA32_PG_P; + Pde++; + PageTableBase += SIZE_4KB; + + for (SubIndex = 0; SubIndex < SIZE_4KB / sizeof (*Pte); SubIndex++) { + *Pte = (((Index << 9) + SubIndex) << 21) | IA32_PG_PS | IA32_PG_RW | IA32_PG_P; + Pte++; + } + } + + return ; +} + +/** + + Check STM image size. + + @param StmImage STM image + @param StmImageSize STM image size + + @retval true check pass + @retval false check fail +**/ + +bool StmCheckStmImage ( + void * StmImage, + uint32_t StmImageSize + ) +{ + UINTN MinMsegSize; + STM_HEADER *StmHeader; + + StmHeader = (STM_HEADER *)StmImage; + + // + // Get Minimal required Mseg size + // + MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + + StmHeader->SwStmHdr.AdditionalDynamicMemorySize + + (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count); + if (MinMsegSize < StmImageSize) { + MinMsegSize = StmImageSize; + } + + if (StmHeader->HwStmHdr.Cr3Offset >= StmHeader->SwStmHdr.StaticImageSize) { + // + // We will create page table, just in case that SINIT does not create it. + // + if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) { + MinMsegSize = StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6); + } + } + + // + // Check if it exceeds MSEG size + // + if (MinMsegSize > CONFIG_MSEG_SIZE) { + return false; + } + + return true; + +} + + +/** + + Load STM image to MSEG. + + @param StmImage STM image + @param StmImageSize STM image size + +**/ +void +StmLoadStmImage ( + void * StmImage, + UINTN StmImageSize + ) +{ + uint32_t MsegBase; + STM_HEADER *StmHeader; + SMM_MONITOR_CTL_MSR SmmMonitorMsr; + + StmHeader = (STM_HEADER *)(uint32_t)StmImage; + SmmMonitorMsr.msr = rdmsr(IA32_SMM_MONITOR_CTL_MSR_INDEX); + MsegBase = SmmMonitorMsr.bits.MsegAddress << 12; + + //ZeroMem ((void *)(uint32_t)MsegBase, (uint32_t)PcdGet32 (PcdCpuMsegSize)); + + memset((void *) MsegBase, 0, CONFIG_MSEG_SIZE); + //memcpy ((void *)(uint32_t)MsegBase, (void *)(uint32_t)StmImage, StmImageSize); + memcpy((void *) MsegBase, (void *) StmImage, (size_t) StmImageSize); + + + if (sizeof(UINTN) == sizeof(uint64_t)) { + StmGen4GPageTableX64 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); + } else { + StmGen4GPageTableIa32 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); + } + + // BUGBUG: SNB can not write 0x9B twice +// WriteCpuMsegInfo (); +} + +/** + + Load STM image to MSEG. + + @param StmImage STM image + @param StmImageSize STM image size + + @retval EFI_SUCCESS Load STM to MSEG successfully + @retval EFI_ALREADY_STARTED STM image is already loaded to MSEG + @retval EFI_BUFFER_TOO_SMALL MSEG is smaller than minimal requirement of STM image + @retval EFI_UNSUPPORTED MSEG is not enabled + +**/ +int LoadMonitor ( + void * StmImage, + uint32_t StmImageSize + ) +{ + SMM_MONITOR_CTL_MSR SmmMonCtlMsr; + + SmmMonCtlMsr.msr = (msr_t) rdmsr(IA32_SMM_MONITOR_CTL_MSR_INDEX); + + if (SmmMonCtlMsr.bits.MsegAddress == 0) { + return STM_UNSUPPORTED; + } + if (SmmMonCtlMsr.bits.valid != 0) { + // BUGBUG: SNB can not write 0x9B twice +// return EFI_ALREADY_STARTED; + } + + if (!StmCheckStmImage (StmImage, StmImageSize)) { + return STM_BUFFER_TOO_SMALL; + } + +#ifdef TPMSUPPORT + // Record STM_HASH to PCR 0, just in case it is NOT TXT launch, we still need provide the evidence. + TpmMeasureAndLogData( + 0, // PcrIndex + TXT_EVTYPE_STM_HASH, // EventType + NULL, // EventLog + 0, // LogLen + (void *)StmImage, // HashData + StmImageSize // HashDataLen + ); +#endif + StmLoadStmImage (StmImage, StmImageSize); + + mStmState |= STM_SM_MONITOR_STATE_ENABLED; + + return STM_SUCCESS; +} + +/** + This function return BIOS STM resource. + Produced by SmmStm. + Comsumed by SmmMpService when Init. + + @return BIOS STM resource +**/ +void * +GetStmResource( + void + ) +{ + return mStmResourcesPtr; +} + diff --git a/src/security/stm/StmPlatformResource.c b/src/security/stm/StmPlatformResource.c new file mode 100644 index 0000000..569a7f7 --- /dev/null +++ b/src/security/stm/StmPlatformResource.c @@ -0,0 +1,272 @@ +/** @file + STM platform SMM resource + + Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BSD License + which accompanies this distribution. The full text of the license may be found at + http://opensource.org/licenses/bsd-license.php. + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. + +**/ + +#include <stdint.h> +#include <cpu/x86/StmApi.h> +#include <cpu/x86/SmmStm.h> +#include <cpu/x86/StmPlatformResource.h> + +#include <southbridge/intel/common/pmutil.h> +#include <cpu/x86/msr.h> + +#define RDWR_ACCS 3 +#define FULL_ACCS 7 + +uint32_t mMaxBus; +uint32_t mTsegBase; +uint32_t mTsegSize; +uint16_t mPmBase; + +typedef union { + uint64_t uint64; + msr_t msr; +} msr64_t; + +//uint64_t PciRead64 (UINTN Address); +void ResourceInit (void); +void FixupPciexResource (void); +void AddSimpleResources (void); +void AddMsrResources (void); + +// +// Fixed memory ranges +// + +// +// TSEG memory! +// +STM_RSC_MEM_DESC RscTsegMemory = { + {MEM_RANGE, sizeof (STM_RSC_MEM_DESC)}, + 0, + 0, + FULL_ACCS +}; +// +// Flash part +// +STM_RSC_MEM_DESC RscSpiMemory = { + {MEM_RANGE, sizeof (STM_RSC_MEM_DESC)}, + 0xFE000000, + 0x01000000, + FULL_ACCS +}; +// +// ACPI +// +STM_RSC_IO_DESC RscPmIo = { + {IO_RANGE, sizeof (STM_RSC_IO_DESC)}, + 0, + 128 +}; + +// +// PCIE MMIO +// +STM_RSC_MMIO_DESC RscPcieMmio = { + {MMIO_RANGE, sizeof (STM_RSC_MMIO_DESC)}, + 0, + 0, // Length + RDWR_ACCS +}; +// +// Local APIC +// +STM_RSC_MMIO_DESC RscApicMmio = { + {MMIO_RANGE, sizeof (STM_RSC_MMIO_DESC)}, + 0, + 0x400, + RDWR_ACCS +}; +// +// Software SMI +// +STM_RSC_TRAPPED_IO_DESC RscSwSmiTrapIo = { + {TRAPPED_IO_RANGE, sizeof (STM_RSC_TRAPPED_IO_DESC)}, + 0xB2, + 2 +}; +// +// End of list +// +STM_RSC_END RscListEnd = { + {END_OF_RESOURCES, sizeof (STM_RSC_END)}, + 0 +}; + +// +// Common PCI devices +// +// +// LPC bridge +// +STM_RSC_PCI_CFG_DESC RscLpcBridgePci = { + {PCI_CFG_RANGE, sizeof (STM_RSC_PCI_CFG_DESC)}, + RDWR_ACCS, 0, + 0, + 0x1000, + 0, + 0, + { + {1, 1, sizeof(STM_PCI_DEVICE_PATH_NODE), LPC_FUNCTION, LPC_DEVICE}, + }, +}; + +// +// Template for MSR resources. +// +STM_RSC_MSR_DESC RscMsrTpl = { + {MACHINE_SPECIFIC_REG, sizeof (STM_RSC_MSR_DESC)}, +}; + +// +// MSR indices to register +// +typedef struct { + uint32_t MsrIndex; + uint64_t ReadMask; + uint64_t WriteMask; +} MSR_TABLE_ENTRY; + +MSR_TABLE_ENTRY MsrTable[] = { + // Index Read Write // MASK64 means need access, MASK0 means no need access. + {SMRR_PHYSBASE_MSR, MASK64, MASK0}, + {SMRR_PHYSMASK_MSR, MASK64, MASK0}, +}; + +/** + + BIOS resources initialization. + +**/ +void +ResourceInit ( + void + ) +{ + mMaxBus = 255; + + msr_t MsrRead; + + mPmBase = get_pmbase(); + + //mTsegBase = (uint32_t)rdmsr(SMRR_PHYSBASE_MSR) & 0xFFFFF000; + + MsrRead = rdmsr(SMRR_PHYSBASE_MSR); + mTsegBase = MsrRead.lo & 0xFFFFF000; + + //mTsegSize = (uint32_t)(~((uint32_t)rdmsr(SMRR_PHYSMASK_MSR) & 0xFFFFF000) + 1); + + MsrRead = rdmsr(SMRR_PHYSMASK_MSR); + mTsegSize = (~(MsrRead.lo & 0xFFFFF000) + 1); +} + +/** + + Fix up PCIE resource. + +**/ +void +FixupPciexResource ( + void + ) +{ + // + // Find max bus number and PCIEX length + // + //RscPcieMmio.Length = 0x10000000; // 256 MB + //RscPcieMmio.Base = PcdGet64 (PcdPciExpressBaseAddress); +} + +/** + + Add basic resources to BIOS resource database. + +**/ +void +AddSimpleResources ( + void + ) +{ + int Status; + msr64_t ReadMsr; + + // + // Fix-up values + // + RscTsegMemory.Base = mTsegBase; + RscTsegMemory.Length = mTsegSize; + + RscPmIo.Base = (uint16_t) mPmBase; + + // + // Local APIC. We assume that all thteads are programmed identically + // despite that it is possible to have individual APIC address for + // each of the threads. If this is the case this programming should + // be corrected. + // + //RscApicMmio.Base = AsmReadMsr64 (IA32_APIC_BASE_MSR_INDEX) & 0xFFFFFF000ull; + + ReadMsr.msr = rdmsr(IA32_APIC_BASE_MSR_INDEX); + RscApicMmio.Base = ReadMsr.uint64 & 0xFFFFFF000ull; + + // + // PCIEX BAR + // + FixupPciexResource (); + + Status = AddPiResource((void *) &RscTsegMemory, 0); + //ASSERT_EFI_ERROR (Status); + Status = AddPiResource((void *) &RscLpcBridgePci, 1); + //ASSERT_EFI_ERROR (Status); +} + +/** + + Add MSR resources to BIOS resource database. + +**/ +void +AddMsrResources ( + void + ) +{ + uint32_t Status; + uint32_t Index; + + for (Index = 0; Index < sizeof(MsrTable)/sizeof(MsrTable[0]); Index ++) { + + RscMsrTpl.MsrIndex = (uint32_t) MsrTable[Index].MsrIndex; + RscMsrTpl.ReadMask = (uint64_t) MsrTable[Index].ReadMask; + RscMsrTpl.WriteMask = (uint64_t) MsrTable[Index].WriteMask; + + Status = AddPiResource ((void *) &RscMsrTpl, 1); + } +} + +/** + + Add resources to BIOS resource database. + +**/ +void +AddResourcesCmd ( + void + ) +{ + ResourceInit (); + + AddSimpleResources(); + + AddMsrResources (); +} diff --git a/src/security/stm/StmPlatformSmm.c b/src/security/stm/StmPlatformSmm.c new file mode 100644 index 0000000..1d4b978 --- /dev/null +++ b/src/security/stm/StmPlatformSmm.c @@ -0,0 +1,130 @@ +/** @file + STM platform SMM API + + Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> + This program and the accompanying materials + are licensed and made available under the terms and conditions of the BSD License + which accompanies this distribution. The full text of the license may be found at + http://opensource.org/licenses/bsd-license.php. + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. + +**/ + +#include <cpu/x86/StmApi.h> +#include <cpu/x86/SmmStm.h> +#include <cpu/x86/smm.h> + +#include <stddef.h> +#include <cbfs.h> +#include <console/console.h> +#include <lib.h> +#include <stdint.h> + +int LoadStmImage(uint32_t mseg); + +extern bool StmCheckStmImage(void* StmImage, uint32_t StmImageSize); +extern void StmGen4GPageTableIa32(uint32_t PageTableBase); +extern void StmGen4GPageTableX64 (uint32_t PageTableBase); + +/** + Load STM image. + + @retval EFI_SUCCESS STM is loaded to MSEG + @retval EFI_BUFFER_TOO_SMALL MSEG is too small + @retval EFI_UNSUPPORTED MSEG is not enabled +**/ +int LoadStmImage ( + uint32_t mseg + ) +{ + int Status; + void *MsegBase; + uint32_t StmBufferSize; + uint32_t StmImageSize; + bool StmStatus; + + STM_HEADER *StmHeader; + + // + // Extract STM image from FV + // + MsegBase = (void *) mseg; + StmBufferSize = CONFIG_MSEG_SIZE; + StmImageSize = 0; + + memset((void *) MsegBase, 0, CONFIG_MSEG_SIZE); // clear the mseg + + StmImageSize = cbfs_boot_load_file("stm.bin", MsegBase, StmBufferSize, CBFS_TYPE_RAW); + printk(BIOS_DEBUG, "STM loaded into mseg: 0x%08x size: %u \n", (uint32_t) MsegBase, StmImageSize); /* status is number of bytes loaded */ + + StmStatus = StmCheckStmImage(MsegBase, StmImageSize); + + StmHeader = MsegBase; + + StmGen4GPageTableX64 ((uint32_t)MsegBase + StmHeader->HwStmHdr.Cr3Offset); + + // Debug stuff + + printk(BIOS_DEBUG, "STM Header - Revision: 0x%08x Features: 0x%08x ... Cr3Offset: 0x%08x\n", + StmHeader->HwStmHdr.StmHeaderRevision, + StmHeader->HwStmHdr.MonitorFeatures, + StmHeader->HwStmHdr.Cr3Offset); + printk(BIOS_DEBUG, "STM Header - StaticImageSize: %d Cr3Location: 0x%08x \n", + StmHeader->SwStmHdr.StaticImageSize, + ((uint32_t) MsegBase + StmHeader->HwStmHdr.Cr3Offset)); + + Status = 0; // always return good for now + + return Status; +} + +struct descriptor +{ + uint16_t limit; + uintptr_t base; +} __attribute__((packed)); + + +void ReadGdtr( struct descriptor * gdtr); + +void ReadGdtr( struct descriptor * gdtr) +{ + __asm__ __volatile__ ( + "sgdt %0" + : "=m" (*gdtr) + ); +} + +void SetupSmmDescriptor(void * smbase, int32_t state_size, int32_t apic_id, int32_t entry32_off) +{ + struct descriptor Gdtr; + + TXT_PROCESSOR_SMM_DESCRIPTOR * Psd; + + Psd = smbase + SMM_PSD_OFFSET - (apic_id * state_size); + + printk(BIOS_DEBUG, "Setting up Smm Descriptor - Smbase: %p Psd: %p\n", smbase, Psd); + + memset(Psd, 0, sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR)); + + memcpy(&Psd->Signature, TXT_PROCESSOR_SMM_DESCRIPTOR_SIGNATURE, 8); + Psd->SmmDescriptorVerMajor = TXT_PROCESSOR_SMM_DESCRIPTOR_VERSION_MAJOR; + Psd->SmmDescriptorVerMinor = TXT_PROCESSOR_SMM_DESCRIPTOR_VERSION_MINOR; + Psd->SmmSmiHandlerRip = (uint64_t)((uint32_t)smbase + SMM_ENTRY_OFFSET + entry32_off); + Psd->LocalApicId = apic_id; + Psd->Size = sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR); + Psd->AcpiRsdp = 0; + Psd->BiosHwResourceRequirementsPtr = (uint64_t)((uint32_t)GetStmResource()); + Psd->SmmCs = 0x8; + Psd->SmmDs = 0x10; + Psd->SmmSs = 0x10; + Psd->SmmOtherSegment = 0x10; + Psd->SmmTr = 0x18; + + ReadGdtr(&Gdtr); + + Psd->SmmGdtPtr = Gdtr.base; + Psd->SmmGdtSize = Gdtr.limit + 1; // the stm will subtract, so need to compensate +} diff --git a/src/soc/intel/fsp_baytrail/Kconfig b/src/soc/intel/fsp_baytrail/Kconfig index 5228bb7..1e85876 100644 --- a/src/soc/intel/fsp_baytrail/Kconfig +++ b/src/soc/intel/fsp_baytrail/Kconfig @@ -44,6 +44,7 @@ select MICROCODE_BLOB_NOT_HOOKED_UP select INTEL_DESCRIPTOR_MODE_CAPABLE select HAVE_SPI_CONSOLE_SUPPORT + select STM
# Microcode header files are delivered in FSP package select USES_MICROCODE_HEADER_FILES if HAVE_FSP_BIN
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33215 )
Change subject: Initial commit for STM Support for Coreboot ......................................................................
Patch Set 1:
(2605 comments)
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/mp_init.c@44 PS1, Line 44: extern int LoadStmImage(uint32_t); function definition argument 'uint32_t' should also have an identifier name
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/mp_init.c@856 PS1, Line 856: LoadStmImage(mseg); code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/mp_init.c@856 PS1, Line 856: LoadStmImage(mseg); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/mp_init.c@1044 PS1, Line 1044: /* Currently, the CPU SMM save state size is based on a simplistic algorithm. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/mp_init.c@1046 PS1, Line 1046: * note: In the future, this will need to handle newer x86 that require 32k boundries.*/ line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/mp_init.c@1047 PS1, Line 1047: state->smm_save_state_size += (sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR) + 0x1000) & 0xfffff000; line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 31: #define IA32_SMM_MONITOR_VALID 1<<0 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 145: /* this initialzation strategy works on the assumption that all processors will line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 146: * enter SMM at generally the same time. If a single processor lags then a line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 148: if(MsegInit == 0) space required before the open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 168: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 169: if(MsegInit == 0) that open brace { should be on the previous line
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 169: if(MsegInit == 0) space required before the open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 182: console_init(); code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 182: console_init(); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 184: printk(BIOS_DEBUG, "MSEG Initialized (%d) 0x%08x 0x%08x\n", cpu, MsegChk.hi, MsegChk.lo ); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 184: printk(BIOS_DEBUG, "MSEG Initialized (%d) 0x%08x 0x%08x\n", cpu, MsegChk.hi, MsegChk.lo ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 185: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 193: void * smbase = (void *) smm_runtime->smbase; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 193: void * smbase = (void *) smm_runtime->smbase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 193: void * smbase = (void *) smm_runtime->smbase; "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 203: if(MsegInit2 == 0) that open brace { should be on the previous line
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 203: if(MsegInit2 == 0) space required before the open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 204: { trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 206: SetupSmmDescriptor(smbase, smm_runtime->save_state_size, cpu, smm_runtime->start32_offset); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 206: SetupSmmDescriptor(smbase, smm_runtime->save_state_size, cpu, smm_runtime->start32_offset); code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 206: SetupSmmDescriptor(smbase, smm_runtime->save_state_size, cpu, smm_runtime->start32_offset); please, no space before tabs
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 206: SetupSmmDescriptor(smbase, smm_runtime->save_state_size, cpu, smm_runtime->start32_offset); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 217: if(MsegInit == 0){ space required before the open brace '{'
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 217: if(MsegInit == 0){ space required before the open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 218: void * smbase = (void *) smm_runtime->smbase; "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 224: SetupSmmDescriptor(smbase, smm_runtime->save_state_size, cpu, smm_runtime->start32_offset); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_loader.c File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_loader.c@... PS1, Line 275: stub_params->runtime.mseg = (uint32_t) params->stack_top; // mseg is after the smi handler line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_loader.c@... PS1, Line 285: smm_stub_loc, params->handler, params->handler_arg, (void *) stub_params->runtime.mseg); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_loader.c@... PS1, Line 365: #else trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_loader.c@... PS1, Line 369: params->stack_top = base; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_module_loader.c@... PS1, Line 369: params->stack_top = base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_stub.S File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/#/c/33215/1/src/cpu/x86/smm/smm_stub.S@53 PS1, Line 53: .long smm_trampoline32 - _start trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h File src/include/cpu/x86/SmmStm.h:
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@1 PS1, Line 1: /** @file trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@2 PS1, Line 2: SMM STM support trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@3 PS1, Line 3: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@4 PS1, Line 4: Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR> trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@5 PS1, Line 5: This program and the accompanying materials trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@6 PS1, Line 6: are licensed and made available under the terms and conditions of the BSD License trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@6 PS1, Line 6: are licensed and made available under the terms and conditions of the BSD License line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@7 PS1, Line 7: which accompanies this distribution. The full text of the license may be found at trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@7 PS1, Line 7: which accompanies this distribution. The full text of the license may be found at line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@8 PS1, Line 8: http://opensource.org/licenses/bsd-license.php. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@9 PS1, Line 9: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@10 PS1, Line 10: THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@11 PS1, Line 11: WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@12 PS1, Line 12: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@13 PS1, Line 13: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@14 PS1, Line 14: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@15 PS1, Line 15: #ifndef _SMM_STM_H_ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@16 PS1, Line 16: #define _SMM_STM_H_ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@17 PS1, Line 17: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@18 PS1, Line 18: #include "StmApi.h" DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@19 PS1, Line 19: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@20 PS1, Line 20: #define IA32_VMX_BASIC_MSR_INDEX 0x480 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@21 PS1, Line 21: #define IA32_VMX_MISC_MSR_INDEX 0x485 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@22 PS1, Line 22: #define IA32_SMM_MONITOR_CTL_MSR_INDEX 0x9B DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@23 PS1, Line 23: #define IA32_SMM_MONITOR_VALID 1<<0 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@23 PS1, Line 23: #define IA32_SMM_MONITOR_VALID 1<<0 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@24 PS1, Line 24: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@25 PS1, Line 25: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@26 PS1, Line 26: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@27 PS1, Line 27: Load STM image to MSEG. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@28 PS1, Line 28: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@29 PS1, Line 29: @param StmImage STM image trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@30 PS1, Line 30: @param StmImageSize STM image size trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@31 PS1, Line 31: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@32 PS1, Line 32: @retval EFI_SUCCESS Load STM to MSEG successfully trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@33 PS1, Line 33: @retval EFI_BUFFER_TOO_SMALL MSEG is smaller than minimal requirement of STM image trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@33 PS1, Line 33: @retval EFI_BUFFER_TOO_SMALL MSEG is smaller than minimal requirement of STM image line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@34 PS1, Line 34: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@35 PS1, Line 35: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@36 PS1, Line 36: int LoadMonitor ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@36 PS1, Line 36: int LoadMonitor ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@37 PS1, Line 37: void * StmImage, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@37 PS1, Line 37: void * StmImage, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@37 PS1, Line 37: void * StmImage, "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@38 PS1, Line 38: uint32_t StmImageSize DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@38 PS1, Line 38: uint32_t StmImageSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@39 PS1, Line 39: ); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@39 PS1, Line 39: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@40 PS1, Line 40: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@41 PS1, Line 41: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@42 PS1, Line 42: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@43 PS1, Line 43: Add resources in list to database. Allocate new memory areas as needed. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@44 PS1, Line 44: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@45 PS1, Line 45: @param ResourceList A pointer to resource list to be added trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@46 PS1, Line 46: @param NumEntries Optional number of entries. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@47 PS1, Line 47: If 0, list must be terminated by END_OF_RESOURCES. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@47 PS1, Line 47: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@48 PS1, Line 48: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@49 PS1, Line 49: @retval EFI_SUCCESS If resources are added trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@50 PS1, Line 50: @retval EFI_INVALID_PARAMETER If nested procedure detected resource failer trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@51 PS1, Line 51: @retval EFI_OUT_OF_RESOURCES If nested procedure returned it and we cannot allocate more areas. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@51 PS1, Line 51: @retval EFI_OUT_OF_RESOURCES If nested procedure returned it and we cannot allocate more areas. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@52 PS1, Line 52: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@53 PS1, Line 53: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@54 PS1, Line 54: int AddPiResource ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@54 PS1, Line 54: int AddPiResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@55 PS1, Line 55: STM_RSC *ResourceList, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@55 PS1, Line 55: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@55 PS1, Line 55: STM_RSC *ResourceList, need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@56 PS1, Line 56: uint32_t NumEntries DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@56 PS1, Line 56: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@57 PS1, Line 57: ); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@57 PS1, Line 57: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@58 PS1, Line 58: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@59 PS1, Line 59: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@60 PS1, Line 60: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@61 PS1, Line 61: Delete resources in list to database. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@62 PS1, Line 62: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@63 PS1, Line 63: @param ResourceList A pointer to resource list to be deleted trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@64 PS1, Line 64: NULL means delete all resources. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@64 PS1, Line 64: NULL means delete all resources. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@65 PS1, Line 65: @param NumEntries Optional number of entries. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@66 PS1, Line 66: If 0, list must be terminated by END_OF_RESOURCES. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@66 PS1, Line 66: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@67 PS1, Line 67: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@68 PS1, Line 68: @retval EFI_SUCCESS If resources are deleted trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@69 PS1, Line 69: @retval EFI_INVALID_PARAMETER If nested procedure detected resource failer trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@70 PS1, Line 70: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@71 PS1, Line 71: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@72 PS1, Line 72: int DeletePiResource ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@72 PS1, Line 72: int DeletePiResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@73 PS1, Line 73: STM_RSC *ResourceList, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@73 PS1, Line 73: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@73 PS1, Line 73: STM_RSC *ResourceList, need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@74 PS1, Line 74: uint32_t NumEntries DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@74 PS1, Line 74: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@75 PS1, Line 75: ); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@75 PS1, Line 75: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@76 PS1, Line 76: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@77 PS1, Line 77: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@78 PS1, Line 78: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@79 PS1, Line 79: Get BIOS resources. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@80 PS1, Line 80: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@81 PS1, Line 81: @param ResourceList A pointer to resource list to be filled trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@82 PS1, Line 82: @param ResourceSize On input it means size of resource list input. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@83 PS1, Line 83: On output it means size of resource list filled, trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@83 PS1, Line 83: On output it means size of resource list filled, code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@84 PS1, Line 84: or the size of resource list to be filled if size of too small. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@84 PS1, Line 84: or the size of resource list to be filled if size of too small. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@84 PS1, Line 84: or the size of resource list to be filled if size of too small. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@85 PS1, Line 85: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@86 PS1, Line 86: @retval EFI_SUCCESS If resources are returned. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@87 PS1, Line 87: @retval EFI_BUFFER_TOO_SMALL If resource list buffer is too small to hold the whole resources. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@87 PS1, Line 87: @retval EFI_BUFFER_TOO_SMALL If resource list buffer is too small to hold the whole resources. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@88 PS1, Line 88: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@89 PS1, Line 89: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@90 PS1, Line 90: int GetPiResource ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@90 PS1, Line 90: int GetPiResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@91 PS1, Line 91: STM_RSC *ResourceList, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@91 PS1, Line 91: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@91 PS1, Line 91: STM_RSC *ResourceList, need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@92 PS1, Line 92: uint32_t *ResourceSize DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@92 PS1, Line 92: uint32_t *ResourceSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@93 PS1, Line 93: ); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@93 PS1, Line 93: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@94 PS1, Line 94: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@95 PS1, Line 95: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@96 PS1, Line 96: This function notify STM resource change. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@97 PS1, Line 97: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@98 PS1, Line 98: @param StmResource BIOS STM resource trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@99 PS1, Line 99: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@100 PS1, Line 100: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@101 PS1, Line 101: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@102 PS1, Line 102: NotifyStmResourceChange ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@102 PS1, Line 102: NotifyStmResourceChange ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@103 PS1, Line 103: void *StmResource DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@103 PS1, Line 103: void *StmResource please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@104 PS1, Line 104: ); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@104 PS1, Line 104: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@105 PS1, Line 105: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@106 PS1, Line 106: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@107 PS1, Line 107: This function return BIOS STM resource. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@108 PS1, Line 108: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@109 PS1, Line 109: @return BIOS STM resource trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@110 PS1, Line 110: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@111 PS1, Line 111: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@112 PS1, Line 112: void * DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@112 PS1, Line 112: void * function definition argument 'void' should also have an identifier name
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@113 PS1, Line 113: GetStmResource ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@113 PS1, Line 113: GetStmResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@114 PS1, Line 114: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@114 PS1, Line 114: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@115 PS1, Line 115: ); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@115 PS1, Line 115: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@116 PS1, Line 116: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@117 PS1, Line 117: void SetupSmmDescriptor(void * smbase, int32_t state_size, int32_t apic_id, int32_t entry32_off); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@117 PS1, Line 117: void SetupSmmDescriptor(void * smbase, int32_t state_size, int32_t apic_id, int32_t entry32_off); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@117 PS1, Line 117: void SetupSmmDescriptor(void * smbase, int32_t state_size, int32_t apic_id, int32_t entry32_off); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@118 PS1, Line 118: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@119 PS1, Line 119: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/SmmStm.h@120 PS1, Line 120: #endif DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h File src/include/cpu/x86/StmApi.h:
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@1 PS1, Line 1: /** @file trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@2 PS1, Line 2: STM API definition trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@3 PS1, Line 3: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@4 PS1, Line 4: Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@5 PS1, Line 5: This program and the accompanying materials trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@6 PS1, Line 6: are licensed and made available under the terms and conditions of the BSD License trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@6 PS1, Line 6: are licensed and made available under the terms and conditions of the BSD License line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@7 PS1, Line 7: which accompanies this distribution. The full text of the license may be found at trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@7 PS1, Line 7: which accompanies this distribution. The full text of the license may be found at line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@8 PS1, Line 8: http://opensource.org/licenses/bsd-license.php. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@9 PS1, Line 9: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@10 PS1, Line 10: THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@11 PS1, Line 11: WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@12 PS1, Line 12: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@13 PS1, Line 13: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@14 PS1, Line 14: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@15 PS1, Line 15: #ifndef _STM_API_H_ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@16 PS1, Line 16: #define _STM_API_H_ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@17 PS1, Line 17: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@18 PS1, Line 18: #include <stdint.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@19 PS1, Line 19: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@20 PS1, Line 20: // definition in STM spec trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@21 PS1, Line 21: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@22 PS1, Line 22: #define STM_SPEC_VERSION_MAJOR 1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@23 PS1, Line 23: #define STM_SPEC_VERSION_MINOR 0 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@24 PS1, Line 24: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@25 PS1, Line 25: typedef uint64_t UINTN; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@26 PS1, Line 26: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@27 PS1, Line 27: #pragma pack (push, 1) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@27 PS1, Line 27: #pragma pack (push, 1) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@28 PS1, Line 28: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@29 PS1, Line 29: #define STM_HARDWARE_FIELD_FILL_TO_2K (2048 - sizeof(uint32_t) * 8) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@30 PS1, Line 30: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@31 PS1, Line 31: uint32_t StmHeaderRevision; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@31 PS1, Line 31: uint32_t StmHeaderRevision; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@32 PS1, Line 32: uint32_t MonitorFeatures; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@32 PS1, Line 32: uint32_t MonitorFeatures; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@33 PS1, Line 33: uint32_t GdtrLimit; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@33 PS1, Line 33: uint32_t GdtrLimit; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@34 PS1, Line 34: uint32_t GdtrBaseOffset; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@34 PS1, Line 34: uint32_t GdtrBaseOffset; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@35 PS1, Line 35: uint32_t CsSelector; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@35 PS1, Line 35: uint32_t CsSelector; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@36 PS1, Line 36: uint32_t EipOffset; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@36 PS1, Line 36: uint32_t EipOffset; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@37 PS1, Line 37: uint32_t EspOffset; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@37 PS1, Line 37: uint32_t EspOffset; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@38 PS1, Line 38: uint32_t Cr3Offset; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@38 PS1, Line 38: uint32_t Cr3Offset; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@39 PS1, Line 39: uint8_t Reserved[STM_HARDWARE_FIELD_FILL_TO_2K]; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@39 PS1, Line 39: uint8_t Reserved[STM_HARDWARE_FIELD_FILL_TO_2K]; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@40 PS1, Line 40: } HARDWARE_STM_HEADER; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@41 PS1, Line 41: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@42 PS1, Line 42: #define STM_FEATURES_IA32E 0x1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@43 PS1, Line 43: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@44 PS1, Line 44: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@45 PS1, Line 45: uint32_t Intel64ModeSupported :1; // bitfield trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@45 PS1, Line 45: uint32_t Intel64ModeSupported :1; // bitfield please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@46 PS1, Line 46: uint32_t EptSupported :1; // bitfield trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@46 PS1, Line 46: uint32_t EptSupported :1; // bitfield please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@47 PS1, Line 47: uint32_t Reserved :30; // must be 0 trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@47 PS1, Line 47: uint32_t Reserved :30; // must be 0 please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@48 PS1, Line 48: } STM_FEAT; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@49 PS1, Line 49: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@50 PS1, Line 50: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@51 PS1, Line 51: uint8_t StmSpecVerMajor; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@51 PS1, Line 51: uint8_t StmSpecVerMajor; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@52 PS1, Line 52: uint8_t StmSpecVerMinor; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@52 PS1, Line 52: uint8_t StmSpecVerMinor; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@53 PS1, Line 53: uint16_t Reserved; // must be zero trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@53 PS1, Line 53: uint16_t Reserved; // must be zero please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@54 PS1, Line 54: uint32_t StaticImageSize; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@54 PS1, Line 54: uint32_t StaticImageSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@55 PS1, Line 55: uint32_t PerProcDynamicMemorySize; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@55 PS1, Line 55: uint32_t PerProcDynamicMemorySize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@56 PS1, Line 56: uint32_t AdditionalDynamicMemorySize; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@56 PS1, Line 56: uint32_t AdditionalDynamicMemorySize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@57 PS1, Line 57: STM_FEAT StmFeatures; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@57 PS1, Line 57: STM_FEAT StmFeatures; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@58 PS1, Line 58: uint32_t NumberOfRevIDs; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@58 PS1, Line 58: uint32_t NumberOfRevIDs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@59 PS1, Line 59: uint32_t StmSmmRevID[1]; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@59 PS1, Line 59: uint32_t StmSmmRevID[1]; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@60 PS1, Line 60: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@61 PS1, Line 61: // The total STM_HEADER should be 4K. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@62 PS1, Line 62: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@63 PS1, Line 63: } SOFTWARE_STM_HEADER; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@64 PS1, Line 64: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@65 PS1, Line 65: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@66 PS1, Line 66: HARDWARE_STM_HEADER HwStmHdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@66 PS1, Line 66: HARDWARE_STM_HEADER HwStmHdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@67 PS1, Line 67: SOFTWARE_STM_HEADER SwStmHdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@67 PS1, Line 67: SOFTWARE_STM_HEADER SwStmHdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@68 PS1, Line 68: } STM_HEADER; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@69 PS1, Line 69: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@70 PS1, Line 70: #define SHA1 1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@71 PS1, Line 71: #define SHA256 2 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@72 PS1, Line 72: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@73 PS1, Line 73: uint64_t BiosComponentBase; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@73 PS1, Line 73: uint64_t BiosComponentBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@74 PS1, Line 74: uint32_t ImageSize; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@74 PS1, Line 74: uint32_t ImageSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@75 PS1, Line 75: uint32_t HashAlgorithm; // SHA1 or SHA256 trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@75 PS1, Line 75: uint32_t HashAlgorithm; // SHA1 or SHA256 please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@76 PS1, Line 76: uint8_t Hash[32]; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@76 PS1, Line 76: uint8_t Hash[32]; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@77 PS1, Line 77: } TXT_BIOS_COMPONENT_STATUS; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@78 PS1, Line 78: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@79 PS1, Line 79: #define PAGE_SIZE 4096 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@80 PS1, Line 80: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@81 PS1, Line 81: uint32_t ImageSize; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@81 PS1, Line 81: uint32_t ImageSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@82 PS1, Line 82: uint32_t Reserved; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@82 PS1, Line 82: uint32_t Reserved; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@83 PS1, Line 83: uint64_t ImagePageBase[1]; //[NumberOfPages]; trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@83 PS1, Line 83: uint64_t ImagePageBase[1]; //[NumberOfPages]; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@84 PS1, Line 84: } TXT_BIOS_COMPONENT_UPDATE; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@85 PS1, Line 85: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@86 PS1, Line 86: // If (ImageSizeInBytes % PAGE_SIZE == 0) { trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@87 PS1, Line 87: // NumberOfPages = ImageSizeInBytes / PAGE_SIZE trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@88 PS1, Line 88: // } else { trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@89 PS1, Line 89: // NumberOfPages = ImageSizeInBytes / PAGE_SIZE + 1 trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@90 PS1, Line 90: // } trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@91 PS1, Line 91: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@92 PS1, Line 92: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@93 PS1, Line 93: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@94 PS1, Line 94: uint64_t SpeRip; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@94 PS1, Line 94: uint64_t SpeRip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@95 PS1, Line 95: uint64_t SpeRsp; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@95 PS1, Line 95: uint64_t SpeRsp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@96 PS1, Line 96: uint16_t SpeSs; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@96 PS1, Line 96: uint16_t SpeSs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@97 PS1, Line 97: uint16_t PageViolationException:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@97 PS1, Line 97: uint16_t PageViolationException:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@98 PS1, Line 98: uint16_t MsrViolationException:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@98 PS1, Line 98: uint16_t MsrViolationException:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@99 PS1, Line 99: uint16_t RegisterViolationException:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@99 PS1, Line 99: uint16_t RegisterViolationException:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@100 PS1, Line 100: uint16_t IoViolationException:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@100 PS1, Line 100: uint16_t IoViolationException:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@101 PS1, Line 101: uint16_t PciViolationException:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@101 PS1, Line 101: uint16_t PciViolationException:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@102 PS1, Line 102: uint16_t Reserved1:11; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@102 PS1, Line 102: uint16_t Reserved1:11; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@103 PS1, Line 103: uint32_t Reserved2; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@103 PS1, Line 103: uint32_t Reserved2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@104 PS1, Line 104: } STM_PROTECTION_EXCEPTION_HANDLER; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@105 PS1, Line 105: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@106 PS1, Line 106: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@107 PS1, Line 107: uint8_t ExecutionDisableOutsideSmrr:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@107 PS1, Line 107: uint8_t ExecutionDisableOutsideSmrr:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@108 PS1, Line 108: uint8_t Intel64Mode:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@108 PS1, Line 108: uint8_t Intel64Mode:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@109 PS1, Line 109: uint8_t Cr4Pae : 1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@109 PS1, Line 109: uint8_t Cr4Pae : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@110 PS1, Line 110: uint8_t Cr4Pse : 1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@110 PS1, Line 110: uint8_t Cr4Pse : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@111 PS1, Line 111: uint8_t Reserved1 : 4; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@111 PS1, Line 111: uint8_t Reserved1 : 4; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@112 PS1, Line 112: } STM_SMM_ENTRY_STATE; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@113 PS1, Line 113: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@114 PS1, Line 114: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@115 PS1, Line 115: uint8_t SmramToVmcsRestoreRequired : 1; // BIOS restore hint trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@115 PS1, Line 115: uint8_t SmramToVmcsRestoreRequired : 1; // BIOS restore hint line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@115 PS1, Line 115: uint8_t SmramToVmcsRestoreRequired : 1; // BIOS restore hint please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@116 PS1, Line 116: uint8_t ReinitializeVmcsRequired : 1; // BIOS request trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@116 PS1, Line 116: uint8_t ReinitializeVmcsRequired : 1; // BIOS request line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@116 PS1, Line 116: uint8_t ReinitializeVmcsRequired : 1; // BIOS request please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@117 PS1, Line 117: uint8_t Reserved2 : 6; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@117 PS1, Line 117: uint8_t Reserved2 : 6; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@118 PS1, Line 118: } STM_SMM_RESUME_STATE; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@119 PS1, Line 119: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@120 PS1, Line 120: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@121 PS1, Line 121: uint8_t DomainType : 4; // STM input to BIOS on each SMI trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@121 PS1, Line 121: uint8_t DomainType : 4; // STM input to BIOS on each SMI line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@121 PS1, Line 121: uint8_t DomainType : 4; // STM input to BIOS on each SMI please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@122 PS1, Line 122: uint8_t XStatePolicy : 2; // STM input to BIOS on each SMI trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@122 PS1, Line 122: uint8_t XStatePolicy : 2; // STM input to BIOS on each SMI line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@122 PS1, Line 122: uint8_t XStatePolicy : 2; // STM input to BIOS on each SMI please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@123 PS1, Line 123: uint8_t EptEnabled : 1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@123 PS1, Line 123: uint8_t EptEnabled : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@124 PS1, Line 124: uint8_t Reserved3 : 1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@124 PS1, Line 124: uint8_t Reserved3 : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@125 PS1, Line 125: } STM_SMM_STATE; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@126 PS1, Line 126: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@127 PS1, Line 127: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@128 PS1, Line 128: uint64_t Signature; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@128 PS1, Line 128: uint64_t Signature; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@129 PS1, Line 129: uint16_t Size; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@129 PS1, Line 129: uint16_t Size; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@130 PS1, Line 130: uint8_t SmmDescriptorVerMajor; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@130 PS1, Line 130: uint8_t SmmDescriptorVerMajor; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@131 PS1, Line 131: uint8_t SmmDescriptorVerMinor; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@131 PS1, Line 131: uint8_t SmmDescriptorVerMinor; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@132 PS1, Line 132: uint32_t LocalApicId; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@132 PS1, Line 132: uint32_t LocalApicId; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@133 PS1, Line 133: STM_SMM_ENTRY_STATE SmmEntryState; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@133 PS1, Line 133: STM_SMM_ENTRY_STATE SmmEntryState; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@134 PS1, Line 134: STM_SMM_RESUME_STATE SmmResumeState; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@134 PS1, Line 134: STM_SMM_RESUME_STATE SmmResumeState; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@135 PS1, Line 135: STM_SMM_STATE StmSmmState; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@135 PS1, Line 135: STM_SMM_STATE StmSmmState; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@136 PS1, Line 136: uint8_t Reserved4; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@136 PS1, Line 136: uint8_t Reserved4; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@137 PS1, Line 137: uint16_t SmmCs; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@137 PS1, Line 137: uint16_t SmmCs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@138 PS1, Line 138: uint16_t SmmDs; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@138 PS1, Line 138: uint16_t SmmDs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@139 PS1, Line 139: uint16_t SmmSs; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@139 PS1, Line 139: uint16_t SmmSs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@140 PS1, Line 140: uint16_t SmmOtherSegment; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@140 PS1, Line 140: uint16_t SmmOtherSegment; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@141 PS1, Line 141: uint16_t SmmTr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@141 PS1, Line 141: uint16_t SmmTr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@142 PS1, Line 142: uint16_t Reserved5; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@142 PS1, Line 142: uint16_t Reserved5; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@143 PS1, Line 143: uint64_t SmmCr3; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@143 PS1, Line 143: uint64_t SmmCr3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@144 PS1, Line 144: uint64_t SmmStmSetupRip; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@144 PS1, Line 144: uint64_t SmmStmSetupRip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@145 PS1, Line 145: uint64_t SmmStmTeardownRip; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@145 PS1, Line 145: uint64_t SmmStmTeardownRip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@146 PS1, Line 146: uint64_t SmmSmiHandlerRip; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@146 PS1, Line 146: uint64_t SmmSmiHandlerRip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@147 PS1, Line 147: uint64_t SmmSmiHandlerRsp; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@147 PS1, Line 147: uint64_t SmmSmiHandlerRsp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@148 PS1, Line 148: uint64_t SmmGdtPtr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@148 PS1, Line 148: uint64_t SmmGdtPtr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@149 PS1, Line 149: uint32_t SmmGdtSize; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@149 PS1, Line 149: uint32_t SmmGdtSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@150 PS1, Line 150: uint32_t RequiredStmSmmRevId; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@150 PS1, Line 150: uint32_t RequiredStmSmmRevId; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@151 PS1, Line 151: STM_PROTECTION_EXCEPTION_HANDLER StmProtectionExceptionHandler; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@151 PS1, Line 151: STM_PROTECTION_EXCEPTION_HANDLER StmProtectionExceptionHandler; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@152 PS1, Line 152: uint64_t Reserved6; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@152 PS1, Line 152: uint64_t Reserved6; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@153 PS1, Line 153: uint64_t BiosHwResourceRequirementsPtr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@153 PS1, Line 153: uint64_t BiosHwResourceRequirementsPtr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@154 PS1, Line 154: // extend area trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@155 PS1, Line 155: uint64_t AcpiRsdp; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@155 PS1, Line 155: uint64_t AcpiRsdp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@156 PS1, Line 156: uint8_t PhysicalAddressBits; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@156 PS1, Line 156: uint8_t PhysicalAddressBits; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@157 PS1, Line 157: } TXT_PROCESSOR_SMM_DESCRIPTOR; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@158 PS1, Line 158: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@159 PS1, Line 159: #define TXT_PROCESSOR_SMM_DESCRIPTOR_SIGNATURE "TXTPSSIG" DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@160 PS1, Line 160: #define TXT_PROCESSOR_SMM_DESCRIPTOR_VERSION_MAJOR 1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@161 PS1, Line 161: #define TXT_PROCESSOR_SMM_DESCRIPTOR_VERSION_MINOR 0 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@162 PS1, Line 162: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@163 PS1, Line 163: #define SMM_PSD_OFFSET 0xfb00 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@164 PS1, Line 164: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@165 PS1, Line 165: typedef enum { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@166 PS1, Line 166: TxtSmmPageViolation = 1, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@166 PS1, Line 166: TxtSmmPageViolation = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@167 PS1, Line 167: TxtSmmMsrViolation, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@167 PS1, Line 167: TxtSmmMsrViolation, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@168 PS1, Line 168: TxtSmmRegisterViolation, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@168 PS1, Line 168: TxtSmmRegisterViolation, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@169 PS1, Line 169: TxtSmmIoViolation, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@169 PS1, Line 169: TxtSmmIoViolation, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@170 PS1, Line 170: TxtSmmPciViolation DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@170 PS1, Line 170: TxtSmmPciViolation please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@171 PS1, Line 171: } TXT_SMM_PROTECTION_EXCEPTION_TYPE; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@172 PS1, Line 172: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@173 PS1, Line 173: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@174 PS1, Line 174: uint32_t Rdi; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@174 PS1, Line 174: uint32_t Rdi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@175 PS1, Line 175: uint32_t Rsi; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@175 PS1, Line 175: uint32_t Rsi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@176 PS1, Line 176: uint32_t Rbp; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@176 PS1, Line 176: uint32_t Rbp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@177 PS1, Line 177: uint32_t Rdx; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@177 PS1, Line 177: uint32_t Rdx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@178 PS1, Line 178: uint32_t Rcx; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@178 PS1, Line 178: uint32_t Rcx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@179 PS1, Line 179: uint32_t Rbx; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@179 PS1, Line 179: uint32_t Rbx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@180 PS1, Line 180: uint32_t Rax; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@180 PS1, Line 180: uint32_t Rax; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@181 PS1, Line 181: uint32_t Cr3; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@181 PS1, Line 181: uint32_t Cr3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@182 PS1, Line 182: uint32_t Cr2; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@182 PS1, Line 182: uint32_t Cr2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@183 PS1, Line 183: uint32_t Cr0; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@183 PS1, Line 183: uint32_t Cr0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@184 PS1, Line 184: uint32_t VmcsExitInstructionInfo; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@184 PS1, Line 184: uint32_t VmcsExitInstructionInfo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@185 PS1, Line 185: uint32_t VmcsExitInstructionLength; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@185 PS1, Line 185: uint32_t VmcsExitInstructionLength; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@186 PS1, Line 186: uint64_t VmcsExitQualification; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@186 PS1, Line 186: uint64_t VmcsExitQualification; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@187 PS1, Line 187: uint32_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@187 PS1, Line 187: uint32_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@188 PS1, Line 188: uint32_t Rip; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@188 PS1, Line 188: uint32_t Rip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@189 PS1, Line 189: uint32_t Cs; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@189 PS1, Line 189: uint32_t Cs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@190 PS1, Line 190: uint32_t Rflags; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@190 PS1, Line 190: uint32_t Rflags; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@191 PS1, Line 191: uint32_t Rsp; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@191 PS1, Line 191: uint32_t Rsp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@192 PS1, Line 192: uint32_t Ss; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@192 PS1, Line 192: uint32_t Ss; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@193 PS1, Line 193: } STM_PROTECTION_EXCEPTION_STACK_FRAME_IA32; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@194 PS1, Line 194: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@195 PS1, Line 195: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@196 PS1, Line 196: uint64_t R15; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@196 PS1, Line 196: uint64_t R15; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@197 PS1, Line 197: uint64_t R14; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@197 PS1, Line 197: uint64_t R14; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@198 PS1, Line 198: uint64_t R13; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@198 PS1, Line 198: uint64_t R13; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@199 PS1, Line 199: uint64_t R12; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@199 PS1, Line 199: uint64_t R12; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@200 PS1, Line 200: uint64_t R11; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@200 PS1, Line 200: uint64_t R11; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@201 PS1, Line 201: uint64_t R10; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@201 PS1, Line 201: uint64_t R10; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@202 PS1, Line 202: uint64_t R9; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@202 PS1, Line 202: uint64_t R9; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@203 PS1, Line 203: uint64_t R8; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@203 PS1, Line 203: uint64_t R8; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@204 PS1, Line 204: uint64_t Rdi; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@204 PS1, Line 204: uint64_t Rdi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@205 PS1, Line 205: uint64_t Rsi; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@205 PS1, Line 205: uint64_t Rsi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@206 PS1, Line 206: uint64_t Rbp; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@206 PS1, Line 206: uint64_t Rbp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@207 PS1, Line 207: uint64_t Rdx; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@207 PS1, Line 207: uint64_t Rdx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@208 PS1, Line 208: uint64_t Rcx; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@208 PS1, Line 208: uint64_t Rcx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@209 PS1, Line 209: uint64_t Rbx; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@209 PS1, Line 209: uint64_t Rbx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@210 PS1, Line 210: uint64_t Rax; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@210 PS1, Line 210: uint64_t Rax; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@211 PS1, Line 211: uint64_t Cr8; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@211 PS1, Line 211: uint64_t Cr8; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@212 PS1, Line 212: uint64_t Cr3; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@212 PS1, Line 212: uint64_t Cr3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@213 PS1, Line 213: uint64_t Cr2; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@213 PS1, Line 213: uint64_t Cr2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@214 PS1, Line 214: uint64_t Cr0; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@214 PS1, Line 214: uint64_t Cr0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@215 PS1, Line 215: uint64_t VmcsExitInstructionInfo; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@215 PS1, Line 215: uint64_t VmcsExitInstructionInfo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@216 PS1, Line 216: uint64_t VmcsExitInstructionLength; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@216 PS1, Line 216: uint64_t VmcsExitInstructionLength; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@217 PS1, Line 217: uint64_t VmcsExitQualification; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@217 PS1, Line 217: uint64_t VmcsExitQualification; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@218 PS1, Line 218: uint64_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@218 PS1, Line 218: uint64_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@219 PS1, Line 219: uint64_t Rip; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@219 PS1, Line 219: uint64_t Rip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@220 PS1, Line 220: uint64_t Cs; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@220 PS1, Line 220: uint64_t Cs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@221 PS1, Line 221: uint64_t Rflags; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@221 PS1, Line 221: uint64_t Rflags; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@222 PS1, Line 222: uint64_t Rsp; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@222 PS1, Line 222: uint64_t Rsp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@223 PS1, Line 223: uint64_t Ss; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@223 PS1, Line 223: uint64_t Ss; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@224 PS1, Line 224: } STM_PROTECTION_EXCEPTION_STACK_FRAME_X64; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@225 PS1, Line 225: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@226 PS1, Line 226: typedef union { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@227 PS1, Line 227: STM_PROTECTION_EXCEPTION_STACK_FRAME_IA32 *Ia32StackFrame; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@227 PS1, Line 227: STM_PROTECTION_EXCEPTION_STACK_FRAME_IA32 *Ia32StackFrame; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@228 PS1, Line 228: STM_PROTECTION_EXCEPTION_STACK_FRAME_X64 *X64StackFrame; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@228 PS1, Line 228: STM_PROTECTION_EXCEPTION_STACK_FRAME_X64 *X64StackFrame; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@229 PS1, Line 229: } STM_PROTECTION_EXCEPTION_STACK_FRAME; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@230 PS1, Line 230: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@231 PS1, Line 231: #define STM_SMM_REV_ID 0x80010100 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@232 PS1, Line 232: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@233 PS1, Line 233: typedef struct _STM_SMM_CPU_STATE { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@234 PS1, Line 234: uint8_t Reserved1[0x1d0]; // fc00h trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@234 PS1, Line 234: uint8_t Reserved1[0x1d0]; // fc00h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@235 PS1, Line 235: uint32_t GdtBaseHiDword; // fdd0h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@235 PS1, Line 235: uint32_t GdtBaseHiDword; // fdd0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@236 PS1, Line 236: uint32_t LdtBaseHiDword; // fdd4h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@236 PS1, Line 236: uint32_t LdtBaseHiDword; // fdd4h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@237 PS1, Line 237: uint32_t IdtBaseHiDword; // fdd8h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@237 PS1, Line 237: uint32_t IdtBaseHiDword; // fdd8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@238 PS1, Line 238: uint8_t Reserved2[0x4]; // fddch trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@238 PS1, Line 238: uint8_t Reserved2[0x4]; // fddch please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@239 PS1, Line 239: uint64_t IoRdi; // fde0h : NO - restricted trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@239 PS1, Line 239: uint64_t IoRdi; // fde0h : NO - restricted line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@239 PS1, Line 239: uint64_t IoRdi; // fde0h : NO - restricted please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@240 PS1, Line 240: uint64_t IoEip; // fde8h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@240 PS1, Line 240: uint64_t IoEip; // fde8h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@241 PS1, Line 241: uint64_t IoRcx; // fdf0h : NO - restricted trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@241 PS1, Line 241: uint64_t IoRcx; // fdf0h : NO - restricted line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@241 PS1, Line 241: uint64_t IoRcx; // fdf0h : NO - restricted please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@242 PS1, Line 242: uint64_t IoRsi; // fdf8h : NO - restricted trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@242 PS1, Line 242: uint64_t IoRsi; // fdf8h : NO - restricted line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@242 PS1, Line 242: uint64_t IoRsi; // fdf8h : NO - restricted please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@243 PS1, Line 243: uint8_t Reserved3[0x40]; // fe00h trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@243 PS1, Line 243: uint8_t Reserved3[0x40]; // fe00h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@244 PS1, Line 244: uint32_t Cr4; // fe40h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@244 PS1, Line 244: uint32_t Cr4; // fe40h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@245 PS1, Line 245: uint8_t Reserved4[0x48]; // fe44h trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@245 PS1, Line 245: uint8_t Reserved4[0x48]; // fe44h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@246 PS1, Line 246: uint32_t GdtBaseLoDword; // fe8ch : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@246 PS1, Line 246: uint32_t GdtBaseLoDword; // fe8ch : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@247 PS1, Line 247: uint32_t GdtLimit; // fe90h : NO - RESTRICTED trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@247 PS1, Line 247: uint32_t GdtLimit; // fe90h : NO - RESTRICTED line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@247 PS1, Line 247: uint32_t GdtLimit; // fe90h : NO - RESTRICTED please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@248 PS1, Line 248: uint32_t IdtBaseLoDword; // fe94h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@248 PS1, Line 248: uint32_t IdtBaseLoDword; // fe94h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@249 PS1, Line 249: uint32_t IdtLimit; // fe98h : NO - RESTRICTED trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@249 PS1, Line 249: uint32_t IdtLimit; // fe98h : NO - RESTRICTED line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@249 PS1, Line 249: uint32_t IdtLimit; // fe98h : NO - RESTRICTED please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@250 PS1, Line 250: uint32_t LdtBaseLoDword; // fe9ch : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@250 PS1, Line 250: uint32_t LdtBaseLoDword; // fe9ch : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@251 PS1, Line 251: uint32_t LdtLimit; // fea0h : NO - RESTRICTED trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@251 PS1, Line 251: uint32_t LdtLimit; // fea0h : NO - RESTRICTED line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@251 PS1, Line 251: uint32_t LdtLimit; // fea0h : NO - RESTRICTED please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@252 PS1, Line 252: uint32_t LdtInfo; // fea4h : NO - RESTRICTED trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@252 PS1, Line 252: uint32_t LdtInfo; // fea4h : NO - RESTRICTED line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@252 PS1, Line 252: uint32_t LdtInfo; // fea4h : NO - RESTRICTED please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@253 PS1, Line 253: uint8_t Reserved5[0x30]; // fea8h trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@253 PS1, Line 253: uint8_t Reserved5[0x30]; // fea8h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@254 PS1, Line 254: uint64_t Eptp; // fed8h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@254 PS1, Line 254: uint64_t Eptp; // fed8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@255 PS1, Line 255: uint32_t EnabledEPT; // fee0h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@255 PS1, Line 255: uint32_t EnabledEPT; // fee0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@256 PS1, Line 256: uint8_t Reserved6[0x14]; // fee4h trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@256 PS1, Line 256: uint8_t Reserved6[0x14]; // fee4h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@257 PS1, Line 257: uint32_t Smbase; // fef8h : YES - NO for STM trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@257 PS1, Line 257: uint32_t Smbase; // fef8h : YES - NO for STM line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@257 PS1, Line 257: uint32_t Smbase; // fef8h : YES - NO for STM please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@258 PS1, Line 258: uint32_t SMMRevId; // fefch : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@258 PS1, Line 258: uint32_t SMMRevId; // fefch : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@259 PS1, Line 259: uint16_t IORestart; // ff00h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@259 PS1, Line 259: uint16_t IORestart; // ff00h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@260 PS1, Line 260: uint16_t AutoHALTRestart; // ff02h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@260 PS1, Line 260: uint16_t AutoHALTRestart; // ff02h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@261 PS1, Line 261: uint8_t Reserved7[0x18]; // ff04h trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@261 PS1, Line 261: uint8_t Reserved7[0x18]; // ff04h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@262 PS1, Line 262: uint64_t R15; // ff1ch : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@262 PS1, Line 262: uint64_t R15; // ff1ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@263 PS1, Line 263: uint64_t R14; // ff24h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@263 PS1, Line 263: uint64_t R14; // ff24h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@264 PS1, Line 264: uint64_t R13; // ff2ch : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@264 PS1, Line 264: uint64_t R13; // ff2ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@265 PS1, Line 265: uint64_t R12; // ff34h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@265 PS1, Line 265: uint64_t R12; // ff34h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@266 PS1, Line 266: uint64_t R11; // ff3ch : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@266 PS1, Line 266: uint64_t R11; // ff3ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@267 PS1, Line 267: uint64_t R10; // ff44h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@267 PS1, Line 267: uint64_t R10; // ff44h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@268 PS1, Line 268: uint64_t R9; // ff4ch : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@268 PS1, Line 268: uint64_t R9; // ff4ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@269 PS1, Line 269: uint64_t R8; // ff54h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@269 PS1, Line 269: uint64_t R8; // ff54h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@270 PS1, Line 270: uint64_t Rax; // ff5ch : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@270 PS1, Line 270: uint64_t Rax; // ff5ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@271 PS1, Line 271: uint64_t Rcx; // ff64h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@271 PS1, Line 271: uint64_t Rcx; // ff64h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@272 PS1, Line 272: uint64_t Rdx; // ff6ch : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@272 PS1, Line 272: uint64_t Rdx; // ff6ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@273 PS1, Line 273: uint64_t Rbx; // ff74h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@273 PS1, Line 273: uint64_t Rbx; // ff74h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@274 PS1, Line 274: uint64_t Rsp; // ff7ch : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@274 PS1, Line 274: uint64_t Rsp; // ff7ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@275 PS1, Line 275: uint64_t Rbp; // ff84h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@275 PS1, Line 275: uint64_t Rbp; // ff84h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@276 PS1, Line 276: uint64_t Rsi; // ff8ch : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@276 PS1, Line 276: uint64_t Rsi; // ff8ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@277 PS1, Line 277: uint64_t Rdi; // ff94h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@277 PS1, Line 277: uint64_t Rdi; // ff94h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@278 PS1, Line 278: uint64_t IOMemAddr; // ff9ch : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@278 PS1, Line 278: uint64_t IOMemAddr; // ff9ch : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@279 PS1, Line 279: uint32_t IOMisc; // ffa4h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@279 PS1, Line 279: uint32_t IOMisc; // ffa4h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@280 PS1, Line 280: uint32_t Es; // ffa8h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@280 PS1, Line 280: uint32_t Es; // ffa8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@281 PS1, Line 281: uint32_t Cs; // ffach : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@281 PS1, Line 281: uint32_t Cs; // ffach : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@282 PS1, Line 282: uint32_t Ss; // ffb0h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@282 PS1, Line 282: uint32_t Ss; // ffb0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@283 PS1, Line 283: uint32_t Ds; // ffb4h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@283 PS1, Line 283: uint32_t Ds; // ffb4h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@284 PS1, Line 284: uint32_t Fs; // ffb8h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@284 PS1, Line 284: uint32_t Fs; // ffb8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@285 PS1, Line 285: uint32_t Gs; // ffbch : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@285 PS1, Line 285: uint32_t Gs; // ffbch : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@286 PS1, Line 286: uint32_t Ldtr; // ffc0h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@286 PS1, Line 286: uint32_t Ldtr; // ffc0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@287 PS1, Line 287: uint32_t Tr; // ffc4h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@287 PS1, Line 287: uint32_t Tr; // ffc4h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@288 PS1, Line 288: uint64_t Dr7; // ffc8h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@288 PS1, Line 288: uint64_t Dr7; // ffc8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@289 PS1, Line 289: uint64_t Dr6; // ffd0h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@289 PS1, Line 289: uint64_t Dr6; // ffd0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@290 PS1, Line 290: uint64_t Rip; // ffd8h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@290 PS1, Line 290: uint64_t Rip; // ffd8h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@291 PS1, Line 291: uint64_t Ia32Efer; // ffe0h : YES - NO for STM trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@291 PS1, Line 291: uint64_t Ia32Efer; // ffe0h : YES - NO for STM line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@291 PS1, Line 291: uint64_t Ia32Efer; // ffe0h : YES - NO for STM please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@292 PS1, Line 292: uint64_t Rflags; // ffe8h : YES trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@292 PS1, Line 292: uint64_t Rflags; // ffe8h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@293 PS1, Line 293: uint64_t Cr3; // fff0h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@293 PS1, Line 293: uint64_t Cr3; // fff0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@294 PS1, Line 294: uint64_t Cr0; // fff8h : NO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@294 PS1, Line 294: uint64_t Cr0; // fff8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@295 PS1, Line 295: } STM_SMM_CPU_STATE; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@296 PS1, Line 296: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@297 PS1, Line 297: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@298 PS1, Line 298: // STM Mapping trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@299 PS1, Line 299: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@300 PS1, Line 300: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@301 PS1, Line 301: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@302 PS1, Line 302: uint64_t PhysicalAddress; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@302 PS1, Line 302: uint64_t PhysicalAddress; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@303 PS1, Line 303: uint64_t VirtualAddress; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@303 PS1, Line 303: uint64_t VirtualAddress; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@304 PS1, Line 304: uint32_t PageCount; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@304 PS1, Line 304: uint32_t PageCount; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@305 PS1, Line 305: uint32_t PatCacheType; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@305 PS1, Line 305: uint32_t PatCacheType; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@306 PS1, Line 306: } STM_MAP_ADDRESS_RANGE_DESCRIPTOR; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@307 PS1, Line 307: #define ST_UC 0x00 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@308 PS1, Line 308: #define WC 0x01 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@309 PS1, Line 309: #define WT 0x04 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@310 PS1, Line 310: #define WP 0x05 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@311 PS1, Line 311: #define WB 0x06 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@312 PS1, Line 312: #define UC 0x07 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@313 PS1, Line 313: #define FOLLOW_MTRR 0xFFFFFFFF DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@314 PS1, Line 314: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@315 PS1, Line 315: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@316 PS1, Line 316: uint64_t VirtualAddress; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@316 PS1, Line 316: uint64_t VirtualAddress; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@317 PS1, Line 317: uint32_t Length; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@317 PS1, Line 317: uint32_t Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@318 PS1, Line 318: } STM_UNMAP_ADDRESS_RANGE_DESCRIPTOR; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@319 PS1, Line 319: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@320 PS1, Line 320: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@321 PS1, Line 321: uint64_t InterruptedGuestVirtualAddress; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@321 PS1, Line 321: uint64_t InterruptedGuestVirtualAddress; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@322 PS1, Line 322: uint32_t Length; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@322 PS1, Line 322: uint32_t Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@323 PS1, Line 323: uint64_t InterruptedCr3; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@323 PS1, Line 323: uint64_t InterruptedCr3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@324 PS1, Line 324: uint64_t InterruptedEptp; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@324 PS1, Line 324: uint64_t InterruptedEptp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@325 PS1, Line 325: uint32_t MapToSmmGuest:2; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@325 PS1, Line 325: uint32_t MapToSmmGuest:2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@326 PS1, Line 326: uint32_t InterruptedCr4Pae:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@326 PS1, Line 326: uint32_t InterruptedCr4Pae:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@327 PS1, Line 327: uint32_t InterruptedCr4Pse:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@327 PS1, Line 327: uint32_t InterruptedCr4Pse:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@328 PS1, Line 328: uint32_t InterruptedIa32eMode:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@328 PS1, Line 328: uint32_t InterruptedIa32eMode:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@329 PS1, Line 329: uint32_t Reserved1:27; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@329 PS1, Line 329: uint32_t Reserved1:27; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@330 PS1, Line 330: uint32_t Reserved2; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@330 PS1, Line 330: uint32_t Reserved2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@331 PS1, Line 331: uint64_t PhysicalAddress; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@331 PS1, Line 331: uint64_t PhysicalAddress; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@332 PS1, Line 332: uint64_t SmmGuestVirtualAddress; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@332 PS1, Line 332: uint64_t SmmGuestVirtualAddress; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@333 PS1, Line 333: } STM_ADDRESS_LOOKUP_DESCRIPTOR; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@334 PS1, Line 334: #define DO_NOT_MAP 0 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@335 PS1, Line 335: #define ONE_TO_ONE 1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@336 PS1, Line 336: #define VIRTUAL_ADDRESS_SPECIFIED 3 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@337 PS1, Line 337: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@338 PS1, Line 338: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@339 PS1, Line 339: // STM_RESOURCE_LIST trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@340 PS1, Line 340: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@341 PS1, Line 341: #define END_OF_RESOURCES 0 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@342 PS1, Line 342: #define MEM_RANGE 1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@343 PS1, Line 343: #define IO_RANGE 2 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@344 PS1, Line 344: #define MMIO_RANGE 3 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@345 PS1, Line 345: #define MACHINE_SPECIFIC_REG 4 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@346 PS1, Line 346: #define PCI_CFG_RANGE 5 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@347 PS1, Line 347: #define TRAPPED_IO_RANGE 6 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@348 PS1, Line 348: #define ALL_RESOURCES 7 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@349 PS1, Line 349: #define REGISTER_VIOLATION 8 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@350 PS1, Line 350: #define MAX_DESC_TYPE 8 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@351 PS1, Line 351: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@352 PS1, Line 352: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@353 PS1, Line 353: uint32_t RscType; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@353 PS1, Line 353: uint32_t RscType; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@354 PS1, Line 354: uint16_t Length; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@354 PS1, Line 354: uint16_t Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@355 PS1, Line 355: uint16_t ReturnStatus:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@355 PS1, Line 355: uint16_t ReturnStatus:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@356 PS1, Line 356: uint16_t Reserved:14; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@356 PS1, Line 356: uint16_t Reserved:14; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@357 PS1, Line 357: uint16_t IgnoreResource:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@357 PS1, Line 357: uint16_t IgnoreResource:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@358 PS1, Line 358: } STM_RSC_DESC_HEADER; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@359 PS1, Line 359: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@360 PS1, Line 360: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@361 PS1, Line 361: STM_RSC_DESC_HEADER Hdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@361 PS1, Line 361: STM_RSC_DESC_HEADER Hdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@362 PS1, Line 362: uint64_t ResourceListContinuation; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@362 PS1, Line 362: uint64_t ResourceListContinuation; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@363 PS1, Line 363: } STM_RSC_END; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@364 PS1, Line 364: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@365 PS1, Line 365: // byte granular Memory range support trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@366 PS1, Line 366: #define STM_RSC_BGM 0x4 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@367 PS1, Line 367: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@368 PS1, Line 368: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@369 PS1, Line 369: STM_RSC_DESC_HEADER Hdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@369 PS1, Line 369: STM_RSC_DESC_HEADER Hdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@370 PS1, Line 370: uint64_t Base; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@370 PS1, Line 370: uint64_t Base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@371 PS1, Line 371: uint64_t Length; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@371 PS1, Line 371: uint64_t Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@372 PS1, Line 372: uint32_t RWXAttributes:3; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@372 PS1, Line 372: uint32_t RWXAttributes:3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@373 PS1, Line 373: uint32_t Reserved:29; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@373 PS1, Line 373: uint32_t Reserved:29; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@374 PS1, Line 374: uint32_t Reserved_2; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@374 PS1, Line 374: uint32_t Reserved_2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@375 PS1, Line 375: } STM_RSC_MEM_DESC; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@376 PS1, Line 376: #define STM_RSC_MEM_R 0x1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@377 PS1, Line 377: #define STM_RSC_MEM_W 0x2 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@378 PS1, Line 378: #define STM_RSC_MEM_X 0x4 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@379 PS1, Line 379: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@380 PS1, Line 380: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@381 PS1, Line 381: STM_RSC_DESC_HEADER Hdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@381 PS1, Line 381: STM_RSC_DESC_HEADER Hdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@382 PS1, Line 382: uint16_t Base; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@382 PS1, Line 382: uint16_t Base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@383 PS1, Line 383: uint16_t Length; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@383 PS1, Line 383: uint16_t Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@384 PS1, Line 384: uint32_t Reserved; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@384 PS1, Line 384: uint32_t Reserved; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@385 PS1, Line 385: } STM_RSC_IO_DESC; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@386 PS1, Line 386: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@387 PS1, Line 387: // byte granular MMIO range support trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@388 PS1, Line 388: #define STM_RSC_BGI 0x2 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@389 PS1, Line 389: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@390 PS1, Line 390: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@391 PS1, Line 391: STM_RSC_DESC_HEADER Hdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@391 PS1, Line 391: STM_RSC_DESC_HEADER Hdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@392 PS1, Line 392: uint64_t Base; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@392 PS1, Line 392: uint64_t Base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@393 PS1, Line 393: uint64_t Length; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@393 PS1, Line 393: uint64_t Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@394 PS1, Line 394: uint32_t RWXAttributes:3; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@394 PS1, Line 394: uint32_t RWXAttributes:3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@395 PS1, Line 395: uint32_t Reserved:29; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@395 PS1, Line 395: uint32_t Reserved:29; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@396 PS1, Line 396: uint32_t Reserved_2; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@396 PS1, Line 396: uint32_t Reserved_2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@397 PS1, Line 397: } STM_RSC_MMIO_DESC; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@398 PS1, Line 398: #define STM_RSC_MMIO_R 0x1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@399 PS1, Line 399: #define STM_RSC_MMIO_W 0x2 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@400 PS1, Line 400: #define STM_RSC_MMIO_X 0x4 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@401 PS1, Line 401: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@402 PS1, Line 402: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@403 PS1, Line 403: STM_RSC_DESC_HEADER Hdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@403 PS1, Line 403: STM_RSC_DESC_HEADER Hdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@404 PS1, Line 404: uint32_t MsrIndex; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@404 PS1, Line 404: uint32_t MsrIndex; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@405 PS1, Line 405: uint32_t KernelModeProcessing:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@405 PS1, Line 405: uint32_t KernelModeProcessing:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@406 PS1, Line 406: uint32_t Reserved:31; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@406 PS1, Line 406: uint32_t Reserved:31; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@407 PS1, Line 407: uint64_t ReadMask; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@407 PS1, Line 407: uint64_t ReadMask; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@408 PS1, Line 408: uint64_t WriteMask; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@408 PS1, Line 408: uint64_t WriteMask; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@409 PS1, Line 409: } STM_RSC_MSR_DESC; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@410 PS1, Line 410: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@411 PS1, Line 411: // bit granular MSR resource support trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@412 PS1, Line 412: #define STM_RSC_MSR 0x8 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@413 PS1, Line 413: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@414 PS1, Line 414: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@415 PS1, Line 415: uint8_t Type; // must be 1, indicating Hardware Device Path trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@415 PS1, Line 415: uint8_t Type; // must be 1, indicating Hardware Device Path please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@416 PS1, Line 416: uint8_t Subtype; // must be 1, indicating PCI trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@416 PS1, Line 416: uint8_t Subtype; // must be 1, indicating PCI please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@417 PS1, Line 417: uint16_t Length; // sizeof(STM_PCI_DEVICE_PATH_NODE) which is 6 trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@417 PS1, Line 417: uint16_t Length; // sizeof(STM_PCI_DEVICE_PATH_NODE) which is 6 please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@418 PS1, Line 418: uint8_t PciFunction; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@418 PS1, Line 418: uint8_t PciFunction; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@419 PS1, Line 419: uint8_t PciDevice; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@419 PS1, Line 419: uint8_t PciDevice; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@420 PS1, Line 420: } STM_PCI_DEVICE_PATH_NODE; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@421 PS1, Line 421: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@422 PS1, Line 422: STM_RSC_DESC_HEADER Hdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@422 PS1, Line 422: STM_RSC_DESC_HEADER Hdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@423 PS1, Line 423: uint16_t RWAttributes:2; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@423 PS1, Line 423: uint16_t RWAttributes:2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@424 PS1, Line 424: uint16_t Reserved:14; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@424 PS1, Line 424: uint16_t Reserved:14; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@425 PS1, Line 425: uint16_t Base; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@425 PS1, Line 425: uint16_t Base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@426 PS1, Line 426: uint16_t Length; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@426 PS1, Line 426: uint16_t Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@427 PS1, Line 427: uint8_t OriginatingBusNumber; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@427 PS1, Line 427: uint8_t OriginatingBusNumber; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@428 PS1, Line 428: uint8_t LastNodeIndex; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@428 PS1, Line 428: uint8_t LastNodeIndex; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@429 PS1, Line 429: STM_PCI_DEVICE_PATH_NODE PciDevicePath[1]; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@429 PS1, Line 429: STM_PCI_DEVICE_PATH_NODE PciDevicePath[1]; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@430 PS1, Line 430: //STM_PCI_DEVICE_PATH_NODE PciDevicePath[LastNodeIndex + 1]; trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@431 PS1, Line 431: } STM_RSC_PCI_CFG_DESC; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@432 PS1, Line 432: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@433 PS1, Line 433: #define STM_RSC_PCI_CFG_R 0x1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@434 PS1, Line 434: #define STM_RSC_PCI_CFG_W 0x2 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@435 PS1, Line 435: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@436 PS1, Line 436: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@437 PS1, Line 437: STM_RSC_DESC_HEADER Hdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@437 PS1, Line 437: STM_RSC_DESC_HEADER Hdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@438 PS1, Line 438: uint16_t Base; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@438 PS1, Line 438: uint16_t Base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@439 PS1, Line 439: uint16_t Length; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@439 PS1, Line 439: uint16_t Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@440 PS1, Line 440: uint16_t In:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@440 PS1, Line 440: uint16_t In:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@441 PS1, Line 441: uint16_t Out:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@441 PS1, Line 441: uint16_t Out:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@442 PS1, Line 442: uint16_t Api:1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@442 PS1, Line 442: uint16_t Api:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@443 PS1, Line 443: uint16_t Reserved1:13; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@443 PS1, Line 443: uint16_t Reserved1:13; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@444 PS1, Line 444: uint16_t Reserved2; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@444 PS1, Line 444: uint16_t Reserved2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@445 PS1, Line 445: } STM_RSC_TRAPPED_IO_DESC; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@446 PS1, Line 446: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@447 PS1, Line 447: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@448 PS1, Line 448: STM_RSC_DESC_HEADER Hdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@448 PS1, Line 448: STM_RSC_DESC_HEADER Hdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@449 PS1, Line 449: } STM_RSC_ALL_RESOURCES_DESC; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@450 PS1, Line 450: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@451 PS1, Line 451: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@452 PS1, Line 452: STM_RSC_DESC_HEADER Hdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@452 PS1, Line 452: STM_RSC_DESC_HEADER Hdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@453 PS1, Line 453: uint32_t RegisterType; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@453 PS1, Line 453: uint32_t RegisterType; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@454 PS1, Line 454: uint32_t Reserved; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@454 PS1, Line 454: uint32_t Reserved; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@455 PS1, Line 455: uint64_t ReadMask; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@455 PS1, Line 455: uint64_t ReadMask; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@456 PS1, Line 456: uint64_t WriteMask; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@456 PS1, Line 456: uint64_t WriteMask; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@457 PS1, Line 457: } STM_REGISTER_VIOLATION_DESC; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@458 PS1, Line 458: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@459 PS1, Line 459: typedef enum { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@460 PS1, Line 460: StmRegisterCr0, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@460 PS1, Line 460: StmRegisterCr0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@461 PS1, Line 461: StmRegisterCr2, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@461 PS1, Line 461: StmRegisterCr2, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@462 PS1, Line 462: StmRegisterCr3, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@462 PS1, Line 462: StmRegisterCr3, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@463 PS1, Line 463: StmRegisterCr4, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@463 PS1, Line 463: StmRegisterCr4, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@464 PS1, Line 464: StmRegisterCr8, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@464 PS1, Line 464: StmRegisterCr8, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@465 PS1, Line 465: StmRegisterMax, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@465 PS1, Line 465: StmRegisterMax, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@466 PS1, Line 466: } STM_REGISTER_VIOLATION_TYPE; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@467 PS1, Line 467: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@468 PS1, Line 468: typedef union { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@469 PS1, Line 469: STM_RSC_DESC_HEADER Header; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@469 PS1, Line 469: STM_RSC_DESC_HEADER Header; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@470 PS1, Line 470: STM_RSC_END End; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@470 PS1, Line 470: STM_RSC_END End; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@471 PS1, Line 471: STM_RSC_MEM_DESC Mem; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@471 PS1, Line 471: STM_RSC_MEM_DESC Mem; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@472 PS1, Line 472: STM_RSC_IO_DESC Io; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@472 PS1, Line 472: STM_RSC_IO_DESC Io; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@473 PS1, Line 473: STM_RSC_MMIO_DESC Mmio; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@473 PS1, Line 473: STM_RSC_MMIO_DESC Mmio; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@474 PS1, Line 474: STM_RSC_MSR_DESC Msr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@474 PS1, Line 474: STM_RSC_MSR_DESC Msr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@475 PS1, Line 475: STM_RSC_PCI_CFG_DESC PciCfg; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@475 PS1, Line 475: STM_RSC_PCI_CFG_DESC PciCfg; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@476 PS1, Line 476: STM_RSC_TRAPPED_IO_DESC TrappedIo; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@476 PS1, Line 476: STM_RSC_TRAPPED_IO_DESC TrappedIo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@477 PS1, Line 477: STM_RSC_ALL_RESOURCES_DESC All; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@477 PS1, Line 477: STM_RSC_ALL_RESOURCES_DESC All; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@478 PS1, Line 478: STM_REGISTER_VIOLATION_DESC RegisterViolation; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@478 PS1, Line 478: STM_REGISTER_VIOLATION_DESC RegisterViolation; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@479 PS1, Line 479: } STM_RSC; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@480 PS1, Line 480: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@481 PS1, Line 481: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@482 PS1, Line 482: // VMCS database trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@483 PS1, Line 483: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@484 PS1, Line 484: #define STM_VMCS_DATABASE_REQUEST_ADD 1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@485 PS1, Line 485: #define STM_VMCS_DATABASE_REQUEST_REMOVE 0 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@486 PS1, Line 486: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@487 PS1, Line 487: // Values for DomainType trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@488 PS1, Line 488: // Intepreter of DomainType trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@489 PS1, Line 489: #define DOMAIN_DISALLOWED_IO_OUT (1u << 0) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@490 PS1, Line 490: #define DOMAIN_DISALLOWED_IO_IN (1u << 1) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@491 PS1, Line 491: #define DOMAIN_INTEGRITY (1u << 2) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@492 PS1, Line 492: #define DOMAIN_CONFIDENTIALITY (1u << 3) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@493 PS1, Line 493: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@494 PS1, Line 494: #define DOMAIN_UNPROTECTED 0x00 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@495 PS1, Line 495: #define DOMAIN_INTEGRITY_PROT_OUT_IN (DOMAIN_INTEGRITY) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@496 PS1, Line 496: //#define DOMAIN_INTEGRITY_PROT_OUT (DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN) trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@496 PS1, Line 496: //#define DOMAIN_INTEGRITY_PROT_OUT (DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN) line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@497 PS1, Line 497: #define DOMAIN_FULLY_PROT_OUT_IN (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@497 PS1, Line 497: #define DOMAIN_FULLY_PROT_OUT_IN (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY) line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@498 PS1, Line 498: //#define DOMAIN_FULLY_PROT_IN (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_OUT) trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@498 PS1, Line 498: //#define DOMAIN_FULLY_PROT_IN (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_OUT) line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@499 PS1, Line 499: //#define DOMAIN_FULLY_PROT_OUT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN) trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@499 PS1, Line 499: //#define DOMAIN_FULLY_PROT_OUT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN) line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@500 PS1, Line 500: #define DOMAIN_FULLY_PROT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN | DOMAIN_DISALLOWED_IO_OUT) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@500 PS1, Line 500: #define DOMAIN_FULLY_PROT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN | DOMAIN_DISALLOWED_IO_OUT) line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@501 PS1, Line 501: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@502 PS1, Line 502: // Values for XStatePolicy trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@503 PS1, Line 503: #define XSTATE_READWRITE 0x00 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@504 PS1, Line 504: #define XSTATE_READONLY 0x01 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@505 PS1, Line 505: #define XSTATE_SCRUB 0x03 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@506 PS1, Line 506: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@507 PS1, Line 507: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@508 PS1, Line 508: uint64_t VmcsPhysPointer; // bits 11:0 are reserved and must be 0 trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@508 PS1, Line 508: uint64_t VmcsPhysPointer; // bits 11:0 are reserved and must be 0 please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@509 PS1, Line 509: uint32_t DomainType :4; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@509 PS1, Line 509: uint32_t DomainType :4; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@510 PS1, Line 510: uint32_t XStatePolicy :2; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@510 PS1, Line 510: uint32_t XStatePolicy :2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@511 PS1, Line 511: uint32_t DegradationPolicy :4; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@511 PS1, Line 511: uint32_t DegradationPolicy :4; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@512 PS1, Line 512: uint32_t Reserved1 :22; // Must be 0 trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@512 PS1, Line 512: uint32_t Reserved1 :22; // Must be 0 please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@513 PS1, Line 513: uint32_t AddOrRemove; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@513 PS1, Line 513: uint32_t AddOrRemove; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@514 PS1, Line 514: } STM_VMCS_DATABASE_REQUEST; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@515 PS1, Line 515: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@516 PS1, Line 516: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@517 PS1, Line 517: // Event log trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@518 PS1, Line 518: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@519 PS1, Line 519: #define NEW_LOG 1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@520 PS1, Line 520: #define CONFIGURE_LOG 2 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@521 PS1, Line 521: #define START_LOG 3 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@522 PS1, Line 522: #define STOP_LOG 4 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@523 PS1, Line 523: #define CLEAR_LOG 5 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@524 PS1, Line 524: #define DELETE_LOG 6 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@525 PS1, Line 525: typedef enum { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@526 PS1, Line 526: EvtLogStarted, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@526 PS1, Line 526: EvtLogStarted, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@527 PS1, Line 527: EvtLogStopped, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@527 PS1, Line 527: EvtLogStopped, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@528 PS1, Line 528: EvtLogInvalidParameterDetected, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@528 PS1, Line 528: EvtLogInvalidParameterDetected, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@529 PS1, Line 529: EvtHandledProtectionException, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@529 PS1, Line 529: EvtHandledProtectionException, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@530 PS1, Line 530: // unhandled protection exceptions result in reset & cannot be logged trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@531 PS1, Line 531: EvtBiosAccessToUnclaimedResource, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@531 PS1, Line 531: EvtBiosAccessToUnclaimedResource, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@532 PS1, Line 532: EvtMleResourceProtectionGranted, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@532 PS1, Line 532: EvtMleResourceProtectionGranted, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@533 PS1, Line 533: EvtMleResourceProtectionDenied, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@533 PS1, Line 533: EvtMleResourceProtectionDenied, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@534 PS1, Line 534: EvtMleResourceUnprotect, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@534 PS1, Line 534: EvtMleResourceUnprotect, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@535 PS1, Line 535: EvtMleResourceUnprotectError, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@535 PS1, Line 535: EvtMleResourceUnprotectError, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@536 PS1, Line 536: EvtMleDomainTypeDegraded, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@536 PS1, Line 536: EvtMleDomainTypeDegraded, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@537 PS1, Line 537: // add more here trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@538 PS1, Line 538: EvtMleMax, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@538 PS1, Line 538: EvtMleMax, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@539 PS1, Line 539: // Not used trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@540 PS1, Line 540: EvtInvalid = 0xFFFFFFFF, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@540 PS1, Line 540: EvtInvalid = 0xFFFFFFFF, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@541 PS1, Line 541: } EVENT_TYPE; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@542 PS1, Line 542: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@543 PS1, Line 543: //#define STM_EVENT_LOG_PAGE_COUNT_MAX 62 trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@544 PS1, Line 544: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@545 PS1, Line 545: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@546 PS1, Line 546: uint32_t PageCount; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@546 PS1, Line 546: uint32_t PageCount; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@547 PS1, Line 547: uint64_t Pages[1]; // number of elements is PageCount trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@547 PS1, Line 547: uint64_t Pages[1]; // number of elements is PageCount please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@548 PS1, Line 548: } STM_EVENT_LOG_MANAGEMENT_REQUEST_DATA_LOG_BUFFER; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@549 PS1, Line 549: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@550 PS1, Line 550: typedef union { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@551 PS1, Line 551: STM_EVENT_LOG_MANAGEMENT_REQUEST_DATA_LOG_BUFFER LogBuffer; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@551 PS1, Line 551: STM_EVENT_LOG_MANAGEMENT_REQUEST_DATA_LOG_BUFFER LogBuffer; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@552 PS1, Line 552: uint32_t EventEnableBitmap; // bitmap of EVENT_TYPE trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@552 PS1, Line 552: uint32_t EventEnableBitmap; // bitmap of EVENT_TYPE line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@552 PS1, Line 552: uint32_t EventEnableBitmap; // bitmap of EVENT_TYPE please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@553 PS1, Line 553: } STM_EVENT_LOG_MANAGEMENT_REQUEST_DATA; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@554 PS1, Line 554: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@555 PS1, Line 555: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@556 PS1, Line 556: uint32_t SubFunctionIndex; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@556 PS1, Line 556: uint32_t SubFunctionIndex; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@557 PS1, Line 557: STM_EVENT_LOG_MANAGEMENT_REQUEST_DATA Data; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@557 PS1, Line 557: STM_EVENT_LOG_MANAGEMENT_REQUEST_DATA Data; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@558 PS1, Line 558: } STM_EVENT_LOG_MANAGEMENT_REQUEST; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@559 PS1, Line 559: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@560 PS1, Line 560: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@561 PS1, Line 561: // VMCALL API Numbers trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@562 PS1, Line 562: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@563 PS1, Line 563: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@564 PS1, Line 564: // API number convention: BIOS facing VMCALL interfaces have bit 16 clear trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@565 PS1, Line 565: #define STM_API_MAP_ADDRESS_RANGE 0x00000001 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@566 PS1, Line 566: #define STM_API_UNMAP_ADDRESS_RANGE 0x00000002 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@567 PS1, Line 567: #define STM_API_ADDRESS_LOOKUP 0x00000003 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@568 PS1, Line 568: #define STM_API_RETURN_FROM_PROTECTION_EXCEPTION 0x00000004 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@569 PS1, Line 569: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@570 PS1, Line 570: // API number convention: MLE facing VMCALL interfaces have bit 16 set trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@571 PS1, Line 571: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@572 PS1, Line 572: // The STM configuration lifecycle is as follows: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@573 PS1, Line 573: // 1. SENTER->SINIT->MLE: MLE begins execution with SMI disabled (masked). trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@574 PS1, Line 574: // 2. MLE invokes InitializeProtectionVMCALL() to prepare STM for setup of initial protection profile. This is done on a single CPU and has global effect. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@574 PS1, Line 574: // 2. MLE invokes InitializeProtectionVMCALL() to prepare STM for setup of initial protection profile. This is done on a single CPU and has global effect. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@575 PS1, Line 575: // 3. MLE invokes ProtectResourceVMCALL() to define the initial protection profile. The protection profile is global across all CPUs. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@575 PS1, Line 575: // 3. MLE invokes ProtectResourceVMCALL() to define the initial protection profile. The protection profile is global across all CPUs. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@576 PS1, Line 576: // 4. MLE invokes StartStmVMCALL() to enable the STM to begin receiving SMI events. This must be done on every logical CPU. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@576 PS1, Line 576: // 4. MLE invokes StartStmVMCALL() to enable the STM to begin receiving SMI events. This must be done on every logical CPU. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@577 PS1, Line 577: // 5. MLE may invoke ProtectResourceVMCALL() or UnProtectResourceVMCALL() during runtime as many times as necessary. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@577 PS1, Line 577: // 5. MLE may invoke ProtectResourceVMCALL() or UnProtectResourceVMCALL() during runtime as many times as necessary. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@578 PS1, Line 578: // 6. MLE invokes StopStmVMCALL() to disable the STM. SMI is again masked following StopStmVMCALL(). trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@578 PS1, Line 578: // 6. MLE invokes StopStmVMCALL() to disable the STM. SMI is again masked following StopStmVMCALL(). line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@579 PS1, Line 579: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@580 PS1, Line 580: #define STM_API_START 0x00010001 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@581 PS1, Line 581: #define STM_API_STOP 0x00010002 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@582 PS1, Line 582: #define STM_API_PROTECT_RESOURCE 0x00010003 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@583 PS1, Line 583: #define STM_API_UNPROTECT_RESOURCE 0x00010004 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@584 PS1, Line 584: #define STM_API_GET_BIOS_RESOURCES 0x00010005 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@585 PS1, Line 585: #define STM_API_MANAGE_VMCS_DATABASE 0x00010006 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@586 PS1, Line 586: #define STM_API_INITIALIZE_PROTECTION 0x00010007 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@587 PS1, Line 587: #define STM_API_MANAGE_EVENT_LOG 0x00010008 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@588 PS1, Line 588: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@589 PS1, Line 589: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@590 PS1, Line 590: // Return codes trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@591 PS1, Line 591: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@592 PS1, Line 592: typedef uint32_t STM_STATUS; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@593 PS1, Line 593: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@594 PS1, Line 594: #define STM_SUCCESS 0x00000000 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@595 PS1, Line 595: #define SMM_SUCCESS 0x00000000 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@596 PS1, Line 596: // all error codes have bit 31 set trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@597 PS1, Line 597: // STM errors have bit 16 set trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@598 PS1, Line 598: #define ERROR_STM_SECURITY_VIOLATION 0x80010001 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@599 PS1, Line 599: #define ERROR_STM_CACHE_TYPE_NOT_SUPPORTED 0x80010002 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@600 PS1, Line 600: #define ERROR_STM_PAGE_NOT_FOUND 0x80010003 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@601 PS1, Line 601: #define ERROR_STM_BAD_CR3 0x80010004 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@602 PS1, Line 602: #define ERROR_STM_PHYSICAL_OVER_4G 0x80010005 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@603 PS1, Line 603: #define ERROR_STM_VIRTUAL_SPACE_TOO_SMALL 0x80010006 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@604 PS1, Line 604: #define ERROR_STM_UNPROTECTABLE_RESOURCE 0x80010007 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@605 PS1, Line 605: #define ERROR_STM_ALREADY_STARTED 0x80010008 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@606 PS1, Line 606: #define ERROR_STM_WITHOUT_SMX_UNSUPPORTED 0x80010009 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@607 PS1, Line 607: #define ERROR_STM_STOPPED 0x8001000A DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@608 PS1, Line 608: #define ERROR_STM_BUFFER_TOO_SMALL 0x8001000B DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@609 PS1, Line 609: #define ERROR_STM_INVALID_VMCS_DATABASE 0x8001000C DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@610 PS1, Line 610: #define ERROR_STM_MALFORMED_RESOURCE_LIST 0x8001000D DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@611 PS1, Line 611: #define ERROR_STM_INVALID_PAGECOUNT 0x8001000E DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@612 PS1, Line 612: #define ERROR_STM_LOG_ALLOCATED 0x8001000F DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@613 PS1, Line 613: #define ERROR_STM_LOG_NOT_ALLOCATED 0x80010010 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@614 PS1, Line 614: #define ERROR_STM_LOG_NOT_STOPPED 0x80010011 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@615 PS1, Line 615: #define ERROR_STM_LOG_NOT_STARTED 0x80010012 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@616 PS1, Line 616: #define ERROR_STM_RESERVED_BIT_SET 0x80010013 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@617 PS1, Line 617: #define ERROR_STM_NO_EVENTS_ENABLED 0x80010014 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@618 PS1, Line 618: #define ERROR_STM_OUT_OF_RESOURCES 0x80010015 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@619 PS1, Line 619: #define ERROR_STM_FUNCTION_NOT_SUPPORTED 0x80010016 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@620 PS1, Line 620: #define ERROR_STM_UNPROTECTABLE 0x80010017 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@621 PS1, Line 621: #define ERROR_STM_UNSUPPORTED_MSR_BIT 0x80010018 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@622 PS1, Line 622: #define ERROR_STM_UNSPECIFIED 0x8001FFFF DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@623 PS1, Line 623: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@624 PS1, Line 624: // SMM errors have bit 17 set trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@625 PS1, Line 625: #define ERROR_SMM_BAD_BUFFER 0x80020001 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@626 PS1, Line 626: #define ERROR_SMM_INVALID_RSC 0x80020004 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@627 PS1, Line 627: #define ERROR_SMM_INVALID_BUFFER_SIZE 0x80020005 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@628 PS1, Line 628: #define ERROR_SMM_BUFFER_TOO_SHORT 0x80020006 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@629 PS1, Line 629: #define ERROR_SMM_INVALID_LIST 0x80020007 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@630 PS1, Line 630: #define ERROR_SMM_OUT_OF_MEMORY 0x80020008 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@631 PS1, Line 631: #define ERROR_SMM_AFTER_INIT 0x80020009 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@632 PS1, Line 632: #define ERROR_SMM_UNSPECIFIED 0x8002FFFF DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@633 PS1, Line 633: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@634 PS1, Line 634: // Errors that apply to both have bits 15, 16, and 17 set trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@635 PS1, Line 635: #define ERROR_INVALID_API 0x80038001 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@636 PS1, Line 636: #define ERROR_INVALID_PARAMETER 0x80038002 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@637 PS1, Line 637: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@638 PS1, Line 638: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@639 PS1, Line 639: // STM TXT.ERRORCODE codes trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@640 PS1, Line 640: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@641 PS1, Line 641: #define STM_CRASH_PROTECTION_EXCEPTION 0xC000F001 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@642 PS1, Line 642: #define STM_CRASH_PROTECTION_EXCEPTION_FAILURE 0xC000F002 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@643 PS1, Line 643: #define STM_CRASH_DOMAIN_DEGRADATION_FAILURE 0xC000F003 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@644 PS1, Line 644: #define STM_CRASH_BIOS_PANIC 0xC000E000 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@645 PS1, Line 645: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@646 PS1, Line 646: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@647 PS1, Line 647: uint32_t EventSerialNumber; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@647 PS1, Line 647: uint32_t EventSerialNumber; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@648 PS1, Line 648: uint16_t Type; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@648 PS1, Line 648: uint16_t Type; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@649 PS1, Line 649: uint16_t Lock :1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@649 PS1, Line 649: uint16_t Lock :1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@650 PS1, Line 650: uint16_t Valid :1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@650 PS1, Line 650: uint16_t Valid :1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@651 PS1, Line 651: uint16_t ReadByMle :1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@651 PS1, Line 651: uint16_t ReadByMle :1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@652 PS1, Line 652: uint16_t Wrapped :1; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@652 PS1, Line 652: uint16_t Wrapped :1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@653 PS1, Line 653: uint16_t Reserved :12; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@653 PS1, Line 653: uint16_t Reserved :12; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@654 PS1, Line 654: } LOG_ENTRY_HEADER; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@655 PS1, Line 655: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@656 PS1, Line 656: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@657 PS1, Line 657: uint32_t Reserved; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@657 PS1, Line 657: uint32_t Reserved; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@658 PS1, Line 658: } ENTRY_EVT_LOG_STARTED; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@659 PS1, Line 659: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@660 PS1, Line 660: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@661 PS1, Line 661: uint32_t Reserved; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@661 PS1, Line 661: uint32_t Reserved; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@662 PS1, Line 662: } ENTRY_EVT_LOG_STOPPED; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@663 PS1, Line 663: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@664 PS1, Line 664: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@665 PS1, Line 665: uint32_t VmcallApiNumber; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@665 PS1, Line 665: uint32_t VmcallApiNumber; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@666 PS1, Line 666: } ENTRY_EVT_LOG_INVALID_PARAM; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@667 PS1, Line 667: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@668 PS1, Line 668: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@669 PS1, Line 669: STM_RSC Resource; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@669 PS1, Line 669: STM_RSC Resource; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@670 PS1, Line 670: } ENTRY_EVT_LOG_HANDLED_PROTECTION_EXCEPTION; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@671 PS1, Line 671: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@672 PS1, Line 672: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@673 PS1, Line 673: STM_RSC Resource; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@673 PS1, Line 673: STM_RSC Resource; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@674 PS1, Line 674: } ENTRY_EVT_BIOS_ACCESS_UNCLAIMED_RSC; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@675 PS1, Line 675: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@676 PS1, Line 676: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@677 PS1, Line 677: STM_RSC Resource; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@677 PS1, Line 677: STM_RSC Resource; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@678 PS1, Line 678: } ENTRY_EVT_MLE_RSC_PROT_GRANTED; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@679 PS1, Line 679: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@680 PS1, Line 680: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@681 PS1, Line 681: STM_RSC Resource; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@681 PS1, Line 681: STM_RSC Resource; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@682 PS1, Line 682: } ENTRY_EVT_MLE_RSC_PROT_DENIED; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@683 PS1, Line 683: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@684 PS1, Line 684: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@685 PS1, Line 685: STM_RSC Resource; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@685 PS1, Line 685: STM_RSC Resource; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@686 PS1, Line 686: } ENTRY_EVT_MLE_RSC_UNPROT; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@687 PS1, Line 687: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@688 PS1, Line 688: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@689 PS1, Line 689: STM_RSC Resource; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@689 PS1, Line 689: STM_RSC Resource; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@690 PS1, Line 690: } ENTRY_EVT_MLE_RSC_UNPROT_ERROR; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@691 PS1, Line 691: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@692 PS1, Line 692: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@693 PS1, Line 693: uint64_t VmcsPhysPointer; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@693 PS1, Line 693: uint64_t VmcsPhysPointer; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@694 PS1, Line 694: uint8_t ExpectedDomainType; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@694 PS1, Line 694: uint8_t ExpectedDomainType; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@695 PS1, Line 695: uint8_t DegradedDomainType; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@695 PS1, Line 695: uint8_t DegradedDomainType; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@696 PS1, Line 696: } ENTRY_EVT_MLE_DOMAIN_TYPE_DEGRADED; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@697 PS1, Line 697: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@698 PS1, Line 698: typedef union { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@699 PS1, Line 699: ENTRY_EVT_LOG_STARTED Started; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@699 PS1, Line 699: ENTRY_EVT_LOG_STARTED Started; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@700 PS1, Line 700: ENTRY_EVT_LOG_STOPPED Stopped; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@700 PS1, Line 700: ENTRY_EVT_LOG_STOPPED Stopped; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@701 PS1, Line 701: ENTRY_EVT_LOG_INVALID_PARAM InvalidParam; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@701 PS1, Line 701: ENTRY_EVT_LOG_INVALID_PARAM InvalidParam; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@702 PS1, Line 702: ENTRY_EVT_LOG_HANDLED_PROTECTION_EXCEPTION HandledProtectionException; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@702 PS1, Line 702: ENTRY_EVT_LOG_HANDLED_PROTECTION_EXCEPTION HandledProtectionException; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@703 PS1, Line 703: ENTRY_EVT_BIOS_ACCESS_UNCLAIMED_RSC BiosUnclaimedRsc; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@703 PS1, Line 703: ENTRY_EVT_BIOS_ACCESS_UNCLAIMED_RSC BiosUnclaimedRsc; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@704 PS1, Line 704: ENTRY_EVT_MLE_RSC_PROT_GRANTED MleRscProtGranted; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@704 PS1, Line 704: ENTRY_EVT_MLE_RSC_PROT_GRANTED MleRscProtGranted; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@705 PS1, Line 705: ENTRY_EVT_MLE_RSC_PROT_DENIED MleRscProtDenied; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@705 PS1, Line 705: ENTRY_EVT_MLE_RSC_PROT_DENIED MleRscProtDenied; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@706 PS1, Line 706: ENTRY_EVT_MLE_RSC_UNPROT MleRscUnprot; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@706 PS1, Line 706: ENTRY_EVT_MLE_RSC_UNPROT MleRscUnprot; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@707 PS1, Line 707: ENTRY_EVT_MLE_RSC_UNPROT_ERROR MleRscUnprotError; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@707 PS1, Line 707: ENTRY_EVT_MLE_RSC_UNPROT_ERROR MleRscUnprotError; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@708 PS1, Line 708: ENTRY_EVT_MLE_DOMAIN_TYPE_DEGRADED MleDomainTypeDegraded; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@708 PS1, Line 708: ENTRY_EVT_MLE_DOMAIN_TYPE_DEGRADED MleDomainTypeDegraded; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@709 PS1, Line 709: } LOG_ENTRY_DATA; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@710 PS1, Line 710: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@711 PS1, Line 711: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@712 PS1, Line 712: LOG_ENTRY_HEADER Hdr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@712 PS1, Line 712: LOG_ENTRY_HEADER Hdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@713 PS1, Line 713: LOG_ENTRY_DATA Data; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@713 PS1, Line 713: LOG_ENTRY_DATA Data; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@714 PS1, Line 714: } STM_LOG_ENTRY; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@715 PS1, Line 715: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@716 PS1, Line 716: #define STM_LOG_ENTRY_SIZE 256 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@717 PS1, Line 717: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@718 PS1, Line 718: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@719 PS1, Line 719: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@720 PS1, Line 720: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@721 PS1, Line 721: #define STM_CONFIG_SMI_UNBLOCKING_BY_VMX_OFF 0x1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@722 PS1, Line 722: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@723 PS1, Line 723: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@724 PS1, Line 724: // TXT debug trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@725 PS1, Line 725: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@726 PS1, Line 726: #define SW_SMI_STM_ADD_RUNTIME_RESOURCES_SUB_FUNC 0 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@727 PS1, Line 727: #define SW_SMI_STM_READ_BIOS_RESOURCES_SUB_FUNC 1 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@728 PS1, Line 728: #define SW_SMI_STM_REPLACE_BIOS_RESOURCES_SUB_FUNC 2 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@729 PS1, Line 729: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@730 PS1, Line 730: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@731 PS1, Line 731: uint32_t BufferSize; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@731 PS1, Line 731: uint32_t BufferSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@732 PS1, Line 732: uint32_t Reserved; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@732 PS1, Line 732: uint32_t Reserved; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@733 PS1, Line 733: //uint8_t Data[]; trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@734 PS1, Line 734: } TXT_BIOS_DEBUG; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@735 PS1, Line 735: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@736 PS1, Line 736: #pragma pack (pop) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@736 PS1, Line 736: #pragma pack (pop) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@737 PS1, Line 737: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmApi.h@738 PS1, Line 738: #endif DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... File src/include/cpu/x86/StmPlatformResource.h:
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 1: /** @file trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 2: STM platform SMM resource trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 3: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 4: Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 5: This program and the accompanying materials trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 6: are licensed and made available under the terms and conditions of the BSD License trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 6: are licensed and made available under the terms and conditions of the BSD License line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 7: which accompanies this distribution. The full text of the license may be found at trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 7: which accompanies this distribution. The full text of the license may be found at line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 8: http://opensource.org/licenses/bsd-license.php. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 9: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 10: THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 11: WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 12: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 13: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 14: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 15: #ifndef _STM_PLATFORM_RESOURCE_H_ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 16: #define _STM_PLATFORM_RESOURCE_H_ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 17: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 18: #define MASK0 0 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 19: #define MASK64 0xFFFFFFFFFFFFFFFFull DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 20: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 21: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 22: // LPC trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 23: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 24: #define LPC_BUS 0 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 25: #define LPC_DEVICE 31 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 26: #define LPC_FUNCTION 0 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 27: #define R_ACPI_PM_BASE 0x40 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 28: #define ACPI_PM_BASE_MASK 0xFFF8 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 29: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 30: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 31: // MSRs trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 32: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 33: #define IA32_APIC_BASE_MSR_INDEX 0x1B DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 34: #define SMRR_PHYSBASE_MSR 0x1F2 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 35: #define SMRR_PHYSMASK_MSR 0x1F3 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 36: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 37: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 38: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 39: Add resources to BIOS resource database. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 40: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 41: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 42: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 42: void function definition argument 'void' should also have an identifier name
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 43: AddResourcesCmd ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 43: AddResourcesCmd ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 44: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 44: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 45: ); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 45: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 46: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/StmPlatformResou... PS1, Line 47: #endif DOS line endings
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/smm.h File src/include/cpu/x86/smm.h:
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/smm.h@515 PS1, Line 515: u32 mseg; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/include/cpu/x86/smm.h@515 PS1, Line 515: u32 mseg; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/Kconfig File src/security/stm/Kconfig:
https://review.coreboot.org/#/c/33215/1/src/security/stm/Kconfig@14 PS1, Line 14: endif #STM trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/Kconfig@15 PS1, Line 15: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c File src/security/stm/SmmStm.c:
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@8 PS1, Line 8: are licensed and made available under the terms and conditions of the BSD License line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@9 PS1, Line 9: which accompanies this distribution. The full text of the license may be found at line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@33 PS1, Line 33: #define IA32_PG_P 1<<0 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@34 PS1, Line 34: #define IA32_PG_RW 1<<1 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@35 PS1, Line 35: #define IA32_PG_PS 1<<7 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@39 PS1, Line 39: #define STM_SIZE_TO_PAGES(a) (((a) >> STM_PAGE_SHIFT) + (((a) & STM_PAGE_MASK) ? 1 : 0)) line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@40 PS1, Line 40: #define STM_PAGES_TO_SIZE(a) ( (a) << STM_PAGE_SHIFT) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@51 PS1, Line 51: uint32_t GetVmcsSize (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@53 PS1, Line 53: void StmGen4GPageTableX64 (uint32_t PageTableBase); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@54 PS1, Line 54: bool StmCheckStmImage (void * StmImage, uint32_t StmImageSize); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@54 PS1, Line 54: bool StmCheckStmImage (void * StmImage, uint32_t StmImageSize); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@55 PS1, Line 55: void StmLoadStmImage (void * StmImage, UINTN StmImageSize); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@55 PS1, Line 55: void StmLoadStmImage (void * StmImage, UINTN StmImageSize); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@57 PS1, Line 57: bool HandleSingleResource (STM_RSC *Resource, STM_RSC *Record); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@58 PS1, Line 58: void AddSingleResource (STM_RSC *Resource); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@59 PS1, Line 59: void AddResource (STM_RSC *ResourceList, uint32_t NumEntries); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@60 PS1, Line 60: bool ValidateResource (STM_RSC *ResourceList, uint32_t NumEntries); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@61 PS1, Line 61: UINTN GetResourceSize (STM_RSC *ResourceList, uint32_t NumEntries); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@93 PS1, Line 93: struct mp_ops ops; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@93 PS1, Line 93: struct mp_ops ops; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@94 PS1, Line 94: int cpu_count; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@94 PS1, Line 94: int cpu_count; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@95 PS1, Line 95: uintptr_t perm_smbase; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@95 PS1, Line 95: uintptr_t perm_smbase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@96 PS1, Line 96: size_t perm_smsize; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@96 PS1, Line 96: size_t perm_smsize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@97 PS1, Line 97: size_t smm_save_state_size; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@97 PS1, Line 97: size_t smm_save_state_size; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@98 PS1, Line 98: int do_smm; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@98 PS1, Line 98: int do_smm; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@112 PS1, Line 112: {END_OF_RESOURCES, sizeof (STM_RSC_END)}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@112 PS1, Line 112: {END_OF_RESOURCES, sizeof (STM_RSC_END)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@137 PS1, Line 137: HandleSingleResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@138 PS1, Line 138: STM_RSC *Resource, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@139 PS1, Line 139: STM_RSC *Record please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@140 PS1, Line 140: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@141 PS1, Line 141: { trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@142 PS1, Line 142: uint64_t ResourceLo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@143 PS1, Line 143: uint64_t ResourceHi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@144 PS1, Line 144: uint64_t RecordLo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@145 PS1, Line 145: uint64_t RecordHi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@147 PS1, Line 147: ResourceLo = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@148 PS1, Line 148: ResourceHi = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@149 PS1, Line 149: RecordLo = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@150 PS1, Line 150: RecordHi = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@156 PS1, Line 156: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@158 PS1, Line 158: switch (Resource->Header.RscType) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@159 PS1, Line 159: case MEM_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@160 PS1, Line 160: case MMIO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@161 PS1, Line 161: ResourceLo = Resource->Mem.Base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@162 PS1, Line 162: ResourceHi = Resource->Mem.Base + Resource->Mem.Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@163 PS1, Line 163: RecordLo = Record->Mem.Base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@164 PS1, Line 164: RecordHi = Record->Mem.Base + Record->Mem.Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@165 PS1, Line 165: if (Resource->Mem.RWXAttributes != Record->Mem.RWXAttributes) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@165 PS1, Line 165: if (Resource->Mem.RWXAttributes != Record->Mem.RWXAttributes) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@166 PS1, Line 166: if ((ResourceLo == RecordLo) && (ResourceHi == RecordHi)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@167 PS1, Line 167: Record->Mem.RWXAttributes = Resource->Mem.RWXAttributes | Record->Mem.RWXAttributes; line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@167 PS1, Line 167: Record->Mem.RWXAttributes = Resource->Mem.RWXAttributes | Record->Mem.RWXAttributes; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@167 PS1, Line 167: Record->Mem.RWXAttributes = Resource->Mem.RWXAttributes | Record->Mem.RWXAttributes; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@168 PS1, Line 168: return true; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@168 PS1, Line 168: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@169 PS1, Line 169: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@170 PS1, Line 170: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@170 PS1, Line 170: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@171 PS1, Line 171: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@172 PS1, Line 172: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@173 PS1, Line 173: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@174 PS1, Line 174: case IO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@175 PS1, Line 175: case TRAPPED_IO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@176 PS1, Line 176: ResourceLo = (uint64_t) Resource->Io.Base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@177 PS1, Line 177: ResourceHi = (uint64_t) Resource->Io.Base + (uint64_t) Resource->Io.Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@178 PS1, Line 178: RecordLo = (uint64_t) Record->Io.Base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@179 PS1, Line 179: RecordHi = (uint64_t) Record->Io.Base + (uint64_t) Record->Io.Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@180 PS1, Line 180: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@181 PS1, Line 181: case PCI_CFG_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@182 PS1, Line 182: if ((Resource->PciCfg.OriginatingBusNumber != Record->PciCfg.OriginatingBusNumber) || line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@182 PS1, Line 182: if ((Resource->PciCfg.OriginatingBusNumber != Record->PciCfg.OriginatingBusNumber) || please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@182 PS1, Line 182: if ((Resource->PciCfg.OriginatingBusNumber != Record->PciCfg.OriginatingBusNumber) || suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@183 PS1, Line 183: (Resource->PciCfg.LastNodeIndex != Record->PciCfg.LastNodeIndex)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@183 PS1, Line 183: (Resource->PciCfg.LastNodeIndex != Record->PciCfg.LastNodeIndex)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@184 PS1, Line 184: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@185 PS1, Line 185: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@186 PS1, Line 186: if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@186 PS1, Line 186: if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@186 PS1, Line 186: if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@186 PS1, Line 186: if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@186 PS1, Line 186: if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@187 PS1, Line 187: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@188 PS1, Line 188: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@189 PS1, Line 189: ResourceLo = (uint64_t) Resource->PciCfg.Base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@190 PS1, Line 190: ResourceHi = (uint64_t) Resource->PciCfg.Base + (uint64_t) Resource->PciCfg.Length; line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@190 PS1, Line 190: ResourceHi = (uint64_t) Resource->PciCfg.Base + (uint64_t) Resource->PciCfg.Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@191 PS1, Line 191: RecordLo = (uint64_t) Record->PciCfg.Base; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@192 PS1, Line 192: RecordHi = (uint64_t) Record->PciCfg.Base + (uint64_t) Record->PciCfg.Length; line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@192 PS1, Line 192: RecordHi = (uint64_t) Record->PciCfg.Base + (uint64_t) Record->PciCfg.Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@193 PS1, Line 193: if (Resource->PciCfg.RWAttributes != Record->PciCfg.RWAttributes) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@193 PS1, Line 193: if (Resource->PciCfg.RWAttributes != Record->PciCfg.RWAttributes) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@194 PS1, Line 194: if ((ResourceLo == RecordLo) && (ResourceHi == RecordHi)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@195 PS1, Line 195: Record->PciCfg.RWAttributes = Resource->PciCfg.RWAttributes | Record->PciCfg.RWAttributes; line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@195 PS1, Line 195: Record->PciCfg.RWAttributes = Resource->PciCfg.RWAttributes | Record->PciCfg.RWAttributes; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@195 PS1, Line 195: Record->PciCfg.RWAttributes = Resource->PciCfg.RWAttributes | Record->PciCfg.RWAttributes; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@196 PS1, Line 196: return true; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@196 PS1, Line 196: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@197 PS1, Line 197: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@198 PS1, Line 198: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@198 PS1, Line 198: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@199 PS1, Line 199: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@200 PS1, Line 200: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@201 PS1, Line 201: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@202 PS1, Line 202: case MACHINE_SPECIFIC_REG: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@205 PS1, Line 205: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@206 PS1, Line 206: if (Resource->Msr.MsrIndex != Record->Msr.MsrIndex) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@206 PS1, Line 206: if (Resource->Msr.MsrIndex != Record->Msr.MsrIndex) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@206 PS1, Line 206: if (Resource->Msr.MsrIndex != Record->Msr.MsrIndex) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@207 PS1, Line 207: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@208 PS1, Line 208: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@209 PS1, Line 209: Record->Msr.ReadMask |= Resource->Msr.ReadMask; trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@209 PS1, Line 209: Record->Msr.ReadMask |= Resource->Msr.ReadMask; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@210 PS1, Line 210: Record->Msr.WriteMask |= Resource->Msr.WriteMask; trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@210 PS1, Line 210: Record->Msr.WriteMask |= Resource->Msr.WriteMask; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@211 PS1, Line 211: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@213 PS1, Line 213: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@214 PS1, Line 214: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@217 PS1, Line 217: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@218 PS1, Line 218: if ((ResourceHi < RecordLo) || (ResourceLo > RecordHi)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@218 PS1, Line 218: if ((ResourceHi < RecordLo) || (ResourceLo > RecordHi)) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@218 PS1, Line 218: if ((ResourceHi < RecordLo) || (ResourceLo > RecordHi)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@219 PS1, Line 219: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@220 PS1, Line 220: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@224 PS1, Line 224: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@225 PS1, Line 225: if ((ResourceLo >= RecordLo) && (ResourceHi <= RecordHi)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@225 PS1, Line 225: if ((ResourceLo >= RecordLo) && (ResourceHi <= RecordHi)) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@225 PS1, Line 225: if ((ResourceLo >= RecordLo) && (ResourceHi <= RecordHi)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@226 PS1, Line 226: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@227 PS1, Line 227: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@231 PS1, Line 231: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@232 PS1, Line 232: ResourceLo = (ResourceLo < RecordLo) ? ResourceLo : RecordLo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@233 PS1, Line 233: ResourceHi = (ResourceHi > RecordHi) ? ResourceHi : RecordHi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@235 PS1, Line 235: switch (Resource->Header.RscType) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@236 PS1, Line 236: case MEM_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@237 PS1, Line 237: case MMIO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@238 PS1, Line 238: Record->Mem.Base = ResourceLo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@239 PS1, Line 239: Record->Mem.Length = ResourceHi - ResourceLo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@240 PS1, Line 240: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@241 PS1, Line 241: case IO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@242 PS1, Line 242: case TRAPPED_IO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@243 PS1, Line 243: Record->Io.Base = (uint64_t) ResourceLo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@244 PS1, Line 244: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@245 PS1, Line 245: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@246 PS1, Line 246: case PCI_CFG_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@247 PS1, Line 247: Record->PciCfg.Base = (uint64_t) ResourceLo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@248 PS1, Line 248: Record->PciCfg.Length = (uint64_t) (ResourceHi - ResourceLo); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@249 PS1, Line 249: break; trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@249 PS1, Line 249: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@251 PS1, Line 251: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@252 PS1, Line 252: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@254 PS1, Line 254: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@265 PS1, Line 265: AddSingleResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@266 PS1, Line 266: STM_RSC *Resource please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@267 PS1, Line 267: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@269 PS1, Line 269: STM_RSC *Record; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@271 PS1, Line 271: Record = (STM_RSC *)mStmResourcesPtr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@273 PS1, Line 273: while (true) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@273 PS1, Line 273: while (true) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@274 PS1, Line 274: if (Record->Header.RscType == END_OF_RESOURCES) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@274 PS1, Line 274: if (Record->Header.RscType == END_OF_RESOURCES) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@274 PS1, Line 274: if (Record->Header.RscType == END_OF_RESOURCES) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@275 PS1, Line 275: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@276 PS1, Line 276: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@280 PS1, Line 280: if (Resource->Header.RscType != Record->Header.RscType) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@280 PS1, Line 280: if (Resource->Header.RscType != Record->Header.RscType) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@281 PS1, Line 281: Record = (STM_RSC *)((void *)Record + Record->Header.Length); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@282 PS1, Line 282: continue; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@283 PS1, Line 283: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@287 PS1, Line 287: if (HandleSingleResource (Resource, Record)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@287 PS1, Line 287: if (HandleSingleResource (Resource, Record)) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@287 PS1, Line 287: if (HandleSingleResource (Resource, Record)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@287 PS1, Line 287: if (HandleSingleResource (Resource, Record)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@288 PS1, Line 288: return ; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@288 PS1, Line 288: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@289 PS1, Line 289: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@290 PS1, Line 290: Record = (STM_RSC *)((void *)Record + Record->Header.Length); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@291 PS1, Line 291: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@296 PS1, Line 296: memcpy ( please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@296 PS1, Line 296: memcpy ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@297 PS1, Line 297: mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode), please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@298 PS1, Line 298: Resource, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@299 PS1, Line 299: Resource->Header.Length please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@300 PS1, Line 300: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@301 PS1, Line 301: memcpy ( please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@301 PS1, Line 301: memcpy ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@302 PS1, Line 302: mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode) + Resource->Header.Length, line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@302 PS1, Line 302: mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode) + Resource->Header.Length, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@303 PS1, Line 303: &mRscEndNode, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@304 PS1, Line 304: sizeof(mRscEndNode) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@305 PS1, Line 305: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@306 PS1, Line 306: mStmResourceSizeUsed += Resource->Header.Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@307 PS1, Line 307: mStmResourceSizeAvailable = mStmResourceTotalSize - mStmResourceSizeUsed; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@309 PS1, Line 309: return ; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@309 PS1, Line 309: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@318 PS1, Line 318: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@322 PS1, Line 322: AddResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@323 PS1, Line 323: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@324 PS1, Line 324: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@325 PS1, Line 325: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@327 PS1, Line 327: uint32_t Count; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@328 PS1, Line 328: UINTN Index; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@329 PS1, Line 329: STM_RSC *Resource; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@331 PS1, Line 331: if (NumEntries == 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@331 PS1, Line 331: if (NumEntries == 0) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@331 PS1, Line 331: if (NumEntries == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@332 PS1, Line 332: Count = 0xFFFFFFFF; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@333 PS1, Line 333: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@333 PS1, Line 333: } else { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@334 PS1, Line 334: Count = NumEntries; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@335 PS1, Line 335: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@337 PS1, Line 337: Resource = ResourceList; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@338 PS1, Line 338: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@338 PS1, Line 338: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@339 PS1, Line 339: for (Index = 0; Index < Count; Index++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@339 PS1, Line 339: for (Index = 0; Index < Count; Index++) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@340 PS1, Line 340: if (Resource->Header.RscType == END_OF_RESOURCES) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@340 PS1, Line 340: if (Resource->Header.RscType == END_OF_RESOURCES) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@340 PS1, Line 340: if (Resource->Header.RscType == END_OF_RESOURCES) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@341 PS1, Line 341: return ; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@341 PS1, Line 341: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@342 PS1, Line 342: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@343 PS1, Line 343: AddSingleResource (Resource); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@343 PS1, Line 343: AddSingleResource (Resource); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@344 PS1, Line 344: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@345 PS1, Line 345: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@346 PS1, Line 346: return ; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@346 PS1, Line 346: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@355 PS1, Line 355: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@362 PS1, Line 362: ValidateResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@363 PS1, Line 363: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@364 PS1, Line 364: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@365 PS1, Line 365: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@367 PS1, Line 367: uint32_t Count; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@368 PS1, Line 368: UINTN Index; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@369 PS1, Line 369: STM_RSC *Resource; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@370 PS1, Line 370: UINTN SubIndex; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@374 PS1, Line 374: // END_OF_RESOURCES. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@375 PS1, Line 375: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@376 PS1, Line 376: if (NumEntries == 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@376 PS1, Line 376: if (NumEntries == 0) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@376 PS1, Line 376: if (NumEntries == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@377 PS1, Line 377: Count = 0xFFFFFFFF; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@378 PS1, Line 378: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@378 PS1, Line 378: } else { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@379 PS1, Line 379: Count = NumEntries; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@380 PS1, Line 380: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@384 PS1, Line 384: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@385 PS1, Line 385: Resource = ResourceList; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@386 PS1, Line 386: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@386 PS1, Line 386: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@387 PS1, Line 387: for (Index = 0; Index < Count; Index++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@387 PS1, Line 387: for (Index = 0; Index < Count; Index++) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@388 PS1, Line 388: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@388 PS1, Line 388: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@388 PS1, Line 388: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType); Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@390 PS1, Line 390: // Validate resource. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@391 PS1, Line 391: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@392 PS1, Line 392: switch (Resource->Header.RscType) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@392 PS1, Line 392: switch (Resource->Header.RscType) { switch and case should be at the same indent
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@393 PS1, Line 393: case END_OF_RESOURCES: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@394 PS1, Line 394: if (Resource->Header.Length != sizeof (STM_RSC_END)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@394 PS1, Line 394: if (Resource->Header.Length != sizeof (STM_RSC_END)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@394 PS1, Line 394: if (Resource->Header.Length != sizeof (STM_RSC_END)) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@394 PS1, Line 394: if (Resource->Header.Length != sizeof (STM_RSC_END)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@394 PS1, Line 394: if (Resource->Header.Length != sizeof (STM_RSC_END)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@395 PS1, Line 395: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@395 PS1, Line 395: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@396 PS1, Line 396: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@396 PS1, Line 396: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@397 PS1, Line 397: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@398 PS1, Line 398: // If we are passed actual number of resources to add, code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@399 PS1, Line 399: // END_OF_RESOURCES structure between them is considered an code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@400 PS1, Line 400: // error. If NumEntries == 0 END_OF_RESOURCES is a termination. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@400 PS1, Line 400: // error. If NumEntries == 0 END_OF_RESOURCES is a termination. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@401 PS1, Line 401: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@402 PS1, Line 402: if (NumEntries != 0) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@402 PS1, Line 402: if (NumEntries != 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@402 PS1, Line 402: if (NumEntries != 0) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@403 PS1, Line 403: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@403 PS1, Line 403: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@404 PS1, Line 404: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@404 PS1, Line 404: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@404 PS1, Line 404: } else { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@405 PS1, Line 405: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@406 PS1, Line 406: // If NumEntries == 0 and list reached end - return success. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@407 PS1, Line 407: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@407 PS1, Line 407: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@408 PS1, Line 408: return true; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@408 PS1, Line 408: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@409 PS1, Line 409: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@409 PS1, Line 409: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@410 PS1, Line 410: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@410 PS1, Line 410: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@412 PS1, Line 412: case MEM_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@413 PS1, Line 413: case MMIO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@414 PS1, Line 414: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@414 PS1, Line 414: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@414 PS1, Line 414: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@414 PS1, Line 414: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@414 PS1, Line 414: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@415 PS1, Line 415: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@415 PS1, Line 415: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@416 PS1, Line 416: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@416 PS1, Line 416: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@418 PS1, Line 418: if (Resource->Mem.RWXAttributes > FULL_ACCS) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@418 PS1, Line 418: if (Resource->Mem.RWXAttributes > FULL_ACCS) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@418 PS1, Line 418: if (Resource->Mem.RWXAttributes > FULL_ACCS) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@418 PS1, Line 418: if (Resource->Mem.RWXAttributes > FULL_ACCS) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@419 PS1, Line 419: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@419 PS1, Line 419: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@420 PS1, Line 420: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@420 PS1, Line 420: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@421 PS1, Line 421: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@421 PS1, Line 421: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@422 PS1, Line 422: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@422 PS1, Line 422: code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@422 PS1, Line 422: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@423 PS1, Line 423: case IO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@424 PS1, Line 424: case TRAPPED_IO_RANGE: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@424 PS1, Line 424: case TRAPPED_IO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@425 PS1, Line 425: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@425 PS1, Line 425: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@425 PS1, Line 425: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@425 PS1, Line 425: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@425 PS1, Line 425: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@426 PS1, Line 426: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@426 PS1, Line 426: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@427 PS1, Line 427: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@427 PS1, Line 427: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@429 PS1, Line 429: if ((Resource->Io.Base + Resource->Io.Length) > 0xFFFF) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@429 PS1, Line 429: if ((Resource->Io.Base + Resource->Io.Length) > 0xFFFF) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@429 PS1, Line 429: if ((Resource->Io.Base + Resource->Io.Length) > 0xFFFF) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@429 PS1, Line 429: if ((Resource->Io.Base + Resource->Io.Length) > 0xFFFF) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@430 PS1, Line 430: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@430 PS1, Line 430: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@431 PS1, Line 431: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@431 PS1, Line 431: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@432 PS1, Line 432: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@432 PS1, Line 432: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@434 PS1, Line 434: case PCI_CFG_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@435 PS1, Line 435: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@435 PS1, Line 435: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction); code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@435 PS1, Line 435: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@435 PS1, Line 435: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction); Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@436 PS1, Line 436: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@436 PS1, Line 436: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@436 PS1, Line 436: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@436 PS1, Line 436: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@436 PS1, Line 436: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@436 PS1, Line 436: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@437 PS1, Line 437: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@437 PS1, Line 437: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@438 PS1, Line 438: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@438 PS1, Line 438: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@439 PS1, Line 439: for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) { line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@439 PS1, Line 439: for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@439 PS1, Line 439: for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@439 PS1, Line 439: for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@440 PS1, Line 440: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@440 PS1, Line 440: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@440 PS1, Line 440: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@440 PS1, Line 440: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { suspect code indent for conditional statements (10, 12)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@440 PS1, Line 440: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@441 PS1, Line 441: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@441 PS1, Line 441: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@442 PS1, Line 442: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@442 PS1, Line 442: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@443 PS1, Line 443: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@443 PS1, Line 443: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@444 PS1, Line 444: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@444 PS1, Line 444: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@444 PS1, Line 444: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@444 PS1, Line 444: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@445 PS1, Line 445: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@445 PS1, Line 445: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@446 PS1, Line 446: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@446 PS1, Line 446: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@447 PS1, Line 447: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@447 PS1, Line 447: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@449 PS1, Line 449: case MACHINE_SPECIFIC_REG: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@450 PS1, Line 450: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@450 PS1, Line 450: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@450 PS1, Line 450: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@450 PS1, Line 450: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@450 PS1, Line 450: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@451 PS1, Line 451: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@451 PS1, Line 451: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@452 PS1, Line 452: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@452 PS1, Line 452: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@453 PS1, Line 453: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@453 PS1, Line 453: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@454 PS1, Line 454: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@454 PS1, Line 454: code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@454 PS1, Line 454: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@455 PS1, Line 455: default : trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@455 PS1, Line 455: default : please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@455 PS1, Line 455: default : space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@456 PS1, Line 456: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@456 PS1, Line 456: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType); code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@456 PS1, Line 456: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@456 PS1, Line 456: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType); Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@457 PS1, Line 457: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@457 PS1, Line 457: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@458 PS1, Line 458: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@459 PS1, Line 459: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@460 PS1, Line 460: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@461 PS1, Line 461: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@471 PS1, Line 471: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@478 PS1, Line 478: GetResourceSize ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@479 PS1, Line 479: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@480 PS1, Line 480: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@481 PS1, Line 481: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@483 PS1, Line 483: uint32_t Count; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@484 PS1, Line 484: UINTN Index; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@485 PS1, Line 485: STM_RSC *Resource; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@487 PS1, Line 487: Resource = ResourceList; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@491 PS1, Line 491: // END_OF_RESOURCES. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@492 PS1, Line 492: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@493 PS1, Line 493: if (NumEntries == 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@493 PS1, Line 493: if (NumEntries == 0) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@493 PS1, Line 493: if (NumEntries == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@494 PS1, Line 494: Count = 0xFFFFFFFF; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@495 PS1, Line 495: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@495 PS1, Line 495: } else { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@496 PS1, Line 496: Count = NumEntries; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@497 PS1, Line 497: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@501 PS1, Line 501: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@502 PS1, Line 502: Resource = ResourceList; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@503 PS1, Line 503: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@503 PS1, Line 503: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@504 PS1, Line 504: for (Index = 0; Index < Count; Index++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@504 PS1, Line 504: for (Index = 0; Index < Count; Index++) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@505 PS1, Line 505: if (Resource->Header.RscType == END_OF_RESOURCES) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@505 PS1, Line 505: if (Resource->Header.RscType == END_OF_RESOURCES) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@505 PS1, Line 505: if (Resource->Header.RscType == END_OF_RESOURCES) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@506 PS1, Line 506: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@507 PS1, Line 507: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@508 PS1, Line 508: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@509 PS1, Line 509: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@510 PS1, Line 510: return (UINTN)((uint32_t)Resource - (uint32_t) ResourceList); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@519 PS1, Line 519: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@523 PS1, Line 523: @retval EFI_OUT_OF_RESOURCES If nested procedure returned it and we cannot allocate more areas. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@527 PS1, Line 527: AddPiResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@528 PS1, Line 528: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@529 PS1, Line 529: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@530 PS1, Line 530: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@533 PS1, Line 533: UINTN ResourceSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@537 PS1, Line 537: printk (BIOS_DEBUG, "AddPiResource - Enter\n"); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@537 PS1, Line 537: printk (BIOS_DEBUG, "AddPiResource - Enter\n"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@537 PS1, Line 537: printk (BIOS_DEBUG, "AddPiResource - Enter\n"); Prefer using '"%s...", __func__' to using 'AddPiResource', this function's name, in a string
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@539 PS1, Line 539: if (!ValidateResource (ResourceList, NumEntries)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@539 PS1, Line 539: if (!ValidateResource (ResourceList, NumEntries)) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@539 PS1, Line 539: if (!ValidateResource (ResourceList, NumEntries)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@539 PS1, Line 539: if (!ValidateResource (ResourceList, NumEntries)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@540 PS1, Line 540: return -1; //EFI_INVALID_PARAMETER; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@541 PS1, Line 541: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@543 PS1, Line 543: ResourceSize = GetResourceSize (ResourceList, NumEntries); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@543 PS1, Line 543: ResourceSize = GetResourceSize (ResourceList, NumEntries); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@544 PS1, Line 544: printk (BIOS_DEBUG, "ResourceSize - 0x%08llx\n", ResourceSize); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@544 PS1, Line 544: printk (BIOS_DEBUG, "ResourceSize - 0x%08llx\n", ResourceSize); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@545 PS1, Line 545: if (ResourceSize == 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@545 PS1, Line 545: if (ResourceSize == 0) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@545 PS1, Line 545: if (ResourceSize == 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@546 PS1, Line 546: return -1;//EFI_INVALID_PARAMETER; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@547 PS1, Line 547: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@549 PS1, Line 549: if (mStmResourcesPtr == NULL) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@549 PS1, Line 549: if (mStmResourcesPtr == NULL) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@551 PS1, Line 551: // Copy EndResource for intialization 'intialization' may be misspelled - perhaps 'initialization'?
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@556 PS1, Line 556: mStmResourcesPtr = StmResourceHeap; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@557 PS1, Line 557: mStmResourceTotalSize = RESOURCEHEAPSIZE; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@558 PS1, Line 558: memset(mStmResourcesPtr, 0, RESOURCEHEAPSIZE); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@560 PS1, Line 560: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@560 PS1, Line 560: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@561 PS1, Line 561: mStmResourceSizeUsed = sizeof(mRscEndNode); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@562 PS1, Line 562: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@568 PS1, Line 568: } else if (mStmResourceSizeAvailable < ResourceSize) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@574 PS1, Line 574: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@579 PS1, Line 579: AddResource (ResourceList, NumEntries); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@579 PS1, Line 579: AddResource (ResourceList, NumEntries); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@581 PS1, Line 581: return 0;//EFI_SUCCESS; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@589 PS1, Line 589: NULL means delete all resources. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@591 PS1, Line 591: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@598 PS1, Line 598: DeletePiResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@599 PS1, Line 599: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@600 PS1, Line 600: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@601 PS1, Line 601: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@603 PS1, Line 603: if (ResourceList != NULL) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@603 PS1, Line 603: if (ResourceList != NULL) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@606 PS1, Line 606: return -1;//EFI_UNSUPPORTED; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@607 PS1, Line 607: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@611 PS1, Line 611: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@611 PS1, Line 611: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@612 PS1, Line 612: mStmResourceSizeUsed = sizeof(mRscEndNode); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@613 PS1, Line 613: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@614 PS1, Line 614: return 0;//EFI_SUCCESS; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@623 PS1, Line 623: On output it means size of resource list filled, code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@624 PS1, Line 624: or the size of resource list to be filled if size of too small. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@624 PS1, Line 624: or the size of resource list to be filled if size of too small. code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@627 PS1, Line 627: @retval EFI_BUFFER_TOO_SMALL If resource list buffer is too small to hold the whole resources. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@631 PS1, Line 631: GetPiResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@632 PS1, Line 632: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@633 PS1, Line 633: uint32_t *ResourceSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@634 PS1, Line 634: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@636 PS1, Line 636: if (*ResourceSize < mStmResourceSizeUsed) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@636 PS1, Line 636: if (*ResourceSize < mStmResourceSizeUsed) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@637 PS1, Line 637: *ResourceSize = (uint32_t)mStmResourceSizeUsed; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@638 PS1, Line 638: return -1;//EFI_BUFFER_TOO_SMALL; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@639 PS1, Line 639: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@641 PS1, Line 641: memcpy (ResourceList, mStmResourcesPtr, mStmResourceSizeUsed); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@641 PS1, Line 641: memcpy (ResourceList, mStmResourcesPtr, mStmResourceSizeUsed); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@642 PS1, Line 642: *ResourceSize = (uint32_t)mStmResourceSizeUsed; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@643 PS1, Line 643: return 0;//EFI_SUCCESS; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@652 PS1, Line 652: GetVmcsSize ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@653 PS1, Line 653: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@654 PS1, Line 654: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@656 PS1, Line 656: uint32_t ThisVmcsSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@657 PS1, Line 657: VMX_BASIC_MSR MsrData64; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@658 PS1, Line 658: int StmSupport; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@660 PS1, Line 660: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX); trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@660 PS1, Line 660: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@660 PS1, Line 660: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@662 PS1, Line 662: ThisVmcsSize = MsrData64.bits.VmcsSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@663 PS1, Line 663: StmSupport = MsrData64.bits.StmSupported; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@664 PS1, Line 664: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@664 PS1, Line 664: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@664 PS1, Line 664: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport); Prefer using '"%s...", __func__' to using 'GetVmcsSize', this function's name, in a string
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@669 PS1, Line 669: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize)); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@669 PS1, Line 669: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@669 PS1, Line 669: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@671 PS1, Line 671: return ThisVmcsSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@683 PS1, Line 683: StmGen4GPageTableIa32 ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@684 PS1, Line 684: uint32_t PageTableBase please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@685 PS1, Line 685: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@687 PS1, Line 687: UINTN Index; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@688 PS1, Line 688: uint32_t *Pte; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@689 PS1, Line 689: uint32_t Address; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@691 PS1, Line 691: Pte = (uint32_t*)(uint32_t)PageTableBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@691 PS1, Line 691: Pte = (uint32_t*)(uint32_t)PageTableBase; "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@693 PS1, Line 693: Address = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@694 PS1, Line 694: for (Index = 0; Index < SIZE_4KB / sizeof (*Pte); Index++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@694 PS1, Line 694: for (Index = 0; Index < SIZE_4KB / sizeof (*Pte); Index++) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@694 PS1, Line 694: for (Index = 0; Index < SIZE_4KB / sizeof (*Pte); Index++) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@695 PS1, Line 695: *Pte = Address | IA32_PG_PS | IA32_PG_RW | IA32_PG_P; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@696 PS1, Line 696: Pte++; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@697 PS1, Line 697: Address += SIZE_4MB; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@698 PS1, Line 698: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@700 PS1, Line 700: return ; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@700 PS1, Line 700: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@712 PS1, Line 712: StmGen4GPageTableX64 ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@713 PS1, Line 713: uint32_t PageTableBase please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@714 PS1, Line 714: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@716 PS1, Line 716: UINTN Index; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@717 PS1, Line 717: UINTN SubIndex; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@718 PS1, Line 718: uint64_t *Pde; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@719 PS1, Line 719: uint64_t *Pte; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@720 PS1, Line 720: uint64_t *Pml4; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@722 PS1, Line 722: Pml4 = (uint64_t*)(uint32_t) PageTableBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@722 PS1, Line 722: Pml4 = (uint64_t*)(uint32_t) PageTableBase; "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@723 PS1, Line 723: PageTableBase += SIZE_4KB; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@724 PS1, Line 724: *Pml4 = PageTableBase | IA32_PG_RW | IA32_PG_P; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@726 PS1, Line 726: Pde = (uint64_t*)(uint32_t)PageTableBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@726 PS1, Line 726: Pde = (uint64_t*)(uint32_t)PageTableBase; "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@727 PS1, Line 727: PageTableBase += SIZE_4KB; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@728 PS1, Line 728: Pte = (uint64_t *)(uint32_t)PageTableBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@730 PS1, Line 730: for (Index = 0; Index < 4; Index++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@730 PS1, Line 730: for (Index = 0; Index < 4; Index++) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@731 PS1, Line 731: *Pde = PageTableBase | IA32_PG_RW | IA32_PG_P; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@732 PS1, Line 732: Pde++; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@733 PS1, Line 733: PageTableBase += SIZE_4KB; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@735 PS1, Line 735: for (SubIndex = 0; SubIndex < SIZE_4KB / sizeof (*Pte); SubIndex++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@735 PS1, Line 735: for (SubIndex = 0; SubIndex < SIZE_4KB / sizeof (*Pte); SubIndex++) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@735 PS1, Line 735: for (SubIndex = 0; SubIndex < SIZE_4KB / sizeof (*Pte); SubIndex++) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@736 PS1, Line 736: *Pte = (((Index << 9) + SubIndex) << 21) | IA32_PG_PS | IA32_PG_RW | IA32_PG_P; line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@736 PS1, Line 736: *Pte = (((Index << 9) + SubIndex) << 21) | IA32_PG_PS | IA32_PG_RW | IA32_PG_P; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@737 PS1, Line 737: Pte++; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@738 PS1, Line 738: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@739 PS1, Line 739: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@741 PS1, Line 741: return ; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@741 PS1, Line 741: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@755 PS1, Line 755: bool StmCheckStmImage ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@756 PS1, Line 756: void * StmImage, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@756 PS1, Line 756: void * StmImage, "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@757 PS1, Line 757: uint32_t StmImageSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@758 PS1, Line 758: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@760 PS1, Line 760: UINTN MinMsegSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@761 PS1, Line 761: STM_HEADER *StmHeader; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@763 PS1, Line 763: StmHeader = (STM_HEADER *)StmImage; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@768 PS1, Line 768: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@768 PS1, Line 768: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@768 PS1, Line 768: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@768 PS1, Line 768: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@769 PS1, Line 769: StmHeader->SwStmHdr.AdditionalDynamicMemorySize + code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@769 PS1, Line 769: StmHeader->SwStmHdr.AdditionalDynamicMemorySize + please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@770 PS1, Line 770: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@770 PS1, Line 770: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count); code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@770 PS1, Line 770: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@770 PS1, Line 770: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@771 PS1, Line 771: if (MinMsegSize < StmImageSize) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@771 PS1, Line 771: if (MinMsegSize < StmImageSize) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@771 PS1, Line 771: if (MinMsegSize < StmImageSize) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@772 PS1, Line 772: MinMsegSize = StmImageSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@773 PS1, Line 773: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@775 PS1, Line 775: if (StmHeader->HwStmHdr.Cr3Offset >= StmHeader->SwStmHdr.StaticImageSize) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@775 PS1, Line 775: if (StmHeader->HwStmHdr.Cr3Offset >= StmHeader->SwStmHdr.StaticImageSize) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@779 PS1, Line 779: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@779 PS1, Line 779: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@779 PS1, Line 779: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@780 PS1, Line 780: MinMsegSize = StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@781 PS1, Line 781: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@782 PS1, Line 782: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@787 PS1, Line 787: if (MinMsegSize > CONFIG_MSEG_SIZE) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@787 PS1, Line 787: if (MinMsegSize > CONFIG_MSEG_SIZE) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@787 PS1, Line 787: if (MinMsegSize > CONFIG_MSEG_SIZE) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@788 PS1, Line 788: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@789 PS1, Line 789: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@791 PS1, Line 791: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@805 PS1, Line 805: StmLoadStmImage ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@806 PS1, Line 806: void * StmImage, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@806 PS1, Line 806: void * StmImage, "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@807 PS1, Line 807: UINTN StmImageSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@808 PS1, Line 808: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@810 PS1, Line 810: uint32_t MsegBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@811 PS1, Line 811: STM_HEADER *StmHeader; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@812 PS1, Line 812: SMM_MONITOR_CTL_MSR SmmMonitorMsr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@814 PS1, Line 814: StmHeader = (STM_HEADER *)(uint32_t)StmImage; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@815 PS1, Line 815: SmmMonitorMsr.msr = rdmsr(IA32_SMM_MONITOR_CTL_MSR_INDEX); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@816 PS1, Line 816: MsegBase = SmmMonitorMsr.bits.MsegAddress << 12; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@820 PS1, Line 820: memset((void *) MsegBase, 0, CONFIG_MSEG_SIZE); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@821 PS1, Line 821: //memcpy ((void *)(uint32_t)MsegBase, (void *)(uint32_t)StmImage, StmImageSize); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@822 PS1, Line 822: memcpy((void *) MsegBase, (void *) StmImage, (size_t) StmImageSize); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@825 PS1, Line 825: if (sizeof(UINTN) == sizeof(uint64_t)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@825 PS1, Line 825: if (sizeof(UINTN) == sizeof(uint64_t)) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@825 PS1, Line 825: if (sizeof(UINTN) == sizeof(uint64_t)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@826 PS1, Line 826: StmGen4GPageTableX64 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@826 PS1, Line 826: StmGen4GPageTableX64 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@827 PS1, Line 827: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@827 PS1, Line 827: } else { suspect code indent for conditional statements (1, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@828 PS1, Line 828: StmGen4GPageTableIa32 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@828 PS1, Line 828: StmGen4GPageTableIa32 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@829 PS1, Line 829: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@844 PS1, Line 844: @retval EFI_BUFFER_TOO_SMALL MSEG is smaller than minimal requirement of STM image line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@848 PS1, Line 848: int LoadMonitor ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@849 PS1, Line 849: void * StmImage, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@849 PS1, Line 849: void * StmImage, "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@850 PS1, Line 850: uint32_t StmImageSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@851 PS1, Line 851: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@853 PS1, Line 853: SMM_MONITOR_CTL_MSR SmmMonCtlMsr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@855 PS1, Line 855: SmmMonCtlMsr.msr = (msr_t) rdmsr(IA32_SMM_MONITOR_CTL_MSR_INDEX); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@857 PS1, Line 857: if (SmmMonCtlMsr.bits.MsegAddress == 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@857 PS1, Line 857: if (SmmMonCtlMsr.bits.MsegAddress == 0) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@857 PS1, Line 857: if (SmmMonCtlMsr.bits.MsegAddress == 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@858 PS1, Line 858: return STM_UNSUPPORTED; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@859 PS1, Line 859: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@860 PS1, Line 860: if (SmmMonCtlMsr.bits.valid != 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@860 PS1, Line 860: if (SmmMonCtlMsr.bits.valid != 0) { suspect code indent for conditional statements (2, 2)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@863 PS1, Line 863: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@865 PS1, Line 865: if (!StmCheckStmImage (StmImage, StmImageSize)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@865 PS1, Line 865: if (!StmCheckStmImage (StmImage, StmImageSize)) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@865 PS1, Line 865: if (!StmCheckStmImage (StmImage, StmImageSize)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@865 PS1, Line 865: if (!StmCheckStmImage (StmImage, StmImageSize)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@866 PS1, Line 866: return STM_BUFFER_TOO_SMALL; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@867 PS1, Line 867: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@870 PS1, Line 870: // Record STM_HASH to PCR 0, just in case it is NOT TXT launch, we still need provide the evidence. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@871 PS1, Line 871: TpmMeasureAndLogData( please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@872 PS1, Line 872: 0, // PcrIndex please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@873 PS1, Line 873: TXT_EVTYPE_STM_HASH, // EventType please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@874 PS1, Line 874: NULL, // EventLog please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@875 PS1, Line 875: 0, // LogLen please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@876 PS1, Line 876: (void *)StmImage, // HashData please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@877 PS1, Line 877: StmImageSize // HashDataLen please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@878 PS1, Line 878: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@880 PS1, Line 880: StmLoadStmImage (StmImage, StmImageSize); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@880 PS1, Line 880: StmLoadStmImage (StmImage, StmImageSize); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@881 PS1, Line 881: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@881 PS1, Line 881: code indent should use tabs where possible
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@881 PS1, Line 881: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@882 PS1, Line 882: mStmState |= STM_SM_MONITOR_STATE_ENABLED; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@884 PS1, Line 884: return STM_SUCCESS; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@896 PS1, Line 896: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@897 PS1, Line 897: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/SmmStm.c@899 PS1, Line 899: return mStmResourcesPtr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... File src/security/stm/StmPlatformResource.c:
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 1: /** @file trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 2: STM platform SMM resource trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 3: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 4: Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 5: This program and the accompanying materials trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 6: are licensed and made available under the terms and conditions of the BSD License trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 6: are licensed and made available under the terms and conditions of the BSD License line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 7: which accompanies this distribution. The full text of the license may be found at trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 7: which accompanies this distribution. The full text of the license may be found at line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 8: http://opensource.org/licenses/bsd-license.php. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 9: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 10: THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 11: WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 12: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 13: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 14: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 15: #include <stdint.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 16: #include <cpu/x86/StmApi.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 17: #include <cpu/x86/SmmStm.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 18: #include <cpu/x86/StmPlatformResource.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 19: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 20: #include <southbridge/intel/common/pmutil.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 21: #include <cpu/x86/msr.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 22: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 23: #define RDWR_ACCS 3 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 24: #define FULL_ACCS 7 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 25: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 26: uint32_t mMaxBus; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 27: uint32_t mTsegBase; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 28: uint32_t mTsegSize; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 29: uint16_t mPmBase; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 30: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 31: typedef union { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 32: uint64_t uint64; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 33: msr_t msr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 34: } msr64_t; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 35: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 36: //uint64_t PciRead64 (UINTN Address); trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 37: void ResourceInit (void); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 37: void ResourceInit (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 38: void FixupPciexResource (void); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 38: void FixupPciexResource (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 39: void AddSimpleResources (void); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 39: void AddSimpleResources (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 40: void AddMsrResources (void); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 40: void AddMsrResources (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 41: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 42: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 43: // Fixed memory ranges trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 44: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 45: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 46: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 47: // TSEG memory! trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 48: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 49: STM_RSC_MEM_DESC RscTsegMemory = { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 50: {MEM_RANGE, sizeof (STM_RSC_MEM_DESC)}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 50: {MEM_RANGE, sizeof (STM_RSC_MEM_DESC)}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 50: {MEM_RANGE, sizeof (STM_RSC_MEM_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 51: 0, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 51: 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 52: 0, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 52: 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 53: FULL_ACCS DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 53: FULL_ACCS please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 54: }; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 55: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 56: // Flash part trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 57: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 58: STM_RSC_MEM_DESC RscSpiMemory = { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 59: {MEM_RANGE, sizeof (STM_RSC_MEM_DESC)}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 59: {MEM_RANGE, sizeof (STM_RSC_MEM_DESC)}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 59: {MEM_RANGE, sizeof (STM_RSC_MEM_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 60: 0xFE000000, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 60: 0xFE000000, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 61: 0x01000000, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 61: 0x01000000, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 62: FULL_ACCS DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 62: FULL_ACCS please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 63: }; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 64: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 65: // ACPI trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 66: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 67: STM_RSC_IO_DESC RscPmIo = { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 68: {IO_RANGE, sizeof (STM_RSC_IO_DESC)}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 68: {IO_RANGE, sizeof (STM_RSC_IO_DESC)}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 68: {IO_RANGE, sizeof (STM_RSC_IO_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 69: 0, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 69: 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 70: 128 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 70: 128 please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 71: }; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 72: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 73: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 74: // PCIE MMIO trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 75: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 76: STM_RSC_MMIO_DESC RscPcieMmio = { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 77: {MMIO_RANGE, sizeof (STM_RSC_MMIO_DESC)}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 77: {MMIO_RANGE, sizeof (STM_RSC_MMIO_DESC)}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 77: {MMIO_RANGE, sizeof (STM_RSC_MMIO_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 78: 0, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 78: 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 79: 0, // Length trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 79: 0, // Length please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 80: RDWR_ACCS DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 80: RDWR_ACCS please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 81: }; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 82: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 83: // Local APIC trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 84: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 85: STM_RSC_MMIO_DESC RscApicMmio = { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 86: {MMIO_RANGE, sizeof (STM_RSC_MMIO_DESC)}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 86: {MMIO_RANGE, sizeof (STM_RSC_MMIO_DESC)}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 86: {MMIO_RANGE, sizeof (STM_RSC_MMIO_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 87: 0, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 87: 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 88: 0x400, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 88: 0x400, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 89: RDWR_ACCS DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 89: RDWR_ACCS please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 90: }; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 91: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 92: // Software SMI trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 93: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 94: STM_RSC_TRAPPED_IO_DESC RscSwSmiTrapIo = { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 95: {TRAPPED_IO_RANGE, sizeof (STM_RSC_TRAPPED_IO_DESC)}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 95: {TRAPPED_IO_RANGE, sizeof (STM_RSC_TRAPPED_IO_DESC)}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 95: {TRAPPED_IO_RANGE, sizeof (STM_RSC_TRAPPED_IO_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 96: 0xB2, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 96: 0xB2, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 97: 2 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 97: 2 please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 98: }; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 99: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 100: // End of list trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 101: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 102: STM_RSC_END RscListEnd = { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 103: {END_OF_RESOURCES, sizeof (STM_RSC_END)}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 103: {END_OF_RESOURCES, sizeof (STM_RSC_END)}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 103: {END_OF_RESOURCES, sizeof (STM_RSC_END)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 104: 0 DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 104: 0 please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 105: }; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 106: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 107: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 108: // Common PCI devices trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 109: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 110: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 111: // LPC bridge trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 112: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 113: STM_RSC_PCI_CFG_DESC RscLpcBridgePci = { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 114: {PCI_CFG_RANGE, sizeof (STM_RSC_PCI_CFG_DESC)}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 114: {PCI_CFG_RANGE, sizeof (STM_RSC_PCI_CFG_DESC)}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 114: {PCI_CFG_RANGE, sizeof (STM_RSC_PCI_CFG_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 115: RDWR_ACCS, 0, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 115: RDWR_ACCS, 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 116: 0, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 116: 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 117: 0x1000, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 117: 0x1000, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 118: 0, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 118: 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 119: 0, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 119: 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 120: { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 120: { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 121: {1, 1, sizeof(STM_PCI_DEVICE_PATH_NODE), LPC_FUNCTION, LPC_DEVICE}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 121: {1, 1, sizeof(STM_PCI_DEVICE_PATH_NODE), LPC_FUNCTION, LPC_DEVICE}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 122: }, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 122: }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 123: }; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 124: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 125: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 126: // Template for MSR resources. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 127: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 128: STM_RSC_MSR_DESC RscMsrTpl = { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 129: {MACHINE_SPECIFIC_REG, sizeof (STM_RSC_MSR_DESC)}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 129: {MACHINE_SPECIFIC_REG, sizeof (STM_RSC_MSR_DESC)}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 129: {MACHINE_SPECIFIC_REG, sizeof (STM_RSC_MSR_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 130: }; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 131: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 132: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 133: // MSR indices to register trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 134: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 135: typedef struct { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 136: uint32_t MsrIndex; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 136: uint32_t MsrIndex; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 137: uint64_t ReadMask; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 137: uint64_t ReadMask; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 138: uint64_t WriteMask; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 138: uint64_t WriteMask; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 139: } MSR_TABLE_ENTRY; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 140: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 141: MSR_TABLE_ENTRY MsrTable[] = { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 142: // Index Read Write // MASK64 means need access, MASK0 means no need access. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 142: // Index Read Write // MASK64 means need access, MASK0 means no need access. line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 143: {SMRR_PHYSBASE_MSR, MASK64, MASK0}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 143: {SMRR_PHYSBASE_MSR, MASK64, MASK0}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 144: {SMRR_PHYSMASK_MSR, MASK64, MASK0}, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 144: {SMRR_PHYSMASK_MSR, MASK64, MASK0}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 145: }; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 146: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 147: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 148: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 149: BIOS resources initialization. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 150: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 151: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 152: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 153: ResourceInit ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 153: ResourceInit ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 154: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 154: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 155: ) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 155: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 156: { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 157: mMaxBus = 255; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 157: mMaxBus = 255; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 158: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 159: msr_t MsrRead; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 159: msr_t MsrRead; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 160: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 161: mPmBase = get_pmbase(); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 161: mPmBase = get_pmbase(); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 162: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 163: //mTsegBase = (uint32_t)rdmsr(SMRR_PHYSBASE_MSR) & 0xFFFFF000; trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 164: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 165: MsrRead = rdmsr(SMRR_PHYSBASE_MSR); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 165: MsrRead = rdmsr(SMRR_PHYSBASE_MSR); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 166: mTsegBase = MsrRead.lo & 0xFFFFF000; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 166: mTsegBase = MsrRead.lo & 0xFFFFF000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 167: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 167: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 168: //mTsegSize = (uint32_t)(~((uint32_t)rdmsr(SMRR_PHYSMASK_MSR) & 0xFFFFF000) + 1); trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 168: //mTsegSize = (uint32_t)(~((uint32_t)rdmsr(SMRR_PHYSMASK_MSR) & 0xFFFFF000) + 1); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 169: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 169: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 170: MsrRead = rdmsr(SMRR_PHYSMASK_MSR); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 170: MsrRead = rdmsr(SMRR_PHYSMASK_MSR); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 171: mTsegSize = (~(MsrRead.lo & 0xFFFFF000) + 1); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 171: mTsegSize = (~(MsrRead.lo & 0xFFFFF000) + 1); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 172: } DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 173: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 174: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 175: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 176: Fix up PCIE resource. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 177: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 178: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 179: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 180: FixupPciexResource ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 180: FixupPciexResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 181: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 181: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 182: ) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 182: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 183: { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 184: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 185: // Find max bus number and PCIEX length trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 186: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 187: //RscPcieMmio.Length = 0x10000000; // 256 MB trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 188: //RscPcieMmio.Base = PcdGet64 (PcdPciExpressBaseAddress); trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 189: } DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 190: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 191: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 192: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 193: Add basic resources to BIOS resource database. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 194: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 195: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 196: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 197: AddSimpleResources ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 197: AddSimpleResources ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 198: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 198: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 199: ) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 199: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 200: { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 201: int Status; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 201: int Status; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 202: msr64_t ReadMsr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 202: msr64_t ReadMsr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 203: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 204: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 205: // Fix-up values trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 206: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 207: RscTsegMemory.Base = mTsegBase; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 207: RscTsegMemory.Base = mTsegBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 208: RscTsegMemory.Length = mTsegSize; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 208: RscTsegMemory.Length = mTsegSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 209: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 210: RscPmIo.Base = (uint16_t) mPmBase; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 210: RscPmIo.Base = (uint16_t) mPmBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 211: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 211: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 212: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 213: // Local APIC. We assume that all thteads are programmed identically trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 214: // despite that it is possible to have individual APIC address for trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 215: // each of the threads. If this is the case this programming should trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 216: // be corrected. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 217: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 218: //RscApicMmio.Base = AsmReadMsr64 (IA32_APIC_BASE_MSR_INDEX) & 0xFFFFFF000ull; trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 218: //RscApicMmio.Base = AsmReadMsr64 (IA32_APIC_BASE_MSR_INDEX) & 0xFFFFFF000ull; line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 219: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 220: ReadMsr.msr = rdmsr(IA32_APIC_BASE_MSR_INDEX); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 221: RscApicMmio.Base = ReadMsr.uint64 & 0xFFFFFF000ull; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 222: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 223: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 224: // PCIEX BAR trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 225: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 226: FixupPciexResource (); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 226: FixupPciexResource (); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 226: FixupPciexResource (); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 227: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 228: Status = AddPiResource((void *) &RscTsegMemory, 0); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 228: Status = AddPiResource((void *) &RscTsegMemory, 0); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 229: //ASSERT_EFI_ERROR (Status); trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 230: Status = AddPiResource((void *) &RscLpcBridgePci, 1); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 230: Status = AddPiResource((void *) &RscLpcBridgePci, 1); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 231: //ASSERT_EFI_ERROR (Status); trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 232: } DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 233: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 234: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 235: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 236: Add MSR resources to BIOS resource database. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 237: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 238: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 239: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 240: AddMsrResources ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 240: AddMsrResources ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 241: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 241: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 242: ) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 242: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 243: { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 244: uint32_t Status; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 244: uint32_t Status; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 245: uint32_t Index; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 245: uint32_t Index; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 246: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 247: for (Index = 0; Index < sizeof(MsrTable)/sizeof(MsrTable[0]); Index ++) { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 247: for (Index = 0; Index < sizeof(MsrTable)/sizeof(MsrTable[0]); Index ++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 247: for (Index = 0; Index < sizeof(MsrTable)/sizeof(MsrTable[0]); Index ++) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 247: for (Index = 0; Index < sizeof(MsrTable)/sizeof(MsrTable[0]); Index ++) { Prefer ARRAY_SIZE(MsrTable)
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 247: for (Index = 0; Index < sizeof(MsrTable)/sizeof(MsrTable[0]); Index ++) { space prohibited before that '++' (ctx:WxB)
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 248: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 248: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 249: RscMsrTpl.MsrIndex = (uint32_t) MsrTable[Index].MsrIndex; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 249: RscMsrTpl.MsrIndex = (uint32_t) MsrTable[Index].MsrIndex; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 250: RscMsrTpl.ReadMask = (uint64_t) MsrTable[Index].ReadMask; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 250: RscMsrTpl.ReadMask = (uint64_t) MsrTable[Index].ReadMask; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 251: RscMsrTpl.WriteMask = (uint64_t) MsrTable[Index].WriteMask; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 251: RscMsrTpl.WriteMask = (uint64_t) MsrTable[Index].WriteMask; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 252: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 253: Status = AddPiResource ((void *) &RscMsrTpl, 1); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 253: Status = AddPiResource ((void *) &RscMsrTpl, 1); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 253: Status = AddPiResource ((void *) &RscMsrTpl, 1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 254: } DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 254: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 255: } DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 256: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 257: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 258: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 259: Add resources to BIOS resource database. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 260: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 261: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 262: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 263: AddResourcesCmd ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 263: AddResourcesCmd ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 264: void DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 264: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 265: ) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 265: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 266: { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 267: ResourceInit (); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 267: ResourceInit (); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 267: ResourceInit (); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 268: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 269: AddSimpleResources(); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 269: AddSimpleResources(); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 270: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 271: AddMsrResources (); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 271: AddMsrResources (); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 271: AddMsrResources (); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformResource... PS1, Line 272: } DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c File src/security/stm/StmPlatformSmm.c:
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@1 PS1, Line 1: /** @file trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@2 PS1, Line 2: STM platform SMM API trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@3 PS1, Line 3: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@4 PS1, Line 4: Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@5 PS1, Line 5: This program and the accompanying materials trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@6 PS1, Line 6: are licensed and made available under the terms and conditions of the BSD License trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@6 PS1, Line 6: are licensed and made available under the terms and conditions of the BSD License line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@7 PS1, Line 7: which accompanies this distribution. The full text of the license may be found at trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@7 PS1, Line 7: which accompanies this distribution. The full text of the license may be found at line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@8 PS1, Line 8: http://opensource.org/licenses/bsd-license.php. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@9 PS1, Line 9: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10 PS1, Line 10: THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11 PS1, Line 11: WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12 PS1, Line 12: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@13 PS1, Line 13: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@14 PS1, Line 14: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@15 PS1, Line 15: #include <cpu/x86/StmApi.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@16 PS1, Line 16: #include <cpu/x86/SmmStm.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@17 PS1, Line 17: #include <cpu/x86/smm.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@18 PS1, Line 18: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@19 PS1, Line 19: #include <stddef.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@20 PS1, Line 20: #include <cbfs.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@21 PS1, Line 21: #include <console/console.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@22 PS1, Line 22: #include <lib.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@23 PS1, Line 23: #include <stdint.h> DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@24 PS1, Line 24: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@25 PS1, Line 25: int LoadStmImage(uint32_t mseg); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@26 PS1, Line 26: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@27 PS1, Line 27: extern bool StmCheckStmImage(void* StmImage, uint32_t StmImageSize); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@27 PS1, Line 27: extern bool StmCheckStmImage(void* StmImage, uint32_t StmImageSize); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@28 PS1, Line 28: extern void StmGen4GPageTableIa32(uint32_t PageTableBase); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@29 PS1, Line 29: extern void StmGen4GPageTableX64 (uint32_t PageTableBase); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@29 PS1, Line 29: extern void StmGen4GPageTableX64 (uint32_t PageTableBase); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@30 PS1, Line 30: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@31 PS1, Line 31: /** trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@32 PS1, Line 32: Load STM image. trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@33 PS1, Line 33: trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@34 PS1, Line 34: @retval EFI_SUCCESS STM is loaded to MSEG trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@35 PS1, Line 35: @retval EFI_BUFFER_TOO_SMALL MSEG is too small trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@36 PS1, Line 36: @retval EFI_UNSUPPORTED MSEG is not enabled trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@37 PS1, Line 37: **/ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@38 PS1, Line 38: int LoadStmImage ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@38 PS1, Line 38: int LoadStmImage ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@39 PS1, Line 39: uint32_t mseg DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@39 PS1, Line 39: uint32_t mseg please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@40 PS1, Line 40: ) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@40 PS1, Line 40: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@41 PS1, Line 41: { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@42 PS1, Line 42: int Status; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@42 PS1, Line 42: int Status; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@43 PS1, Line 43: void *MsegBase; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@43 PS1, Line 43: void *MsegBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@44 PS1, Line 44: uint32_t StmBufferSize; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@44 PS1, Line 44: uint32_t StmBufferSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@45 PS1, Line 45: uint32_t StmImageSize; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@45 PS1, Line 45: uint32_t StmImageSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@46 PS1, Line 46: bool StmStatus; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@46 PS1, Line 46: bool StmStatus; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@47 PS1, Line 47: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@48 PS1, Line 48: STM_HEADER *StmHeader; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@48 PS1, Line 48: STM_HEADER *StmHeader; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@49 PS1, Line 49: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@50 PS1, Line 50: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@51 PS1, Line 51: // Extract STM image from FV trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@52 PS1, Line 52: // trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@53 PS1, Line 53: MsegBase = (void *) mseg; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@53 PS1, Line 53: MsegBase = (void *) mseg; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@54 PS1, Line 54: StmBufferSize = CONFIG_MSEG_SIZE; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@54 PS1, Line 54: StmBufferSize = CONFIG_MSEG_SIZE; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@55 PS1, Line 55: StmImageSize = 0; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@55 PS1, Line 55: StmImageSize = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@56 PS1, Line 56: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@57 PS1, Line 57: memset((void *) MsegBase, 0, CONFIG_MSEG_SIZE); // clear the mseg trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@57 PS1, Line 57: memset((void *) MsegBase, 0, CONFIG_MSEG_SIZE); // clear the mseg please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@58 PS1, Line 58: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@59 PS1, Line 59: StmImageSize = cbfs_boot_load_file("stm.bin", MsegBase, StmBufferSize, CBFS_TYPE_RAW); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@59 PS1, Line 59: StmImageSize = cbfs_boot_load_file("stm.bin", MsegBase, StmBufferSize, CBFS_TYPE_RAW); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@59 PS1, Line 59: StmImageSize = cbfs_boot_load_file("stm.bin", MsegBase, StmBufferSize, CBFS_TYPE_RAW); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@60 PS1, Line 60: printk(BIOS_DEBUG, "STM loaded into mseg: 0x%08x size: %u \n", (uint32_t) MsegBase, StmImageSize); /* status is number of bytes loaded */ DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@60 PS1, Line 60: printk(BIOS_DEBUG, "STM loaded into mseg: 0x%08x size: %u \n", (uint32_t) MsegBase, StmImageSize); /* status is number of bytes loaded */ line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@60 PS1, Line 60: printk(BIOS_DEBUG, "STM loaded into mseg: 0x%08x size: %u \n", (uint32_t) MsegBase, StmImageSize); /* status is number of bytes loaded */ please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@60 PS1, Line 60: printk(BIOS_DEBUG, "STM loaded into mseg: 0x%08x size: %u \n", (uint32_t) MsegBase, StmImageSize); /* status is number of bytes loaded */ unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@61 PS1, Line 61: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@62 PS1, Line 62: StmStatus = StmCheckStmImage(MsegBase, StmImageSize); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@62 PS1, Line 62: StmStatus = StmCheckStmImage(MsegBase, StmImageSize); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@63 PS1, Line 63: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@64 PS1, Line 64: StmHeader = MsegBase; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@64 PS1, Line 64: StmHeader = MsegBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@65 PS1, Line 65: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@66 PS1, Line 66: StmGen4GPageTableX64 ((uint32_t)MsegBase + StmHeader->HwStmHdr.Cr3Offset); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@66 PS1, Line 66: StmGen4GPageTableX64 ((uint32_t)MsegBase + StmHeader->HwStmHdr.Cr3Offset); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@66 PS1, Line 66: StmGen4GPageTableX64 ((uint32_t)MsegBase + StmHeader->HwStmHdr.Cr3Offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@67 PS1, Line 67: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@68 PS1, Line 68: // Debug stuff trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@69 PS1, Line 69: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@70 PS1, Line 70: printk(BIOS_DEBUG, "STM Header - Revision: 0x%08x Features: 0x%08x ... Cr3Offset: 0x%08x\n", DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@71 PS1, Line 71: StmHeader->HwStmHdr.StmHeaderRevision, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@72 PS1, Line 72: StmHeader->HwStmHdr.MonitorFeatures, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@73 PS1, Line 73: StmHeader->HwStmHdr.Cr3Offset); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@74 PS1, Line 74: printk(BIOS_DEBUG, "STM Header - StaticImageSize: %d Cr3Location: 0x%08x \n", DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@74 PS1, Line 74: printk(BIOS_DEBUG, "STM Header - StaticImageSize: %d Cr3Location: 0x%08x \n", unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@75 PS1, Line 75: StmHeader->SwStmHdr.StaticImageSize, DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@76 PS1, Line 76: ((uint32_t) MsegBase + StmHeader->HwStmHdr.Cr3Offset)); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@77 PS1, Line 77: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@78 PS1, Line 78: Status = 0; // always return good for now trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@78 PS1, Line 78: Status = 0; // always return good for now please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@79 PS1, Line 79: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@80 PS1, Line 80: return Status; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@80 PS1, Line 80: return Status; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@81 PS1, Line 81: } DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@82 PS1, Line 82: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@83 PS1, Line 83: struct descriptor DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@84 PS1, Line 84: { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@84 PS1, Line 84: { open brace '{' following struct go on the same line
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@85 PS1, Line 85: uint16_t limit; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@86 PS1, Line 86: uintptr_t base; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@87 PS1, Line 87: } __attribute__((packed)); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@88 PS1, Line 88: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@89 PS1, Line 89: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@90 PS1, Line 90: void ReadGdtr( struct descriptor * gdtr); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@90 PS1, Line 90: void ReadGdtr( struct descriptor * gdtr); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@90 PS1, Line 90: void ReadGdtr( struct descriptor * gdtr); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@91 PS1, Line 91: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@92 PS1, Line 92: void ReadGdtr( struct descriptor * gdtr) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@92 PS1, Line 92: void ReadGdtr( struct descriptor * gdtr) "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@92 PS1, Line 92: void ReadGdtr( struct descriptor * gdtr) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@93 PS1, Line 93: { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@94 PS1, Line 94: __asm__ __volatile__ ( DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@95 PS1, Line 95: "sgdt %0" DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@96 PS1, Line 96: : "=m" (*gdtr) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@97 PS1, Line 97: ); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@98 PS1, Line 98: } DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@99 PS1, Line 99: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 100: void SetupSmmDescriptor(void * smbase, int32_t state_size, int32_t apic_id, int32_t entry32_off) DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 100: void SetupSmmDescriptor(void * smbase, int32_t state_size, int32_t apic_id, int32_t entry32_off) line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 100: void SetupSmmDescriptor(void * smbase, int32_t state_size, int32_t apic_id, int32_t entry32_off) "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 101: { DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 102: struct descriptor Gdtr; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 103: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 104: TXT_PROCESSOR_SMM_DESCRIPTOR * Psd; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 104: TXT_PROCESSOR_SMM_DESCRIPTOR * Psd; "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 105: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 106: Psd = smbase + SMM_PSD_OFFSET - (apic_id * state_size); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 107: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 108: printk(BIOS_DEBUG, "Setting up Smm Descriptor - Smbase: %p Psd: %p\n", smbase, Psd); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 108: printk(BIOS_DEBUG, "Setting up Smm Descriptor - Smbase: %p Psd: %p\n", smbase, Psd); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@10... PS1, Line 109: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 110: memset(Psd, 0, sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR)); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 111: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 112: memcpy(&Psd->Signature, TXT_PROCESSOR_SMM_DESCRIPTOR_SIGNATURE, 8); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 113: Psd->SmmDescriptorVerMajor = TXT_PROCESSOR_SMM_DESCRIPTOR_VERSION_MAJOR; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 113: Psd->SmmDescriptorVerMajor = TXT_PROCESSOR_SMM_DESCRIPTOR_VERSION_MAJOR; line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 114: Psd->SmmDescriptorVerMinor = TXT_PROCESSOR_SMM_DESCRIPTOR_VERSION_MINOR; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 114: Psd->SmmDescriptorVerMinor = TXT_PROCESSOR_SMM_DESCRIPTOR_VERSION_MINOR; line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 115: Psd->SmmSmiHandlerRip = (uint64_t)((uint32_t)smbase + SMM_ENTRY_OFFSET + entry32_off); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 115: Psd->SmmSmiHandlerRip = (uint64_t)((uint32_t)smbase + SMM_ENTRY_OFFSET + entry32_off); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 116: Psd->LocalApicId = apic_id; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 117: Psd->Size = sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 118: Psd->AcpiRsdp = 0; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 119: Psd->BiosHwResourceRequirementsPtr = (uint64_t)((uint32_t)GetStmResource()); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@11... PS1, Line 119: Psd->BiosHwResourceRequirementsPtr = (uint64_t)((uint32_t)GetStmResource()); line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12... PS1, Line 120: Psd->SmmCs = 0x8; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12... PS1, Line 121: Psd->SmmDs = 0x10; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12... PS1, Line 122: Psd->SmmSs = 0x10; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12... PS1, Line 123: Psd->SmmOtherSegment = 0x10; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12... PS1, Line 124: Psd->SmmTr = 0x18; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12... PS1, Line 125: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12... PS1, Line 126: ReadGdtr(&Gdtr); DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12... PS1, Line 127: DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12... PS1, Line 128: Psd->SmmGdtPtr = Gdtr.base; DOS line endings
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12... PS1, Line 129: Psd->SmmGdtSize = Gdtr.limit + 1; // the stm will subtract, so need to compensate trailing whitespace
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@12... PS1, Line 129: Psd->SmmGdtSize = Gdtr.limit + 1; // the stm will subtract, so need to compensate line over 80 characters
https://review.coreboot.org/#/c/33215/1/src/security/stm/StmPlatformSmm.c@13... PS1, Line 130: } DOS line endings
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33215 )
Change subject: Initial commit for STM Support for Coreboot ......................................................................
Patch Set 1:
1) Split the patch up in multiple patches for security dir, cpu arch changes and security driver and so on. 2) Create src/security/intel/stm instead of src/security/stm 3) Move the include cpu stuff to security src/security/intel/stm 4) Run clang-format on your new files under src/security/intel/stm. Everything else fix it manually. 5) Remove the baytrail select because you can make src/security/intel/stm/Kconfig via make menuconfig selectable as long depends on (PLATFORM_USES_FSP2_0 || PLATFORM_USES_FSP1_1 || PLATFORM_USES_FSP1_0) because it's Intel only atm, right?
Name of user not set #1002358 has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33215 )
Change subject: Initial commit for STM Support for Coreboot ......................................................................
Abandoned
Split up into three changes