1) Split the patch up in multiple patches for security dir, cpu arch changes and security driver and so on.
2) Create src/security/intel/stm instead of src/security/stm
3) Move the include cpu stuff to security src/security/intel/stm
4) Run clang-format on your new files under src/security/intel/stm. Everything else fix it manually.
5) Remove the baytrail select because you can make src/security/intel/stm/Kconfig via make menuconfig selectable as long depends on (PLATFORM_USES_FSP2_0 || PLATFORM_USES_FSP1_1 || PLATFORM_USES_FSP1_0) because it's Intel only atm, right?

View Change

To view, visit change 33215. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ff72261e67dc64d1a40f6685b8e92ca25d9eb76
Gerrit-Change-Number: 33215
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1002358
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Kai Michaelis <kai.michaelis@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Comment-Date: Wed, 05 Jun 2019 09:49:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment