Change in coreboot[master]: arch/x86,cpu/x86: Move cpu_info initialization instructions into macro - coreboot-gerrit

24 Sep 2021


      Attention is currently required from: Julius Werner, Arthur Heymans, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57859 )
Change subject: arch/x86,cpu/x86: Move cpu_info initialization instructions into macro
......................................................................
Patch Set 3:
(1 comment)
File src/cpu/x86/cpu_info.S.inc:
https://review.coreboot.org/c/coreboot/+/57859/comment/7fd43c13_8b7b9c1c 
PS3, Line 8: push	\index
...
Is this essentially doing `push $0`? If so, why are we pushing index this way?
index is a parameter to the macro. This allows pushing a different cpu index. I have it defaulted to $0.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57859
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31f264f4bb8b605fa3cb3bfff0d9bf79224072aa
Gerrit-Change-Number: 57859
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 24 Sep 2021 15:18:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment