Change in coreboot[master]: mb/google/guybrush: Enable eSPI VW SCI events - coreboot-gerrit

5 Mar 2021


      Attention is currently required from: Raul Rangel, Martin Roth, Mathew King, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51238 )
Change subject: mb/google/guybrush: Enable eSPI VW SCI events
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/guybrush/ec.c:
https://review.coreboot.org/c/coreboot/+/51238/comment/9c1580e1_695cbf25 
PS5, Line 14: GEVENT_24
Curious how this value was determined? Also, shouldn't this be something that is done by the SoC code rather than mainboard?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51238
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12fb7c23718ad2350478b89b321e9f0aa099e53b
Gerrit-Change-Number: 51238
Gerrit-PatchSet: 5
Gerrit-Owner: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Mathew King mathewk@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Fri, 05 Mar 2021 17:21:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment