Attention is currently required from: Tim Wawrzynczak, Christian Walter, Jett Rink. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 )
Change subject: tpm: Accept Google Ti50 TPM DID:VID ......................................................................
Patch Set 8:
(4 comments)
File src/drivers/i2c/tpm/cr50.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145181): https://review.coreboot.org/c/coreboot/+/63158/comment/1874b5cb_591cfdc4 PS8, Line 507: if (CONFIG(TPM_CR50)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145181): https://review.coreboot.org/c/coreboot/+/63158/comment/6f12b444_3185aa5b PS8, Line 507: if (CONFIG(TPM_CR50)) please, no spaces at the start of a line
File src/drivers/spi/tpm/tpm.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145181): https://review.coreboot.org/c/coreboot/+/63158/comment/56a57381_613216db PS8, Line 510: if (CONFIG(TPM_CR50)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145181): https://review.coreboot.org/c/coreboot/+/63158/comment/12712f0b_6d49a26e PS8, Line 510: if (CONFIG(TPM_CR50)) please, no spaces at the start of a line