Attention is currently required from: YH Lin, Tim Wawrzynczak, Zhuohao Lee.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67736 )
Change subject: mb/google/brask/variants/moli: update emmc_rtd3 enable gpio pin
......................................................................
Patch Set 16:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159078):
https://review.coreboot.org/c/coreboot/+/67736/comment/cd1eb212_735e4c77
PS16, Line 9: EN_PP3300_EMMC has changed to GPP_A21 for DP++ and it based on Moli GPIO Table_20220803.xlsx, so update enable_gpio for emmc_rtd3 by board_ver.
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67736
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I129706861fd1fcf061371ce94352331ef44359d9
Gerrit-Change-Number: 67736
Gerrit-PatchSet: 16
Gerrit-Owner: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Wed, 21 Sep 2022 02:12:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment