Attention is currently required from: Jason Glenesk, Fred Reitberger, Felix Held.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69410 )
Change subject: soc/amd/[glinda|morgana]: Enable override of MAINBOARD_BLOBS_DIR
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/glinda/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/69410/comment/16d6bd42_57ff493e
PS1, Line 61: MAINBOARD_BLOBS_DIR:=$
we already do this for MDN which is fine, but it seems a little odd to me that we define the MAINBOARD_BLOBS_DIR at the SoC level, identically for each SoC. Perhaps it can be moved to a common location?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69410
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0702fdb97fbc2c73d97994ab4d5161ff0f467518
Gerrit-Change-Number: 69410
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 10 Nov 2022 01:20:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment