Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email )
Change subject: soc/mediatek/mt8196: Add DDP driver
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85950/comment/3eae30c2_896e6a7e?usp... :
PS2, Line 7: soc/mediatek/mt8196: Add display driver
:
: Add mt8196 firmware display support.
:
: TEST=build pass.
: BUG=b:343351631
Please revise the commit message
Done
File src/soc/mediatek/mt8196/include/soc/ddp.h:
https://review.coreboot.org/c/coreboot/+/85950/comment/41b78f6c_58d57eb1?usp... :
PS2, Line 12: 0xffffffff
upper case
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85950?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I006911e83d940c1eec7135a6a0c36fbfa2aad466
Gerrit-Change-Number: 85950
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Nancy Lin
nancy.lin@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 15 Jan 2025 09:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com