Change in coreboot[master]: console/printk.c: Prevent recursion in print functions - coreboot-gerrit

3 Feb 2021


      Attention is currently required from: Nico Huber, Julius Werner, Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49942 )
Change subject: console/printk.c: Prevent recursion in print functions
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
Well... I mean a bug is still a bug and I think we should aim to fix all of those. […]
I could try to print a message if recursion is detected, but it would be more complex to handle... I need to think about it.
I just had an idea: make the recursion guard (and also TRACK_CONSOLE_TIME) user-controllable via Kconfig. The idea is to only change the default settings for debugging purposes.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49942
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I742e4087bffa64897e9ffa47531d37e42fb2c63e
Gerrit-Change-Number: 49942
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 03 Feb 2021 11:16:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment