build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29749 )
Change subject: mb/google/dragonegg: Add initial mainboard code support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/29749/1/src/mainboard/google/dragonegg/varia... File src/mainboard/google/dragonegg/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/29749/1/src/mainboard/google/dragonegg/varia... PS1, Line 34: /* M2_SHUTDOWN+L */ PAD_CFG_GPO(GPP_C12, 1, PLTRST), please, no space before tabs
https://review.coreboot.org/#/c/29749/1/src/mainboard/google/dragonegg/varia... PS1, Line 47: /* CNV_CLKREQ0 */ PAD_CFG_NF(GPP_F5, DN_20K, PWROK, NF2), please, no space before tabs
https://review.coreboot.org/#/c/29749/1/src/mainboard/google/dragonegg/varia... File src/mainboard/google/dragonegg/variants/baseboard/memory.c:
https://review.coreboot.org/#/c/29749/1/src/mainboard/google/dragonegg/varia... PS1, Line 68: else { else should follow close brace '}'
-
build bot (Jenkins) (Code Review)