Change in coreboot[master]: soc/intel/skl + cpu/intel/common: move AES-NI locking to common cpu code
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46272 )
Change subject: soc/intel/skl + cpu/intel/common: move AES-NI locking to common cpu code ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.h File src/include/cpu/intel/msr.h:
https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.h... PS4, Line 8: #define MSR_FEATURE_CONFIG 0x13c
I meant the one that is close to this change and was used in the moved […]
got it, done locally; will be pushed with the next patchset
https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.h... PS4, Line 9: #define AESNI_LOCK_BIT 0
I would replace msr_set_bit() with _unset and _set versions like we have […]
sounds like a plan
-
Michael Niewöhner (Code Review)