[S] Change in coreboot[main]: libpayload/libc/time: Fix possible overflow in multiplication - coreboot-gerrit

3 Nov 2023


      Attention is currently required from: Julius Werner, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78888?usp=email )
Change subject: libpayload/libc/time: Fix possible overflow in multiplication
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File payloads/libpayload/libc/time.c:
https://review.coreboot.org/c/coreboot/+/78888/comment/76a92f5d_2a9b0f3e :
PS4, Line 181: 1000000
...
nit: might look better to initialize `mult` earlier and use it here. […]
There's also `MHz`.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78888?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia55532490651fcf47128b83a8554751f050bcc89
Gerrit-Change-Number: 78888
Gerrit-PatchSet: 4
Gerrit-Owner: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Fri, 03 Nov 2023 02:44:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment