Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45957 )
Change subject: [UNTESTED] soc/intel/{icl,tgl,jsl,ehl}: set PM ACPI timer state from Kconfig
......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45957/21/src/soc/intel/elkhartlake/...
File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45957/21/src/soc/intel/elkhartlake/...
PS21, Line 64: /* PM ACPI timer */
Well then, I'll drop the comments for the other platforms, too
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45957
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf1eee9297034b29b7250f6c752e6f7f52b4b908
Gerrit-Change-Number: 45957
Gerrit-PatchSet: 22
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 18:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment