Attention is currently required from: Arthur Heymans, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64198?usp=email )
Change subject: haswell NRI: Add final raminit steps
......................................................................
Patch Set 6:
(1 comment)
This change is ready for review.
File src/northbridge/intel/haswell/native_raminit/activate_mc.c:
https://review.coreboot.org/c/coreboot/+/64198/comment/ebba4ca3_f3bb3efb :
PS5, Line 191: /** TODO: Clean up asm **/
[to past self] You doofus, CB:18362 is older than your Gerrit account!
Looks like `random.c` isn't being linked for Haswell, I'd rather clean this up in a follow-up. Besides, the current approach works even though it's an eyesore.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64198?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I94f3b65f0218d4da4fda4d84592dfd91f77f8f21
Gerrit-Change-Number: 64198
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 11 Apr 2024 16:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment